From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH V5 3/7] dw-hdmi: make checkpatch happy Date: Mon, 10 Nov 2014 17:31:54 +0800 Message-ID: <5460860A.7030802@rock-chips.com> References: <1415424410-7364-1-git-send-email-andy.yan@rock-chips.com> <1415424598-7533-1-git-send-email-andy.yan@rock-chips.com> <546083C5.8060502@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <546083C5.8060502@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , djkurtz@google.com, Philipp Zabel , ykk@rock-chips.com, Grant Likely , Dave Airlie , Shawn Guo , jay.xu@rock-chips.com, Lucas Stach List-Id: devicetree@vger.kernel.org SGkgWnViYWlyTEs6Ck9uIDIwMTTlubQxMeaciDEw5pelIDE3OjIyLCBadWJhaXIgTHV0ZnVsbGFo IEtha2FraGVsIHdyb3RlOgo+IEhpIEFuZHksCj4KPiBJbiAzLjE4IHJjNCwgSSBjYW5ub3QgZmlu ZCBjaGVja3BhdGNoIGVycm9ycyBpbiBpbXgtaGRtaS5jCj4KPiBIYXZlIHRoZXNlIGVycm9ycyBj b21lIGR1cmluZyB0aGUgcHJldmlvdXMgMiBwYXRjaGVzLgo+Cj4gSWYgeWVzLCB0aGVuIHRoZXNl IGNoYW5nZXMgbmVlZCB0byBiZSBzcXVhc2hlZCBpbnRvIHRoZSBwcmV2aW91cwo+IHBhdGNoZXMu IE5vIHBhdGNoIHNob3VsZCBhZGQgYSBjaGVja3BhdGNoIGVycm9yIGFuZCB0aGVuIGZpeCBpdCBp biBhIGxhdGVyIHBhdGNoLgo+Cj4gUmVnYXJkcwo+IFp1YmFpckxLCiAgSSB1c2UgY2hlY2twYXRj aCB3aXRoIC0tc3ViamVjdGl2ZQo+IE9uIDA4LzExLzE0IDA1OjI5LCBBbmR5IFlhbiB3cm90ZToK Pj4gQ0hFQ0s6IEFsaWdubWVudCBzaG91bGQgbWF0Y2ggb3BlbiBwYXJlbnRoZXNpcwo+PiArICAg ICAgIGlmICgoaGRtaS0+dmljID09IDEwKSB8fCAoaGRtaS0+dmljID09IDExKSB8fAo+PiArICAg ICAgICAgICAgICAgKGhkbWktPnZpYyA9PSAxMikgfHwgKGhkbWktPnZpYyA9PSAxMykgfHwKPj4K Pj4gQ0hFQ0s6IGJyYWNlcyB7fSBzaG91bGQgYmUgdXNlZCBvbiBhbGwgYXJtcyBvZiB0aGlzIHN0 YXRlbWVudAo+PiArICAgICAgIGlmIChoZG1pLT5oZG1pX2RhdGEudmlkZW9fbW9kZS5tZHZpKQo+ PiBbLi4uXQo+PiArICAgICAgIGVsc2Ugewo+PiBbLi4uXQo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBB bmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1 L2RybS9icmlkZ2UvZHdfaGRtaS5jIHwgOTcgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCA0OSBkZWxl dGlvbnMoLSkKPgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0 cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJp dmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752264AbaKJJcP (ORCPT ); Mon, 10 Nov 2014 04:32:15 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:36211 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbaKJJcN (ORCPT ); Mon, 10 Nov 2014 04:32:13 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: jay.xu@rock-chips.com X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <924d727ab41622581d8b59400a93ed77> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5460860A.7030802@rock-chips.com> Date: Mon, 10 Nov 2014 17:31:54 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com Subject: Re: [PATCH V5 3/7] dw-hdmi: make checkpatch happy References: <1415424410-7364-1-git-send-email-andy.yan@rock-chips.com> <1415424598-7533-1-git-send-email-andy.yan@rock-chips.com> <546083C5.8060502@imgtec.com> In-Reply-To: <546083C5.8060502@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ZubairLK: On 2014年11月10日 17:22, Zubair Lutfullah Kakakhel wrote: > Hi Andy, > > In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c > > Have these errors come during the previous 2 patches. > > If yes, then these changes need to be squashed into the previous > patches. No patch should add a checkpatch error and then fix it in a later patch. > > Regards > ZubairLK I use checkpatch with --subjective > On 08/11/14 05:29, Andy Yan wrote: >> CHECK: Alignment should match open parenthesis >> + if ((hdmi->vic == 10) || (hdmi->vic == 11) || >> + (hdmi->vic == 12) || (hdmi->vic == 13) || >> >> CHECK: braces {} should be used on all arms of this statement >> + if (hdmi->hdmi_data.video_mode.mdvi) >> [...] >> + else { >> [...] >> >> Signed-off-by: Andy Yan >> --- >> drivers/gpu/drm/bridge/dw_hdmi.c | 97 ++++++++++++++++++++-------------------- >> 1 file changed, 48 insertions(+), 49 deletions(-) > >