From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zubair Lutfullah Kakakhel Subject: Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi Date: Mon, 10 Nov 2014 09:53:07 +0000 Message-ID: <54608B03.9050805@imgtec.com> References: <1415424410-7364-1-git-send-email-andy.yan@rock-chips.com> <1415424767-7761-1-git-send-email-andy.yan@rock-chips.com> <546082A9.5050203@imgtec.com> <546088F6.4090505@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <546088F6.4090505@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Andy Yan , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , djkurtz@google.com, Philipp Zabel , ykk@rock-chips.com, Grant Likely , Dave Airlie , Shawn Guo , jay.xu@rock-chips.com, Lucas Stach List-Id: devicetree@vger.kernel.org CgpPbiAxMC8xMS8xNCAwOTo0NCwgQW5keSBZYW4gd3JvdGU6Cj4gSGkgWnViYWlyTEsKPiBPbiAy MDE05bm0MTHmnIgxMOaXpSAxNzoxNywgWnViYWlyIEx1dGZ1bGxhaCBLYWtha2hlbCB3cm90ZToK Pj4gTmljZSB3b3JrLgo+Pgo+PiBUaGlzIHBhdGNoIHNob3VsZCBtb3ZlIHRoZSBiaW5kaW5nIGZy b20KPj4KPj4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3N0YWdpbmcvaW14LWRy bS9oZG1pLnR4dAo+PiB0byB0aGUgbG9jYXRpb24gaW5zdGVhZCBvZiBtYWtpbmcgYSBuZXcgZmls ZSBhbmQgbGVhdmluZyB0aGUgb2xkCj4+IG9uZSBpbiBwbGFjZS4KPj4KPj4gQW5kIHVzZSBnaXQg Zm9ybWF0LXBhdGNoIC1NIHRvIGhpZ2hsaWdodCBhbnkgY2hhbmdlcy4KPj4KPj4gUmVnYXJkcwo+ PiBadWJhaXJMSwo+ICAgIEkgYWRkIHRoZXNlIGJpbmRpbmdzIGZvciBkdy1oZG1pIGNvcmUsIGJl Y2F1c2UKPiAgIHByb3Blcml0aWVzIGxpa2UgcmVnLCBpbnRlcnJ1cHRzLCBkZGMtaTJjLWJ1cywg cmVnLWlvLXdpZHRoIGFyZSB1c2VkCj4gICBieSBkdy1oZG1pIGNvcmUsIGJ1dCBwcm9wZXJpdGll cyBsaWtlIGNvbXBhdGlibGUsIGdwcixjbGssIGFyZSBwbGF0Zm9ybQo+ICAgc3BlY2lmaWMgLCB0 aGV5IGFyZSBoYW5kbGVkIGJ5IHRoZSBwbGF0Zm9ybSBjb2RlIGxpa2UgZHdfaGRtaS1pbXguYwo+ ICAgYW5kIGRlc2NyaWJlZCBpbiBwbGF0Zm9ybSBzcGVjaWZpYyBkdCBiaW5kcyBsaWtlIC9pbXgt ZHJtL2hkbWkudHh0CgpJIHVuZGVyc3RhbmQuIAoKQXJlIHRoZXJlIGFueSBjaGFuZ2VzIHRvIGlt eC1kcm0vaGRtaS50eHQ/CgpTb21lIHByb3BlcnRpZXMgZm9yIGlteC1kcm0vaGRtaS50eHQgd291 bGQgYmVjb21lIG9wdGlvbmFsL2luaGVyaXRlZCBmcm9tIHRoZSBwYXJlbnQgaGRtaSBkcm0gYmlu ZGluZz8KClRoZSBjaGFuZ2VzIHNob3VsZCBiZSBoaWdobGlnaHRlZCBpbiB0aGUgY29tbWl0IG1l c3NhZ2UuIE9yIHdlJ2xsCmJlIGNvbmZ1c2VkIHdoaWNoIGlzIHdoaWNoLi4KClp1YmFpckxLCgo+ PiBPbiAwOC8xMS8xNCAwNTozMiwgQW5keSBZYW4gd3JvdGU6Cj4+PiBTaWduZWQtb2ZmLWJ5OiBB bmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5jb20+Cj4+PiAtLS0KPj4+ICAgLi4uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kdy1oZG1pLnR4dCAgICAgfCAzOCArKysrKysrKysr KysrKysrKysrKysrCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspCj4+PiAg IGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZHJt L2JyaWRnZS9kdy1oZG1pLnR4dAo+Pj4KPj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kdy1oZG1pLnR4dCBiL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3LWhkbWkudHh0Cj4+PiBuZXcgZmlsZSBt b2RlIDEwMDY0NAo+Pj4gaW5kZXggMDAwMDAwMC4uYWE3ZWQxNwo+Pj4gLS0tIC9kZXYvbnVsbAo+ Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RybS9icmlkZ2UvZHct aGRtaS50eHQKPj4+IEBAIC0wLDAgKzEsMzggQEAKPj4+ICtEZXNpZ25XYXJlIEhETUkgYnJpZGdl IGJpbmRpbmdzCj4+PiArCj4+PiArUmVxdWlyZWQgcHJvcGVyaXRpZXM6Cj4+PiArLSBjb21wYXRp YmVsOiBwbGF0Zm9ybSBzcGVjaWZpYyBzdWNoIGFzICJmc2wsaW14NnEtaGRtaSIsImZzbCxpbXg2 ZGwtaGRtaSIKCnNwZWxsY2hlY2suIGNvbXBhdGlibGUKCj4+PiArICAgICAgICAgICJyb2NrY2hp cCxyazMyODgtZHctaGRtaSIKPj4+ICstIHJlZzogcGh5c2ljYWwgYmFzZSBhZGRyZXNzIG9mIHRo ZSBjb250cm9sbGVyIGFuZCBsZW5ndGgKPj4+ICstIGRkYy1pMmMtYnVzOiB0aGUgZGRjIGkyYyBi dXMKPj4+ICstIGludGVycnVwdHM6IFRoZSBpbnRlcnJ1cHQgbnVtYmVyIHRvIHRoZSBjcHUKPj4+ ICsKPj4+ICtPcHRpb25hbCBwcm9wZXJ0aWVzCj4+PiArLSByZWctaW8td2lkdGg6IHRoZSB3aWR0 aCBvZiB0aGUgcmVnOjEsNCwgZGVmYXVsdCBzZXQgdG8gMSBpZiBub3QgcHJlc2VudAo+Pj4gKwo+ Pj4gK0V4YW1wbGU6Cj4+PiArICAgIGhkbWk6IGhkbWlAMDEyMDAwMCB7Cj4+PiArICAgICAgICBj b21wYXRpYmxlID0gImZzbCxpbXg2cS1oZG1pIjsKPj4+ICsgICAgICAgIHJlZyA9IDwweDAwMTIw MDAwIDB4OTAwMD47Cj4+PiArICAgICAgICBpbnRlcnJ1cHRzID0gPDAgMTE1IDB4MDQ+Owo+Pj4g KyAgICAgICAgZ3ByID0gPCZncHI+Owo+Pj4gKyAgICAgICAgY2xvY2tzID0gPCZjbGtzIDEyMz4s IDwmY2xrcyAxMjQ+Owo+Pj4gKyAgICAgICAgY2xvY2stbmFtZXMgPSAiaWFoYiIsICJpc2ZyIjsK Pj4+ICsgICAgICAgIGRkYy1pMmMtYnVzID0gPCZpMmMyPjsKPj4+ICsKPj4+ICsgICAgICAgIHBv cnRAMCB7Cj4+PiArICAgICAgICAgICAgcmVnID0gPDA+Owo+Pj4gKwo+Pj4gKyAgICAgICAgICAg IGhkbWlfbXV4XzA6IGVuZHBvaW50IHsKPj4+ICsgICAgICAgICAgICAgICAgcmVtb3RlLWVuZHBv aW50ID0gPCZpcHUxX2RpMF9oZG1pPjsKPj4+ICsgICAgICAgICAgICB9Owo+Pj4gKyAgICAgICAg fTsKPj4+ICsKPj4+ICsgICAgICAgIHBvcnRAMSB7Cj4+PiArICAgICAgICAgICAgcmVnID0gPDE+ Owo+Pj4gKwo+Pj4gKyAgICAgICAgICAgIGhkbWlfbXV4XzE6IGVuZHBvaW50IHsKPj4+ICsgICAg ICAgICAgICAgICAgcmVtb3RlLWVuZHBvaW50ID0gPCZpcHUxX2RpMV9oZG1pPjsKPj4+ICsgICAg ICAgICAgICB9Owo+Pj4gKyAgICAgICAgfTsKPj4+ICsgICAgfTsKPj4+Cj4+Cj4+Cj4gCj4gCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxp bmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGlu dXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbaKJJxT (ORCPT ); Mon, 10 Nov 2014 04:53:19 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:57193 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbaKJJxR (ORCPT ); Mon, 10 Nov 2014 04:53:17 -0500 Message-ID: <54608B03.9050805@imgtec.com> Date: Mon, 10 Nov 2014 09:53:07 +0000 From: Zubair Lutfullah Kakakhel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andy Yan , , , , CC: Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , , , , , , , , Subject: Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi References: <1415424410-7364-1-git-send-email-andy.yan@rock-chips.com> <1415424767-7761-1-git-send-email-andy.yan@rock-chips.com> <546082A9.5050203@imgtec.com> <546088F6.4090505@rock-chips.com> In-Reply-To: <546088F6.4090505@rock-chips.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.154.89] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/14 09:44, Andy Yan wrote: > Hi ZubairLK > On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote: >> Nice work. >> >> This patch should move the binding from >> >> Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt >> to the location instead of making a new file and leaving the old >> one in place. >> >> And use git format-patch -M to highlight any changes. >> >> Regards >> ZubairLK > I add these bindings for dw-hdmi core, because > properities like reg, interrupts, ddc-i2c-bus, reg-io-width are used > by dw-hdmi core, but properities like compatible, gpr,clk, are platform > specific , they are handled by the platform code like dw_hdmi-imx.c > and described in platform specific dt binds like /imx-drm/hdmi.txt I understand. Are there any changes to imx-drm/hdmi.txt? Some properties for imx-drm/hdmi.txt would become optional/inherited from the parent hdmi drm binding? The changes should be highlighted in the commit message. Or we'll be confused which is which.. ZubairLK >> On 08/11/14 05:32, Andy Yan wrote: >>> Signed-off-by: Andy Yan >>> --- >>> .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++++++++++++++++++++++ >>> 1 file changed, 38 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>> >>> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>> new file mode 100644 >>> index 0000000..aa7ed17 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>> @@ -0,0 +1,38 @@ >>> +DesignWare HDMI bridge bindings >>> + >>> +Required properities: >>> +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi" spellcheck. compatible >>> + "rockchip,rk3288-dw-hdmi" >>> +- reg: physical base address of the controller and length >>> +- ddc-i2c-bus: the ddc i2c bus >>> +- interrupts: The interrupt number to the cpu >>> + >>> +Optional properties >>> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present >>> + >>> +Example: >>> + hdmi: hdmi@0120000 { >>> + compatible = "fsl,imx6q-hdmi"; >>> + reg = <0x00120000 0x9000>; >>> + interrupts = <0 115 0x04>; >>> + gpr = <&gpr>; >>> + clocks = <&clks 123>, <&clks 124>; >>> + clock-names = "iahb", "isfr"; >>> + ddc-i2c-bus = <&i2c2>; >>> + >>> + port@0 { >>> + reg = <0>; >>> + >>> + hdmi_mux_0: endpoint { >>> + remote-endpoint = <&ipu1_di0_hdmi>; >>> + }; >>> + }; >>> + >>> + port@1 { >>> + reg = <1>; >>> + >>> + hdmi_mux_1: endpoint { >>> + remote-endpoint = <&ipu1_di1_hdmi>; >>> + }; >>> + }; >>> + }; >>> >> >> > >