From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi Date: Mon, 10 Nov 2014 17:59:01 +0800 Message-ID: <54608C65.7050902@rock-chips.com> References: <1415424410-7364-1-git-send-email-andy.yan@rock-chips.com> <1415424767-7761-1-git-send-email-andy.yan@rock-chips.com> <546082A9.5050203@imgtec.com> <546088F6.4090505@rock-chips.com> <54608B03.9050805@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <54608B03.9050805@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , djkurtz@google.com, Philipp Zabel , ykk@rock-chips.com, Grant Likely , Dave Airlie , Shawn Guo , jay.xu@rock-chips.com, Lucas Stach List-Id: devicetree@vger.kernel.org Ck9uIDIwMTTlubQxMeaciDEw5pelIDE3OjUzLCBadWJhaXIgTHV0ZnVsbGFoIEtha2FraGVsIHdy b3RlOgo+Cj4gT24gMTAvMTEvMTQgMDk6NDQsIEFuZHkgWWFuIHdyb3RlOgo+PiBIaSBadWJhaXJM Swo+PiBPbiAyMDE05bm0MTHmnIgxMOaXpSAxNzoxNywgWnViYWlyIEx1dGZ1bGxhaCBLYWtha2hl bCB3cm90ZToKPj4+IE5pY2Ugd29yay4KPj4+Cj4+PiBUaGlzIHBhdGNoIHNob3VsZCBtb3ZlIHRo ZSBiaW5kaW5nIGZyb20KPj4+Cj4+PiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv c3RhZ2luZy9pbXgtZHJtL2hkbWkudHh0Cj4+PiB0byB0aGUgbG9jYXRpb24gaW5zdGVhZCBvZiBt YWtpbmcgYSBuZXcgZmlsZSBhbmQgbGVhdmluZyB0aGUgb2xkCj4+PiBvbmUgaW4gcGxhY2UuCj4+ Pgo+Pj4gQW5kIHVzZSBnaXQgZm9ybWF0LXBhdGNoIC1NIHRvIGhpZ2hsaWdodCBhbnkgY2hhbmdl cy4KPj4+Cj4+PiBSZWdhcmRzCj4+PiBadWJhaXJMSwo+PiAgICAgSSBhZGQgdGhlc2UgYmluZGlu Z3MgZm9yIGR3LWhkbWkgY29yZSwgYmVjYXVzZQo+PiAgICBwcm9wZXJpdGllcyBsaWtlIHJlZywg aW50ZXJydXB0cywgZGRjLWkyYy1idXMsIHJlZy1pby13aWR0aCBhcmUgdXNlZAo+PiAgICBieSBk dy1oZG1pIGNvcmUsIGJ1dCBwcm9wZXJpdGllcyBsaWtlIGNvbXBhdGlibGUsIGdwcixjbGssIGFy ZSBwbGF0Zm9ybQo+PiAgICBzcGVjaWZpYyAsIHRoZXkgYXJlIGhhbmRsZWQgYnkgdGhlIHBsYXRm b3JtIGNvZGUgbGlrZSBkd19oZG1pLWlteC5jCj4+ICAgIGFuZCBkZXNjcmliZWQgaW4gcGxhdGZv cm0gc3BlY2lmaWMgZHQgYmluZHMgbGlrZSAvaW14LWRybS9oZG1pLnR4dAo+IEkgdW5kZXJzdGFu ZC4KPgo+IEFyZSB0aGVyZSBhbnkgY2hhbmdlcyB0byBpbXgtZHJtL2hkbWkudHh0Pwo+Cj4gU29t ZSBwcm9wZXJ0aWVzIGZvciBpbXgtZHJtL2hkbWkudHh0IHdvdWxkIGJlY29tZSBvcHRpb25hbC9p bmhlcml0ZWQgZnJvbSB0aGUgcGFyZW50IGhkbWkgZHJtIGJpbmRpbmc/Cj4KPiBUaGUgY2hhbmdl cyBzaG91bGQgYmUgaGlnaGxpZ2h0ZWQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLiBPciB3ZSdsbAo+ IGJlIGNvbmZ1c2VkIHdoaWNoIGlzIHdoaWNoLi4KPgo+IFp1YmFpckxLCj4KICAgdG8ga2VlcCAg IGNvbXBhdGlibGUgZm9yIGlteCwgbm8gY2hhbmdlcyBmb3IgaW14LWRybS9oZG1pLnR4dAogICB0 aGUgb25seSBhZGRlZCBwcm9wZXJ0aWVzICBpcyByZWctaW8td2lkdGgsIGFuZCBpdCBpcyBvcHRp b25hbAo+Pj4gT24gMDgvMTEvMTQgMDU6MzIsIEFuZHkgWWFuIHdyb3RlOgo+Pj4+IFNpZ25lZC1v ZmYtYnk6IEFuZHkgWWFuIDxhbmR5LnlhbkByb2NrLWNoaXBzLmNvbT4KPj4+PiAtLS0KPj4+PiAg ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3LWhkbWkudHh0ICAgICB8IDM4 ICsrKysrKysrKysrKysrKysrKysrKysKPj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMzggaW5zZXJ0 aW9ucygrKQo+Pj4+ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kdy1oZG1pLnR4dAo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBh L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3LWhkbWkudHh0 IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RybS9icmlkZ2UvZHctaGRtaS50 eHQKPj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+Pj4+IGluZGV4IDAwMDAwMDAuLmFhN2VkMTcK Pj4+PiAtLS0gL2Rldi9udWxsCj4+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2RybS9icmlkZ2UvZHctaGRtaS50eHQKPj4+PiBAQCAtMCwwICsxLDM4IEBACj4+Pj4g K0Rlc2lnbldhcmUgSERNSSBicmlkZ2UgYmluZGluZ3MKPj4+PiArCj4+Pj4gK1JlcXVpcmVkIHBy b3Blcml0aWVzOgo+Pj4+ICstIGNvbXBhdGliZWw6IHBsYXRmb3JtIHNwZWNpZmljIHN1Y2ggYXMg ImZzbCxpbXg2cS1oZG1pIiwiZnNsLGlteDZkbC1oZG1pIgo+IHNwZWxsY2hlY2suIGNvbXBhdGli bGUKPgo+Pj4+ICsgICAgICAgICAgInJvY2tjaGlwLHJrMzI4OC1kdy1oZG1pIgo+Pj4+ICstIHJl ZzogcGh5c2ljYWwgYmFzZSBhZGRyZXNzIG9mIHRoZSBjb250cm9sbGVyIGFuZCBsZW5ndGgKPj4+ PiArLSBkZGMtaTJjLWJ1czogdGhlIGRkYyBpMmMgYnVzCj4+Pj4gKy0gaW50ZXJydXB0czogVGhl IGludGVycnVwdCBudW1iZXIgdG8gdGhlIGNwdQo+Pj4+ICsKPj4+PiArT3B0aW9uYWwgcHJvcGVy dGllcwo+Pj4+ICstIHJlZy1pby13aWR0aDogdGhlIHdpZHRoIG9mIHRoZSByZWc6MSw0LCBkZWZh dWx0IHNldCB0byAxIGlmIG5vdCBwcmVzZW50Cj4+Pj4gKwo+Pj4+ICtFeGFtcGxlOgo+Pj4+ICsg ICAgaGRtaTogaGRtaUAwMTIwMDAwIHsKPj4+PiArICAgICAgICBjb21wYXRpYmxlID0gImZzbCxp bXg2cS1oZG1pIjsKPj4+PiArICAgICAgICByZWcgPSA8MHgwMDEyMDAwMCAweDkwMDA+Owo+Pj4+ ICsgICAgICAgIGludGVycnVwdHMgPSA8MCAxMTUgMHgwND47Cj4+Pj4gKyAgICAgICAgZ3ByID0g PCZncHI+Owo+Pj4+ICsgICAgICAgIGNsb2NrcyA9IDwmY2xrcyAxMjM+LCA8JmNsa3MgMTI0PjsK Pj4+PiArICAgICAgICBjbG9jay1uYW1lcyA9ICJpYWhiIiwgImlzZnIiOwo+Pj4+ICsgICAgICAg IGRkYy1pMmMtYnVzID0gPCZpMmMyPjsKPj4+PiArCj4+Pj4gKyAgICAgICAgcG9ydEAwIHsKPj4+ PiArICAgICAgICAgICAgcmVnID0gPDA+Owo+Pj4+ICsKPj4+PiArICAgICAgICAgICAgaGRtaV9t dXhfMDogZW5kcG9pbnQgewo+Pj4+ICsgICAgICAgICAgICAgICAgcmVtb3RlLWVuZHBvaW50ID0g PCZpcHUxX2RpMF9oZG1pPjsKPj4+PiArICAgICAgICAgICAgfTsKPj4+PiArICAgICAgICB9Owo+ Pj4+ICsKPj4+PiArICAgICAgICBwb3J0QDEgewo+Pj4+ICsgICAgICAgICAgICByZWcgPSA8MT47 Cj4+Pj4gKwo+Pj4+ICsgICAgICAgICAgICBoZG1pX211eF8xOiBlbmRwb2ludCB7Cj4+Pj4gKyAg ICAgICAgICAgICAgICByZW1vdGUtZW5kcG9pbnQgPSA8JmlwdTFfZGkxX2hkbWk+Owo+Pj4+ICsg ICAgICAgICAgICB9Owo+Pj4+ICsgICAgICAgIH07Cj4+Pj4gKyAgICB9Owo+Pj4+Cj4+Pgo+Pgo+ Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZl bCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVy ZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbaKJJ7O (ORCPT ); Mon, 10 Nov 2014 04:59:14 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:37039 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbaKJJ7K (ORCPT ); Mon, 10 Nov 2014 04:59:10 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: jay.xu@rock-chips.com X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <4251aaf8348b8aaec1f067d9abdf50de> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54608C65.7050902@rock-chips.com> Date: Mon, 10 Nov 2014 17:59:01 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com Subject: Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi References: <1415424410-7364-1-git-send-email-andy.yan@rock-chips.com> <1415424767-7761-1-git-send-email-andy.yan@rock-chips.com> <546082A9.5050203@imgtec.com> <546088F6.4090505@rock-chips.com> <54608B03.9050805@imgtec.com> In-Reply-To: <54608B03.9050805@imgtec.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年11月10日 17:53, Zubair Lutfullah Kakakhel wrote: > > On 10/11/14 09:44, Andy Yan wrote: >> Hi ZubairLK >> On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote: >>> Nice work. >>> >>> This patch should move the binding from >>> >>> Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt >>> to the location instead of making a new file and leaving the old >>> one in place. >>> >>> And use git format-patch -M to highlight any changes. >>> >>> Regards >>> ZubairLK >> I add these bindings for dw-hdmi core, because >> properities like reg, interrupts, ddc-i2c-bus, reg-io-width are used >> by dw-hdmi core, but properities like compatible, gpr,clk, are platform >> specific , they are handled by the platform code like dw_hdmi-imx.c >> and described in platform specific dt binds like /imx-drm/hdmi.txt > I understand. > > Are there any changes to imx-drm/hdmi.txt? > > Some properties for imx-drm/hdmi.txt would become optional/inherited from the parent hdmi drm binding? > > The changes should be highlighted in the commit message. Or we'll > be confused which is which.. > > ZubairLK > to keep compatible for imx, no changes for imx-drm/hdmi.txt the only added properties is reg-io-width, and it is optional >>> On 08/11/14 05:32, Andy Yan wrote: >>>> Signed-off-by: Andy Yan >>>> --- >>>> .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++++++++++++++++++++++ >>>> 1 file changed, 38 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>>> new file mode 100644 >>>> index 0000000..aa7ed17 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>>> @@ -0,0 +1,38 @@ >>>> +DesignWare HDMI bridge bindings >>>> + >>>> +Required properities: >>>> +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi" > spellcheck. compatible > >>>> + "rockchip,rk3288-dw-hdmi" >>>> +- reg: physical base address of the controller and length >>>> +- ddc-i2c-bus: the ddc i2c bus >>>> +- interrupts: The interrupt number to the cpu >>>> + >>>> +Optional properties >>>> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present >>>> + >>>> +Example: >>>> + hdmi: hdmi@0120000 { >>>> + compatible = "fsl,imx6q-hdmi"; >>>> + reg = <0x00120000 0x9000>; >>>> + interrupts = <0 115 0x04>; >>>> + gpr = <&gpr>; >>>> + clocks = <&clks 123>, <&clks 124>; >>>> + clock-names = "iahb", "isfr"; >>>> + ddc-i2c-bus = <&i2c2>; >>>> + >>>> + port@0 { >>>> + reg = <0>; >>>> + >>>> + hdmi_mux_0: endpoint { >>>> + remote-endpoint = <&ipu1_di0_hdmi>; >>>> + }; >>>> + }; >>>> + >>>> + port@1 { >>>> + reg = <1>; >>>> + >>>> + hdmi_mux_1: endpoint { >>>> + remote-endpoint = <&ipu1_di1_hdmi>; >>>> + }; >>>> + }; >>>> + }; >>>> >>> >> > >