From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure Date: Mon, 10 Nov 2014 14:53:29 +0200 Message-ID: <5460B549.40203@ti.com> References: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by alsa0.perex.cz (Postfix) with ESMTP id AD6FA2606BD for ; Mon, 10 Nov 2014 13:53:37 +0100 (CET) In-Reply-To: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Anil Kumar , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org Cc: tiwai@suse.de, davinci-linux-open-source@linux.davincidsp.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On 11/09/2014 02:45 PM, Anil Kumar wrote: > If probe fails then we need to call pm_runtime_disable() to balance > out the previous pm_runtime_enable() call. Acked-by: Peter Ujfalusi > = > Signed-off-by: Anil Kumar > --- > :100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c > sound/soc/davinci/davinci-mcasp.c | 1 + > 1 file changed, 1 insertion(+) > = > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinc= i-mcasp.c > index 0eed9b1..99c747d 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_devi= ce *pdev) > ret =3D pm_runtime_get_sync(&pdev->dev); > if (IS_ERR_VALUE(ret)) { > dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n"); > + pm_runtime_disable(&pdev->dev); > return ret; > } > = > = -- = P=E9ter From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Mon, 10 Nov 2014 14:53:29 +0200 Subject: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure In-Reply-To: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com> References: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com> Message-ID: <5460B549.40203@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/09/2014 02:45 PM, Anil Kumar wrote: > If probe fails then we need to call pm_runtime_disable() to balance > out the previous pm_runtime_enable() call. Acked-by: Peter Ujfalusi > > Signed-off-by: Anil Kumar > --- > :100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c > sound/soc/davinci/davinci-mcasp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c > index 0eed9b1..99c747d 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev) > ret = pm_runtime_get_sync(&pdev->dev); > if (IS_ERR_VALUE(ret)) { > dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n"); > + pm_runtime_disable(&pdev->dev); > return ret; > } > > -- P?ter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbaKJMyL (ORCPT ); Mon, 10 Nov 2014 07:54:11 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:44717 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752895AbaKJMyI (ORCPT ); Mon, 10 Nov 2014 07:54:08 -0500 Message-ID: <5460B549.40203@ti.com> Date: Mon, 10 Nov 2014 14:53:29 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Anil Kumar , , , , CC: , , , Subject: Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure References: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com> In-Reply-To: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2014 02:45 PM, Anil Kumar wrote: > If probe fails then we need to call pm_runtime_disable() to balance > out the previous pm_runtime_enable() call. Acked-by: Peter Ujfalusi > > Signed-off-by: Anil Kumar > --- > :100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c > sound/soc/davinci/davinci-mcasp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c > index 0eed9b1..99c747d 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev) > ret = pm_runtime_get_sync(&pdev->dev); > if (IS_ERR_VALUE(ret)) { > dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n"); > + pm_runtime_disable(&pdev->dev); > return ret; > } > > -- Péter