From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: jcody@redhat.com, armbru@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/9] qemu-io: Allow explicitly specifying format
Date: Mon, 10 Nov 2014 15:07:41 +0100 [thread overview]
Message-ID: <5460C6AD.6070802@redhat.com> (raw)
In-Reply-To: <1415389165-16157-2-git-send-email-kwolf@redhat.com>
On 2014-11-07 at 20:39, Kevin Wolf wrote:
> This adds a -f option to qemu-io which allows to explicitly specify the
> block driver to use for the given image.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qemu-io.c | 28 ++++++++++++++++++++--------
> 1 file changed, 20 insertions(+), 8 deletions(-)
I would have liked the same option for the "open" command, but well.
And maybe also an error if a format but no filename has been specified,
but qemu-io already does not emit an error if some other image option
has been specified, so it's fine.
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-11-10 14:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 19:39 [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images Kevin Wolf
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 1/9] qemu-io: Allow explicitly specifying format Kevin Wolf
2014-11-10 14:07 ` Max Reitz [this message]
2014-11-10 14:18 ` Max Reitz
2014-11-10 19:24 ` Eric Blake
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 2/9] qemu-iotests: Use qemu-io -f $IMGFMT Kevin Wolf
2014-11-10 14:21 ` Max Reitz
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 3/9] qemu-iotests: Add qemu-io format option in Python tests Kevin Wolf
2014-11-10 14:29 ` Max Reitz
2014-11-10 14:33 ` Kevin Wolf
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 4/9] qtests: Specify image format explicitly Kevin Wolf
2014-11-10 14:39 ` Max Reitz
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 5/9] block: Factor bdrv_probe_all() out of find_image_format() Kevin Wolf
2014-11-10 14:47 ` Max Reitz
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 6/9] block: Read only one sector for format probing Kevin Wolf
2014-11-10 14:48 ` Max Reitz
2014-11-13 10:36 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 7/9] raw: Prohibit dangerous writes for probed images Kevin Wolf
2014-11-10 15:03 ` Max Reitz
2014-11-10 19:51 ` Eric Blake
2014-11-13 10:46 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 8/9] qemu-iotests: Fix stderr handling in common.qemu Kevin Wolf
2014-11-10 15:04 ` Max Reitz
2014-11-10 19:55 ` Eric Blake
2014-11-13 10:48 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image headers to raw image Kevin Wolf
2014-11-10 15:53 ` Max Reitz
2014-11-10 20:00 ` Eric Blake
2014-11-13 10:48 ` Stefan Hajnoczi
2014-11-10 20:02 ` [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images Eric Blake
2014-11-11 10:03 ` Markus Armbruster
2014-11-13 10:49 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460C6AD.6070802@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.