From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH for Xen 4.5 v2 2/2] xen: serialize vcpu data in sched_rt.c Date: Mon, 10 Nov 2014 15:38:16 +0000 Message-ID: <5460DBE8.4060701@eu.citrix.com> References: <1414246599-3914-1-git-send-email-mengxu@cis.upenn.edu> <1414246599-3914-3-git-send-email-mengxu@cis.upenn.edu> <5460B550.9000306@eu.citrix.com> <1415633819.3717.43.camel@Abyss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1415633819.3717.43.camel@Abyss> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli , Meng Xu Cc: Ian Campbell , Stefano Stabellini , Ian Jackson , "xen-devel@lists.xen.org" , Meng Xu , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 11/10/2014 03:36 PM, Dario Faggioli wrote: > On Mon, 2014-11-10 at 10:29 -0500, Meng Xu wrote: >> I'm not sure if I should resend the patch just to change the commit >> log and add the reason of why doing this. >> > Yes, that is usually quite a good reason, as changelogs are really > important (for the reasons George pointed out already). > > Sometimes, maintainers and committers do the edits themselves (after > asking or at least informing the mailing list), but this only happens > for minor and not substantial modifications. > > In this case, the most correct thing is that you resend. > > >> George, if I should resend the patch set, please let me know. >> > I'm not George but, yes, please, do resend. :-) What Dario said. :-) -George