From: Eric Blake <eblake@redhat.com>
To: SeokYeon Hwang <syeon.hwang@samsung.com>, qemu-devel@nongnu.org
Cc: kongjianjun@gmail.com, paolo.bonzini@gmail.com,
armbru@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong
Date: Mon, 10 Nov 2014 09:14:25 -0700 [thread overview]
Message-ID: <5460E461.6020509@redhat.com> (raw)
In-Reply-To: <1415598889-11244-1-git-send-email-syeon.hwang@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On 11/09/2014 10:54 PM, SeokYeon Hwang wrote:
> Added 'assert(os_errno > 0)' in 'error_set_errno()'.
Commit message...
> Fixed errno since it passes wrong value to 'error_set_errno()'.
>
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
> hw/pci/pcie.c | 2 +-
> +++ b/util/error.c
> @@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno, ErrorClass err_class,
> return;
> }
> assert(*errp == NULL);
> + assert(os_errno >= 0);
...does not match code. (Code is correct).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-10 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 5:54 [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong SeokYeon Hwang
2014-11-10 6:32 ` Amos Kong
2014-11-10 8:36 ` Max Reitz
2014-11-10 9:32 ` Markus Armbruster
2014-11-10 12:57 ` SeokYeon Hwang
2014-11-10 13:20 ` Markus Armbruster
2014-11-12 7:09 ` SeokYeon Hwang
2014-11-10 16:14 ` Eric Blake [this message]
2014-11-12 7:00 ` SeokYeon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460E461.6020509@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kongjianjun@gmail.com \
--cc=mreitz@redhat.com \
--cc=paolo.bonzini@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=syeon.hwang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.