All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giedrius Statkevicius <giedrius.statkevicius@gmail.com>
To: Jim Davis <jim.epost@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	eric.piel@tremplin-utc.net, dvhart@infradead.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: randconfig build error with next-20141110, in drivers/platform/x86/hp_accel.c
Date: Mon, 10 Nov 2014 18:59:46 +0200	[thread overview]
Message-ID: <5460EF02.3000904@gmail.com> (raw)
In-Reply-To: <CA+r1Zhio+KeBH0FFHwj=_fTFjqzebeE7Y2O_vsvMco49Sp56jw@mail.gmail.com>

Hi Jim,

On 2014.11.10 18:20, Jim Davis wrote:
> Building with the attached random configuration file,
> 
> drivers/built-in.o: In function `lis3lv02d_remove':
> /home/jim/linux/drivers/platform/x86/hp_accel.c:389: undefined
> reference to `i8042_remove_filter'
> drivers/built-in.o: In function `lis3lv02d_add':
> /home/jim/linux/drivers/platform/x86/hp_accel.c:370: undefined
> reference to `i8042_install_filter'
> make: *** [vmlinux] Error 1
> 

Oops, sorry. Forgot to add a depend on i8042 per this patch in Kconfig:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a4c724d0723b078e4ab4670e557cda1795036a7a

This patch should fix it. After applying and using your .config I
compiled the kernel without those undefined references. Should I make a
new thread where it's submitted in the proper form? 

thanks,
Giedrius
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 4dcfb71..7d146e68 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -202,6 +202,7 @@ config TC1100_WMI
 config HP_ACCEL
 	tristate "HP laptop accelerometer"
 	depends on INPUT && ACPI
+        depends on SERIO_I8042
 	select SENSORS_LIS3LV02D
 	select NEW_LEDS
 	select LEDS_CLASS
-- 
2.1.3

  reply	other threads:[~2014-11-10 16:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 16:20 randconfig build error with next-20141110, in drivers/platform/x86/hp_accel.c Jim Davis
2014-11-10 16:59 ` Giedrius Statkevicius [this message]
2014-11-10 17:19   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5460EF02.3000904@gmail.com \
    --to=giedrius.statkevicius@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=eric.piel@tremplin-utc.net \
    --cc=jim.epost@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.