From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54821)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Xnzad-00011q-JF
	for qemu-devel@nongnu.org; Mon, 10 Nov 2014 19:45:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XnzaY-0005aw-PL
	for qemu-devel@nongnu.org; Mon, 10 Nov 2014 19:45:47 -0500
Received: from szxga01-in.huawei.com ([119.145.14.64]:58878)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XnzaY-0005aW-6x
	for qemu-devel@nongnu.org; Mon, 10 Nov 2014 19:45:42 -0500
Message-ID: <54615C23.1090002@huawei.com>
Date: Tue, 11 Nov 2014 08:45:23 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1415618126-20284-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1415618126-20284-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] usb-host: fix usb_host_speed_compat tyops
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 2014/11/10 19:15, Gerd Hoffmann wrote:

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/usb/host-libusb.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index 032a0e4..a5f9dab 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -749,13 +749,13 @@ static void usb_host_speed_compat(USBHostDevice *s)
>  
>      udev->speedmask = (1 << udev->speed);
>      if (udev->speed == USB_SPEED_SUPER && compat_high) {
> -        udev->speedmask |= USB_SPEED_HIGH;
> +        udev->speedmask |= USB_SPEED_MASK_HIGH;
>      }
>      if (udev->speed == USB_SPEED_SUPER && compat_full) {
> -        udev->speedmask |= USB_SPEED_FULL;
> +        udev->speedmask |= USB_SPEED_MASK_FULL;
>      }
>      if (udev->speed == USB_SPEED_HIGH && compat_full) {
> -        udev->speedmask |= USB_SPEED_FULL;
> +        udev->speedmask |= USB_SPEED_MASK_FULL;
>      }
>  }
>  

Nice catch. :)
Please s/tyops/typos/ in the patch's subject, and of course:

Reviewed-by: Gonglei <arei.gonglei@huawei.com>

Best regards,
-Gonglei