All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Severin Tillmann, DE-862" <Tillmann.Severin@bmw.de>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] smolkit: Add low-footprint drop-in replacement for polkit
Date: Wed, 16 Sep 2026 22:44:31 -0700	[thread overview]
Message-ID: <546192.1789623871363509840@lists.openembedded.org> (raw)
In-Reply-To: <E76E2C6A-43C3-4E87-BDBA-D8DDA125E2A4@arm.com>

[-- Attachment #1: Type: text/plain, Size: 2042 bytes --]

Hi Ross,

thanks a lot for your feedback!

On Tue, Sep 15, 2026 at 06:30 AM, Ross Burton wrote:

> 
> On 14 Sep 2026, at 13:29, Severin Tillmann, DE-862 via
> lists.openembedded.org <Tillmann.Severin=bmw.de@lists.openembedded.org>
> wrote:
> 
>> +CONFLICT_DISTRO_FEATURES = "polkit"
>> +REQUIRED_DISTRO_FEATURES = "smolkit"
> 
> This makes the claim of “drop-in replacement” suspicious, because it would
> mean every recipe that currently depends on polkit and respects the polkit
> DISTRO_FEATURE needs to be modified.
> 
> Could smolkit not PROVIDE polkit, so the distro can just switch the
> preferred provider and everything just works?

You are of course right, smolkit is not a complete drop-in replacement (yet), it is only a drop-in replacement for a certain subset of polkit's interface, I will try to rephrase that in the next version of the patch. smolkit does not provide any helper tools like e.g. `pkexec` and also does not implement the whole featureset that polkit has. This might lead to issues if other recipes expect tools, libraries or other features polkit provides, but smolkit does not provide. Do you think it nevertheless makes sense to switch to a PROVIDES based approach here? I have checked that the build succeeds also with `PROVIDES` and `PREFERRED_PROVIDER_polkit = "smolkit"`, so it should not make a big difference, I am just worried regarding expectations from other recipes. I would send a patch v2 once it is decided which way to go.
> 
> 
> 
>> +PV = "0.2+git"
>> +
>> +SRC_URI = "\
>> + git://github.com/bmwcarit/${BPN}.git;protocol=https;branch=main \
>> +"
>> +SRCREV = "46bbfd5c922a8d03a534398ee129ded822dfcafe"
> 
> I notice a lack of tags upstream…

Tags are now present on the upstream repository.
> 
> 
>> +S = "${UNPACKDIR}/${BB_GIT_DEFAULT_DESTSUFFIX}"
> 
> You can drop this line.
> 
> Finally, I absolutely love the name.
> 
> Ross

I will drop the line in the next version and am happy that you like the name ;-)

Best regards,
Tillmann

[-- Attachment #2: Type: text/html, Size: 2271 bytes --]

      reply	other threads:[~2026-09-17  5:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 12:29 [meta-oe][PATCH] smolkit: Add low-footprint drop-in replacement for polkit Tillmann Severin
2026-09-15 13:29 ` [oe] " Ross Burton
2026-09-17  5:44   ` Severin Tillmann, DE-862 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546192.1789623871363509840@lists.openembedded.org \
    --to=tillmann.severin@bmw.de \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.