From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH 1/2] ASoC: tlv320aic3x: Add output driver pop reduction controls Date: Tue, 11 Nov 2014 10:01:44 +0200 Message-ID: <5461C268.10708@ti.com> References: <1415615253-28919-1-git-send-email-peter.ujfalusi@ti.com> <20141110105155.GL3815@sirena.org.uk> <5460BC38.9010707@ti.com> <20141110132725.GP3815@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by alsa0.perex.cz (Postfix) with ESMTP id C6C6C2614D6 for ; Tue, 11 Nov 2014 09:01:50 +0100 (CET) In-Reply-To: <20141110132725.GP3815@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Misael Lopez Cruz , Liam Girdwood , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 11/10/2014 03:27 PM, Mark Brown wrote: > On Mon, Nov 10, 2014 at 03:23:04PM +0200, Peter Ujfalusi wrote: >> On 11/10/2014 12:51 PM, Mark Brown wrote: > = >>>> + /* Pop reduction */ >>>> + SOC_ENUM("Output Driver Power-On time", aic3x_pop_reduction_enum[0]), >>>> + SOC_ENUM("Output Driver Ramp-up step", aic3x_pop_reduction_enum[1]), > = >>> Don't add arrays of enums with magic number indexes like this, it's hard >>> to read and hence error prone. > = >> I agree on this. I have not changed this since this driver is using enum= s like >> this and I thought it is better to follow the style. > = >> But if I add these to the aic3x_enum[] array with a define for the ID I = think >> it is going to be a bit better? > = > A bit, though I think I'd still prefer to use individual variables, it's > less to fix when someone does get round to fixing the driver. Sure, let's do that then. -- = P=E9ter