All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <balbi@ti.com>, Kiran Kumar Raparthy <kiran.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	"Todd Poynor" <toddpoynor@google.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org,
	"Android Kernel Team" <kernel-team@android.com>,
	"John Stultz" <john.stultz@linaro.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Arve Hj�nnev�g" <arve@android.com>,
	"Benoit Goby" <benoit@android.com>
Subject: Re: [RFC v5] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode
Date: Tue, 11 Nov 2014 14:29:38 +0530	[thread overview]
Message-ID: <5461CFFA.6030102@ti.com> (raw)
In-Reply-To: <20141110152645.GF20766@saruman>

Hi Felipe,

On Monday 10 November 2014 08:56 PM, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Nov 04, 2014 at 03:30:54PM +0530, Kiran Kumar Raparthy wrote:
>> @@ -1469,6 +1484,7 @@ static int ab8500_usb_probe(struct platform_device *pdev)
>>  
>>  	abx500_usb_link_status_update(ab);
>>  
>> +	usb_phy_wsource_init(&ab->phy);
> 
> instead of adding this to all drivers, you can just it to
> usb_add_phy_dev() and conversely, to usb_remove_phy().

'usb_phy_wsource_init' seems specific to usb and when these drivers are adapted
to the generic PHY framework we can't add it to phy_create.

Should it be added in extcon instead?

Thanks
Kishon

      parent reply	other threads:[~2014-11-11  8:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 10:00 [RFC v5] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode Kiran Kumar Raparthy
2014-11-05 19:40 ` Felipe Balbi
2014-11-06  4:34   ` Kiran Raparthy
2014-11-06  4:58     ` Felipe Balbi
2014-11-10 15:26 ` Felipe Balbi
2014-11-11  3:50   ` Kiran Raparthy
2014-11-11  8:59   ` Kishon Vijay Abraham I [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5461CFFA.6030102@ti.com \
    --to=kishon@ti.com \
    --cc=arve@android.com \
    --cc=balbi@ti.com \
    --cc=benoit@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=kiran.kumar@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.