All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ot1200: fix card detect for usdhc4
Date: Tue, 11 Nov 2014 14:56:09 +0100	[thread overview]
Message-ID: <54621579.5090608@denx.de> (raw)
In-Reply-To: <1415707025-20060-1-git-send-email-christian.gmeiner@gmail.com>

Hi Christian,

On 11/11/2014 12:57, Christian Gmeiner wrote:
> Today I got the final board and found out that a different
> connector is used as the one on my development board. The
> new connector has swaped pins for cd and wp.

It is always so..final board is different from development board ;-)

> 
> This change is tested on a production ready baord.

baord --> board

Maybe your disappointment in the commit message can be removed, and let
that the production board has swaped pins.

> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  board/bachmann/ot1200/ot1200.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
> index 2ed8cf7..007c1ef 100644
> --- a/board/bachmann/ot1200/ot1200.c
> +++ b/board/bachmann/ot1200/ot1200.c
> @@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
>  		gpio_direction_input(IMX_GPIO_NR(4, 5));
>  		ret = gpio_get_value(IMX_GPIO_NR(4, 5));
>  	} else {
> -		gpio_direction_input(IMX_GPIO_NR(1, 4));
> -		ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
> +		gpio_direction_input(IMX_GPIO_NR(1, 5));
> +		ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
>  	}
>  
>  	return ret;
> 

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-11-11 13:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 11:57 [U-Boot] [PATCH] ot1200: fix card detect for usdhc4 Christian Gmeiner
2014-11-11 13:56 ` Stefano Babic [this message]
2014-11-13 15:34 ` Stefano Babic
2014-11-17  7:41   ` Christian Gmeiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54621579.5090608@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.