From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zubair Lutfullah Kakakhel Subject: Re: [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode Date: Tue, 11 Nov 2014 14:36:39 +0000 Message-ID: <54621EF7.4000300@imgtec.com> References: <1415710229-11935-1-git-send-email-andy.yan@rock-chips.com> <1415710469-12213-1-git-send-email-andy.yan@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1415710469-12213-1-git-send-email-andy.yan@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Andy Yan , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , djkurtz@google.com, Philipp Zabel , ykk@rock-chips.com, Grant Likely , Dave Airlie , Shawn Guo , jay.xu@rock-chips.com, Lucas Stach List-Id: devicetree@vger.kernel.org Hi Andy, On 11/11/14 12:54, Andy Yan wrote: > From: Yakir Yang > > keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c Is there a reason for this separation? Keeping encoder in platform files? If yes, then the commit message should explain that. > > Signed-off-by: Andy Yan > Signed-off-by: Yakir Yang > > --- > > Changes in v7: None > Changes in v6: > - move some modification from patch#5 > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++++++++++++++------------------- > drivers/staging/imx-drm/dw_hdmi-imx.c | 145 ++++++++++++++------- > include/drm/bridge/dw_hdmi.h | 13 +- > 3 files changed, 199 insertions(+), 187 deletions(-) Regards ZubairLK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbaKKOgw (ORCPT ); Tue, 11 Nov 2014 09:36:52 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:5720 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbaKKOgu (ORCPT ); Tue, 11 Nov 2014 09:36:50 -0500 Message-ID: <54621EF7.4000300@imgtec.com> Date: Tue, 11 Nov 2014 14:36:39 +0000 From: Zubair Lutfullah Kakakhel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andy Yan , , , , CC: Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , , , , , , , , Subject: Re: [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode References: <1415710229-11935-1-git-send-email-andy.yan@rock-chips.com> <1415710469-12213-1-git-send-email-andy.yan@rock-chips.com> In-Reply-To: <1415710469-12213-1-git-send-email-andy.yan@rock-chips.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.89] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 11/11/14 12:54, Andy Yan wrote: > From: Yakir Yang > > keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c Is there a reason for this separation? Keeping encoder in platform files? If yes, then the commit message should explain that. > > Signed-off-by: Andy Yan > Signed-off-by: Yakir Yang > > --- > > Changes in v7: None > Changes in v6: > - move some modification from patch#5 > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++++++++++++++------------------- > drivers/staging/imx-drm/dw_hdmi-imx.c | 145 ++++++++++++++------- > include/drm/bridge/dw_hdmi.h | 13 +- > 3 files changed, 199 insertions(+), 187 deletions(-) Regards ZubairLK