From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zubair Lutfullah Kakakhel Subject: Re: [PATCH v7 7/7] dt-bindings: add document for dw-hdmi Date: Tue, 11 Nov 2014 14:40:11 +0000 Message-ID: <54621FCB.1050208@imgtec.com> References: <1415710229-11935-1-git-send-email-andy.yan@rock-chips.com> <1415710486-12263-1-git-send-email-andy.yan@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1415710486-12263-1-git-send-email-andy.yan@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Andy Yan , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , djkurtz@google.com, Philipp Zabel , ykk@rock-chips.com, Grant Likely , Dave Airlie , Shawn Guo , jay.xu@rock-chips.com, Lucas Stach List-Id: devicetree@vger.kernel.org Hi Andy, Some minor comments inline. On 11/11/14 12:54, Andy Yan wrote: > Signed-off-by: Andy Yan > --- > > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt > > diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt > new file mode 100644 > index 0000000..aa7ed17 > --- /dev/null > +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt > @@ -0,0 +1,38 @@ > +DesignWare HDMI bridge bindings > + > +Required properities: ^properties > +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi" ^compatible > + "rockchip,rk3288-dw-hdmi" This will need to come in a separate series which adds rk3288 hdmi support.. > +- reg: physical base address of the controller and length > +- ddc-i2c-bus: the ddc i2c bus > +- interrupts: The interrupt number to the cpu > + > +Optional properties > +- reg-io-width: the width of the reg:1,4, default set to 1 if not present > + > +Example: > + hdmi: hdmi@0120000 { > + compatible = "fsl,imx6q-hdmi"; > + reg = <0x00120000 0x9000>; > + interrupts = <0 115 0x04>; > + gpr = <&gpr>; > + clocks = <&clks 123>, <&clks 124>; > + clock-names = "iahb", "isfr"; > + ddc-i2c-bus = <&i2c2>; > + > + port@0 { > + reg = <0>; > + > + hdmi_mux_0: endpoint { > + remote-endpoint = <&ipu1_di0_hdmi>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + hdmi_mux_1: endpoint { > + remote-endpoint = <&ipu1_di1_hdmi>; > + }; > + }; > + }; > Thanks ZubairLK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751771AbaKKOkY (ORCPT ); Tue, 11 Nov 2014 09:40:24 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:17390 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbaKKOkW (ORCPT ); Tue, 11 Nov 2014 09:40:22 -0500 Message-ID: <54621FCB.1050208@imgtec.com> Date: Tue, 11 Nov 2014 14:40:11 +0000 From: Zubair Lutfullah Kakakhel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andy Yan , , , , CC: Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , , , , , , , , Subject: Re: [PATCH v7 7/7] dt-bindings: add document for dw-hdmi References: <1415710229-11935-1-git-send-email-andy.yan@rock-chips.com> <1415710486-12263-1-git-send-email-andy.yan@rock-chips.com> In-Reply-To: <1415710486-12263-1-git-send-email-andy.yan@rock-chips.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.89] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, Some minor comments inline. On 11/11/14 12:54, Andy Yan wrote: > Signed-off-by: Andy Yan > --- > > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt > > diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt > new file mode 100644 > index 0000000..aa7ed17 > --- /dev/null > +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt > @@ -0,0 +1,38 @@ > +DesignWare HDMI bridge bindings > + > +Required properities: ^properties > +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi" ^compatible > + "rockchip,rk3288-dw-hdmi" This will need to come in a separate series which adds rk3288 hdmi support.. > +- reg: physical base address of the controller and length > +- ddc-i2c-bus: the ddc i2c bus > +- interrupts: The interrupt number to the cpu > + > +Optional properties > +- reg-io-width: the width of the reg:1,4, default set to 1 if not present > + > +Example: > + hdmi: hdmi@0120000 { > + compatible = "fsl,imx6q-hdmi"; > + reg = <0x00120000 0x9000>; > + interrupts = <0 115 0x04>; > + gpr = <&gpr>; > + clocks = <&clks 123>, <&clks 124>; > + clock-names = "iahb", "isfr"; > + ddc-i2c-bus = <&i2c2>; > + > + port@0 { > + reg = <0>; > + > + hdmi_mux_0: endpoint { > + remote-endpoint = <&ipu1_di0_hdmi>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + hdmi_mux_1: endpoint { > + remote-endpoint = <&ipu1_di1_hdmi>; > + }; > + }; > + }; > Thanks ZubairLK