From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode Date: Tue, 11 Nov 2014 22:50:46 +0800 Message-ID: <54622246.9080302@rock-chips.com> References: <1415710229-11935-1-git-send-email-andy.yan@rock-chips.com> <1415710469-12213-1-git-send-email-andy.yan@rock-chips.com> <54621EF7.4000300@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <54621EF7.4000300@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Dave Airlie , Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , Philipp Zabel , ykk@rock-chips.com, Grant Likely , djkurtz@google.com, Shawn Guo , jay.xu@rock-chips.com, Lucas Stach List-Id: devicetree@vger.kernel.org SGkgWnViYWlyTEs6Ck9uIDIwMTTlubQxMeaciDEx5pelIDIyOjM2LCBadWJhaXIgTHV0ZnVsbGFo IEtha2FraGVsIHdyb3RlOgo+IEhpIEFuZHksCj4KPiBPbiAxMS8xMS8xNCAxMjo1NCwgQW5keSBZ YW4gd3JvdGU6Cj4+IEZyb206IFlha2lyIFlhbmcgPHlra0Byb2NrLWNoaXBzLmNvbT4KPj4KPj4g a2VlcCB0aGUgY29ubmVjdG9yICYgYmlyZGdlIGluIGR3X2hkbWkuYywgaGFuZGxlIGVuY29kZXIg aW4gZHdfaGRtaS1pbXguYwo+IElzIHRoZXJlIGEgcmVhc29uIGZvciB0aGlzIHNlcGFyYXRpb24/ IEtlZXBpbmcgZW5jb2RlciBpbiBwbGF0Zm9ybSBmaWxlcz8KPiBJZiB5ZXMsIHRoZW4gdGhlIGNv bW1pdCBtZXNzYWdlIHNob3VsZCBleHBsYWluIHRoYXQuCiAgICBpbiB0aGUgZW5jb2RlciwgbW9z dCBvcGVyYXRpb24gYXJlIHBsYXRmb3JtIHNwZWNpZmljLCBzdWNoIGFzCiAgIG11eCB0byBzZWxl Y3Qgd2hpY2ggY3J0YyBpcyB1c2VkLCAgc2V0IHBhbmVsIGZvcm1hdCBldGMsIHRoZXNlIG9wZXJh dGlvbgogICBjb21wbGV0ZSBieSBwbGF0Zm9ybSBzcGVjaWZpYyBpbnRlcmZhY2UKPj4gU2lnbmVk LW9mZi1ieTogQW5keSBZYW4gPGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgo+PiBTaWduZWQtb2Zm LWJ5OiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+Cj4+Cj4+IC0tLQo+Pgo+PiBDaGFu Z2VzIGluIHY3OiBOb25lCj4+IENoYW5nZXMgaW4gdjY6Cj4+IC0gbW92ZSBzb21lIG1vZGlmaWNh dGlvbiBmcm9tIHBhdGNoIzUKPj4KPj4gQ2hhbmdlcyBpbiB2NTogTm9uZQo+PiBDaGFuZ2VzIGlu IHY0OiBOb25lCj4+IENoYW5nZXMgaW4gdjM6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2MjogTm9uZQo+ Pgo+PiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jICAgICAgfCAyMjggKysrKysr KysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAgIGRyaXZlcnMvc3RhZ2luZy9pbXgtZHJt L2R3X2hkbWktaW14LmMgfCAxNDUgKysrKysrKysrKysrKystLS0tLS0tCj4+ICAgaW5jbHVkZS9k cm0vYnJpZGdlL2R3X2hkbWkuaCAgICAgICAgICB8ICAxMyArLQo+PiAgIDMgZmlsZXMgY2hhbmdl ZCwgMTk5IGluc2VydGlvbnMoKyksIDE4NyBkZWxldGlvbnMoLSkKPgo+IFJlZ2FyZHMKPiBadWJh aXJMSwo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKPiBMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1yb2NrY2hpcAo+Cj4KPgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qu b3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbaKKOy6 (ORCPT ); Tue, 11 Nov 2014 09:54:58 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:52930 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbaKKOuv (ORCPT ); Tue, 11 Nov 2014 09:50:51 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <6f96c344e5ea8173a711bff3d4a63f93> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54622246.9080302@rock-chips.com> Date: Tue, 11 Nov 2014 22:50:46 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , djkurtz@google.com, Philipp Zabel , ykk@rock-chips.com, Grant Likely , Dave Airlie , Shawn Guo , jay.xu@rock-chips.com, Lucas Stach Subject: Re: [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode References: <1415710229-11935-1-git-send-email-andy.yan@rock-chips.com> <1415710469-12213-1-git-send-email-andy.yan@rock-chips.com> <54621EF7.4000300@imgtec.com> In-Reply-To: <54621EF7.4000300@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ZubairLK: On 2014年11月11日 22:36, Zubair Lutfullah Kakakhel wrote: > Hi Andy, > > On 11/11/14 12:54, Andy Yan wrote: >> From: Yakir Yang >> >> keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c > Is there a reason for this separation? Keeping encoder in platform files? > If yes, then the commit message should explain that. in the encoder, most operation are platform specific, such as mux to select which crtc is used, set panel format etc, these operation complete by platform specific interface >> Signed-off-by: Andy Yan >> Signed-off-by: Yakir Yang >> >> --- >> >> Changes in v7: None >> Changes in v6: >> - move some modification from patch#5 >> >> Changes in v5: None >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++++++++++++++------------------- >> drivers/staging/imx-drm/dw_hdmi-imx.c | 145 ++++++++++++++------- >> include/drm/bridge/dw_hdmi.h | 13 +- >> 3 files changed, 199 insertions(+), 187 deletions(-) > > Regards > ZubairLK > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >