From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v7 7/7] dt-bindings: add document for dw-hdmi Date: Tue, 11 Nov 2014 22:53:18 +0800 Message-ID: <546222DE.4020803@rock-chips.com> References: <1415710229-11935-1-git-send-email-andy.yan@rock-chips.com> <1415710486-12263-1-git-send-email-andy.yan@rock-chips.com> <54621FCB.1050208@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <54621FCB.1050208@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Dave Airlie , Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , Philipp Zabel , ykk@rock-chips.com, Grant Likely , djkurtz@google.com, Shawn Guo , jay.xu@rock-chips.com, Lucas Stach List-Id: devicetree@vger.kernel.org Ck9uIDIwMTTlubQxMeaciDEx5pelIDIyOjQwLCBadWJhaXIgTHV0ZnVsbGFoIEtha2FraGVsIHdy b3RlOgo+IEhpIEFuZHksCj4KPiBTb21lIG1pbm9yIGNvbW1lbnRzIGlubGluZS4KPgo+IE9uIDEx LzExLzE0IDEyOjU0LCBBbmR5IFlhbiB3cm90ZToKPj4gU2lnbmVkLW9mZi1ieTogQW5keSBZYW4g PGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgo+PiAtLS0KPj4KPj4gQ2hhbmdlcyBpbiB2NzogTm9u ZQo+PiBDaGFuZ2VzIGluIHY2OiBOb25lCj4+IENoYW5nZXMgaW4gdjU6IE5vbmUKPj4gQ2hhbmdl cyBpbiB2NDogTm9uZQo+PiBDaGFuZ2VzIGluIHYzOiBOb25lCj4+IENoYW5nZXMgaW4gdjI6IE5v bmUKPj4KPj4gICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3LWhkbWkudHh0 ICAgICB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysKPj4gICAxIGZpbGUgY2hhbmdlZCwgMzgg aW5zZXJ0aW9ucygrKQo+PiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kdy1oZG1pLnR4dAo+Pgo+PiBkaWZmIC0tZ2l0IGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RybS9icmlkZ2UvZHctaGRtaS50eHQg Yi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kdy1oZG1pLnR4 dAo+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+PiBpbmRleCAwMDAwMDAwLi5hYTdlZDE3Cj4+IC0t LSAvZGV2L251bGwKPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Ry bS9icmlkZ2UvZHctaGRtaS50eHQKPj4gQEAgLTAsMCArMSwzOCBAQAo+PiArRGVzaWduV2FyZSBI RE1JIGJyaWRnZSBiaW5kaW5ncwo+PiArCj4+ICtSZXF1aXJlZCBwcm9wZXJpdGllczoKPiAJCj4g CSAgICBecHJvcGVydGllcwo+Cj4+ICstIGNvbXBhdGliZWw6IHBsYXRmb3JtIHNwZWNpZmljIHN1 Y2ggYXMgImZzbCxpbXg2cS1oZG1pIiwiZnNsLGlteDZkbC1oZG1pIgo+ICAgICAgIF5jb21wYXRp YmxlCiAgIHRoYW5rcyAsIHRoZXNlIHdpbGwgYmUgZml4ZWQgbmV4dC4KPj4gKwkgICAgICAicm9j a2NoaXAscmszMjg4LWR3LWhkbWkiCj4gVGhpcyB3aWxsIG5lZWQgdG8gY29tZSBpbiBhIHNlcGFy YXRlIHNlcmllcyB3aGljaCBhZGRzIHJrMzI4OCBoZG1pIHN1cHBvcnQuLgogIHdlIHdpbGwgYWRk IHJrMzI4OCBoZG1pIHBsYXRmb3JtIGNvZGUgc29vbgo+Cj4+ICstIHJlZzogcGh5c2ljYWwgYmFz ZSBhZGRyZXNzIG9mIHRoZSBjb250cm9sbGVyIGFuZCBsZW5ndGgKPj4gKy0gZGRjLWkyYy1idXM6 IHRoZSBkZGMgaTJjIGJ1cwo+PiArLSBpbnRlcnJ1cHRzOiBUaGUgaW50ZXJydXB0IG51bWJlciB0 byB0aGUgY3B1Cj4+ICsKPj4gK09wdGlvbmFsIHByb3BlcnRpZXMKPj4gKy0gcmVnLWlvLXdpZHRo OiB0aGUgd2lkdGggb2YgdGhlIHJlZzoxLDQsIGRlZmF1bHQgc2V0IHRvIDEgaWYgbm90IHByZXNl bnQKPj4gKwo+PiArRXhhbXBsZToKPj4gKwloZG1pOiBoZG1pQDAxMjAwMDAgewo+PiArCQljb21w YXRpYmxlID0gImZzbCxpbXg2cS1oZG1pIjsKPj4gKwkJcmVnID0gPDB4MDAxMjAwMDAgMHg5MDAw PjsKPj4gKwkJaW50ZXJydXB0cyA9IDwwIDExNSAweDA0PjsKPj4gKwkJZ3ByID0gPCZncHI+Owo+ PiArCQljbG9ja3MgPSA8JmNsa3MgMTIzPiwgPCZjbGtzIDEyND47Cj4+ICsJCWNsb2NrLW5hbWVz ID0gImlhaGIiLCAiaXNmciI7Cj4+ICsJCWRkYy1pMmMtYnVzID0gPCZpMmMyPjsKPj4gKwo+PiAr CQlwb3J0QDAgewo+PiArCQkJcmVnID0gPDA+Owo+PiArCj4+ICsJCQloZG1pX211eF8wOiBlbmRw b2ludCB7Cj4+ICsJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZpcHUxX2RpMF9oZG1pPjsKPj4gKwkJ CX07Cj4+ICsJCX07Cj4+ICsKPj4gKwkJcG9ydEAxIHsKPj4gKwkJCXJlZyA9IDwxPjsKPj4gKwo+ PiArCQkJaGRtaV9tdXhfMTogZW5kcG9pbnQgewo+PiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwm aXB1MV9kaTFfaGRtaT47Cj4+ICsJCQl9Owo+PiArCQl9Owo+PiArCX07Cj4+Cj4gVGhhbmtzCj4g WnViYWlyTEsKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0Cj4gTGludXgtcm9ja2NoaXBAbGlzdHMu aW5mcmFkZWFkLm9yZwo+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcm9ja2NoaXAKPgo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9q ZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbaKKOxd (ORCPT ); Tue, 11 Nov 2014 09:53:33 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:52301 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbaKKOx2 (ORCPT ); Tue, 11 Nov 2014 09:53:28 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <6e09401bf04e072f862317b3752edfd4> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <546222DE.4020803@rock-chips.com> Date: Tue, 11 Nov 2014 22:53:18 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Arnd Bergmann , Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , linux-rockchip@lists.infradead.org, Rob Herring , Sean Paul , djkurtz@google.com, Philipp Zabel , ykk@rock-chips.com, Grant Likely , Dave Airlie , Shawn Guo , jay.xu@rock-chips.com, Lucas Stach Subject: Re: [PATCH v7 7/7] dt-bindings: add document for dw-hdmi References: <1415710229-11935-1-git-send-email-andy.yan@rock-chips.com> <1415710486-12263-1-git-send-email-andy.yan@rock-chips.com> <54621FCB.1050208@imgtec.com> In-Reply-To: <54621FCB.1050208@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年11月11日 22:40, Zubair Lutfullah Kakakhel wrote: > Hi Andy, > > Some minor comments inline. > > On 11/11/14 12:54, Andy Yan wrote: >> Signed-off-by: Andy Yan >> --- >> >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >> >> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >> new file mode 100644 >> index 0000000..aa7ed17 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >> @@ -0,0 +1,38 @@ >> +DesignWare HDMI bridge bindings >> + >> +Required properities: > > ^properties > >> +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi" > ^compatible thanks , these will be fixed next. >> + "rockchip,rk3288-dw-hdmi" > This will need to come in a separate series which adds rk3288 hdmi support.. we will add rk3288 hdmi platform code soon > >> +- reg: physical base address of the controller and length >> +- ddc-i2c-bus: the ddc i2c bus >> +- interrupts: The interrupt number to the cpu >> + >> +Optional properties >> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present >> + >> +Example: >> + hdmi: hdmi@0120000 { >> + compatible = "fsl,imx6q-hdmi"; >> + reg = <0x00120000 0x9000>; >> + interrupts = <0 115 0x04>; >> + gpr = <&gpr>; >> + clocks = <&clks 123>, <&clks 124>; >> + clock-names = "iahb", "isfr"; >> + ddc-i2c-bus = <&i2c2>; >> + >> + port@0 { >> + reg = <0>; >> + >> + hdmi_mux_0: endpoint { >> + remote-endpoint = <&ipu1_di0_hdmi>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + hdmi_mux_1: endpoint { >> + remote-endpoint = <&ipu1_di1_hdmi>; >> + }; >> + }; >> + }; >> > Thanks > ZubairLK > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >