Re: [PATCH 11/11] ufs: remove spurious scsi_set_tag_type call

[Hannes Reinecke <hare@suse.de>]

On 11/10/2014 04:56 PM, Christoph Hellwig wrote:
> ufs never looks at the tag type, so there is no need to set it either.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/scsi/ufs/ufshcd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 67e2280..362b818 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -2768,7 +2768,6 @@ static int ufshcd_slave_alloc(struct scsi_device *sdev)
>  
>  	/* Mode sense(6) is not supported by UFS, so use Mode sense(10) */
>  	sdev->use_10_for_ms = 1;
> -	scsi_set_tag_type(sdev, MSG_SIMPLE_TAG);
>  
>  	/* allow SCSI layer to restart the device in case of errors */
>  	sdev->allow_restart = 1;
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html