From: Florian Fainelli <f.fainelli@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/3] net: phy: add module_phy_driver macro
Date: Tue, 11 Nov 2014 11:14:29 -0800 [thread overview]
Message-ID: <54626015.3030907@gmail.com> (raw)
In-Reply-To: <1415731559-10015-1-git-send-email-johan@kernel.org>
On 11/11/2014 10:45 AM, Johan Hovold wrote:
> Add module_phy_driver macro that can be used by PHY drivers that only
> calls phy_driver_register or phy_drivers_register (and the corresponding
> unregister functions) in their module init (and exit).
>
> This allows us to eliminate a lot of boilerplate code.
>
> Split in three patches (actual macro and two driver change classes) in
> order to facilitate review.
Looks good to me:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
>
> Johan
>
>
> Johan Hovold (3):
> net: phy: add module_phy_driver macro
> net: phy: replace phy_driver_register calls
> net: phy: replace phy_drivers_register calls
>
> drivers/net/phy/amd-xgbe-phy.c | 15 +--------------
> drivers/net/phy/amd.c | 17 +++--------------
> drivers/net/phy/at803x.c | 14 +-------------
> drivers/net/phy/bcm63xx.c | 15 +--------------
> drivers/net/phy/bcm7xxx.c | 15 +--------------
> drivers/net/phy/bcm87xx.c | 14 +-------------
> drivers/net/phy/broadcom.c | 15 +--------------
> drivers/net/phy/cicada.c | 15 +--------------
> drivers/net/phy/davicom.c | 15 +--------------
> drivers/net/phy/et1011c.c | 17 +++--------------
> drivers/net/phy/icplus.c | 15 +--------------
> drivers/net/phy/lxt.c | 15 +--------------
> drivers/net/phy/marvell.c | 15 +--------------
> drivers/net/phy/micrel.c | 15 +--------------
> drivers/net/phy/national.c | 17 +++--------------
> drivers/net/phy/qsemi.c | 17 +++--------------
> drivers/net/phy/realtek.c | 13 +------------
> drivers/net/phy/smsc.c | 14 +-------------
> drivers/net/phy/ste10Xp.c | 15 +--------------
> drivers/net/phy/vitesse.c | 14 +-------------
> include/linux/phy.h | 24 ++++++++++++++++++++++++
> 21 files changed, 52 insertions(+), 274 deletions(-)
>
next prev parent reply other threads:[~2014-11-11 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 18:45 [PATCH 0/3] net: phy: add module_phy_driver macro Johan Hovold
2014-11-11 18:45 ` [PATCH 1/3] " Johan Hovold
2014-11-11 18:45 ` [PATCH 2/3] net: phy: replace phy_driver_register calls Johan Hovold
2014-11-11 18:45 ` [PATCH 3/3] net: phy: replace phy_drivers_register calls Johan Hovold
2014-11-11 19:14 ` Florian Fainelli [this message]
2014-11-12 18:53 ` [PATCH 0/3] net: phy: add module_phy_driver macro David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54626015.3030907@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.