Re: [PATCH v5 1/2] i2c: Add Imagination Technologies I2C SCB driver

[Ezequiel Garcia <ezequiel.garcia-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>]

On 11/10/2014 04:30 PM, Ezequiel Garcia wrote:
[..]
> +static int img_i2c_init(struct img_i2c *i2c)
> +{
> +	unsigned int clk_khz, bitrate_khz, clk_period, tckh, tckl, tsdh;
> +	unsigned int i, ret, data, prescale, inc, int_bitrate;
> +	unsigned int filt, filt_disable, filt_bypass;
> +	struct img_i2c_timings timing;
> +	u32 rev;
> +
> +	ret = clk_prepare_enable(i2c->scb_clk);
> +	if (ret)
> +		return ret;
> +
> +	rev = img_i2c_readl(i2c, SCB_CORE_REV_REG);
> +	if ((rev & 0x00ffffff) < 0x00020200) {
> +		dev_info(i2c->adap.dev.parent,
> +			 "Unknown hardware revision (%d.%d.%d.%d)\n",
> +			 (rev >> 24) & 0xff, (rev >> 16) & 0xff,
> +			 (rev >> 8) & 0xff, rev & 0xff);
> +		clk_disable_unprepare(i2c->scb_clk);
> +		return -EINVAL;
> +	}
> +
> +	if (rev == REL_SOC_IP_SCB_2_2_1)
> +		i2c->need_wr_rd_fence = true;
> +

Maybe we can add a dev_info here:

dev_info(i2c->adap.dev.parent, "fence quirk enabled");

-- 
Ezequiel