From: Joshua Kinard <kumba@gentoo.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Linux MIPS List <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: R14000: Add missing CPU_R14000 reference in cpu_needs_post_dma_flush()
Date: Wed, 12 Nov 2014 00:41:42 -0500 [thread overview]
Message-ID: <5462F316.3010004@gentoo.org> (raw)
In-Reply-To: <20141111212253.GA11943@linux-mips.org>
On 11/11/2014 16:22, Ralf Baechle wrote:
> On Tue, Oct 07, 2014 at 09:17:45PM -0400, Joshua Kinard wrote:
>
>> cpu_needs_post_dma_flush() in arch/mips/mm/dma-default.c is missing a check for
>> CPU_R14000, where it already has checks for CPU_R10000 and CPU_R12000. This
>> patch adds the missing CPU_R14000 check.
>
> Patch is entirely correct. Except.
>
> This is only used on systems which don't have DMA cache coherency. Those
> systems are the IP28 and IP22 which featured an R10000 rsp. R10000 or
> R12000 processor which is why the R14000 is intentionally not listed in
> this if(). Saves a few bytes and cycles. And probably deserves a
> comment in the code!
>
> Ralf
A comment in the code sounds great in that case then! I'll drop this locally,
then. Thanks!
--
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org
4096R/D25D95E3 2011-03-28
"The past tempts us, the present confuses us, the future frightens us. And our
lives slip away, moment by moment, lost in that vast, terrible in-between."
--Emperor Turhan, Centauri Republic
prev parent reply other threads:[~2014-11-12 5:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 1:17 [PATCH] MIPS: R14000: Add missing CPU_R14000 reference in cpu_needs_post_dma_flush() Joshua Kinard
2014-11-11 21:22 ` Ralf Baechle
2014-11-12 5:41 ` Joshua Kinard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5462F316.3010004@gentoo.org \
--to=kumba@gentoo.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.