From: Richard Henderson <rth@twiddle.net>
To: Dmitry Poletaev <poletaev-qemu@yandex.ru>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign
Date: Wed, 12 Nov 2014 08:43:57 +0100 [thread overview]
Message-ID: <54630FBD.3010002@twiddle.net> (raw)
In-Reply-To: <206531415709219@web10m.yandex.ru>
On 11/11/2014 01:33 PM, Dmitry Poletaev wrote:
> ping
>
> 25.07.2014, 15:48, "Dmitry Poletaev" <poletaev-qemu@yandex.ru>:
>> Obviously, there is a misprint in function implementation.
>>
>> From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>> Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>>
>> ---
>> target-i386/fpu_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
>> index 1b2900d..be1e545 100644
>> --- a/target-i386/fpu_helper.c
>> +++ b/target-i386/fpu_helper.c
>> @@ -622,7 +622,7 @@ void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
>> }
>> tmp = int64_to_floatx80(val, &env->fp_status);
>> if (cpu_ldub_data(env, ptr + 9) & 0x80) {
>> - floatx80_chs(tmp);
>> + tmp = floatx80_chs(tmp);
>> }
>> fpush(env);
>> ST0 = tmp;
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2014-11-12 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 10:48 [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign Dmitry Poletaev
2014-11-11 12:33 ` Dmitry Poletaev
2014-11-12 7:43 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54630FBD.3010002@twiddle.net \
--to=rth@twiddle.net \
--cc=poletaev-qemu@yandex.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.