From: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
linux-mips@linux-mips.org, "Ralf Baechle" <ralf@linux-mips.org>
Cc: Hauke Mehrtens <hauke@hauke-m.de>, Arnd Bergmann <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] MIPS: BCM47XX: Move NVRAM driver to the drivers/misc/
Date: Wed, 12 Nov 2014 09:34:41 +0000 [thread overview]
Message-ID: <546329B1.5060406@imgtec.com> (raw)
In-Reply-To: <1415735146-31552-1-git-send-email-zajec5@gmail.com>
Hi,
On 11/11/14 19:45, Rafał Miłecki wrote:
> After Broadcom switched from MIPS to ARM for their home routers we need
> to have NVRAM driver in some common place (not arch/mips/).
> We were thinking about putting it in bus directory, however there are
> two possible buses for MIPS: drivers/ssb/ and drivers/bcma/. So this
> won't fit there neither.
> This is why I would like to move this driver to the drivers/misc/
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> arch/mips/Kconfig | 1 +
> arch/mips/bcm47xx/Makefile | 2 +-
> arch/mips/bcm47xx/board.c | 2 +-
> arch/mips/bcm47xx/nvram.c | 228 --------------------
> arch/mips/bcm47xx/setup.c | 1 -
> arch/mips/bcm47xx/sprom.c | 1 -
> arch/mips/bcm47xx/time.c | 1 -
> arch/mips/include/asm/mach-bcm47xx/bcm47xx.h | 1 +
> arch/mips/include/asm/mach-bcm47xx/bcm47xx_nvram.h | 21 --
> drivers/bcma/driver_mips.c | 2 +-
> drivers/misc/Kconfig | 9 +
> drivers/misc/Makefile | 1 +
> drivers/misc/bcm47xx_nvram.c | 230 +++++++++++++++++++++
> drivers/net/ethernet/broadcom/b44.c | 2 +-
> drivers/net/ethernet/broadcom/bgmac.c | 2 +-
> drivers/ssb/driver_chipcommon_pmu.c | 2 +-
> drivers/ssb/driver_mipscore.c | 2 +-
> include/linux/bcm47xx_nvram.h | 18 ++
> 18 files changed, 267 insertions(+), 259 deletions(-)
> delete mode 100644 arch/mips/bcm47xx/nvram.c
> delete mode 100644 arch/mips/include/asm/mach-bcm47xx/bcm47xx_nvram.h
> create mode 100644 drivers/misc/bcm47xx_nvram.c
> create mode 100644 include/linux/bcm47xx_nvram.h
Using git format-patch -M should generate a review-able patch.
Especially for nvram.c
Regards
ZubairLK
next prev parent reply other threads:[~2014-11-12 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 19:45 [PATCH] MIPS: BCM47XX: Move NVRAM driver to the drivers/misc/ Rafał Miłecki
2014-11-12 9:34 ` Zubair Lutfullah Kakakhel [this message]
2014-11-12 9:43 ` Arnd Bergmann
2014-11-12 21:09 ` Hauke Mehrtens
2014-11-12 21:16 ` Hauke Mehrtens
2014-11-23 9:45 ` Rafał Miłecki
2014-11-23 11:22 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546329B1.5060406@imgtec.com \
--to=zubair.kakakhel@imgtec.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.