Re: [PATCH] Adjust number of domains in cpupools when destroying domain

[Juergen Gross <jgross@suse.com>]

On 11/12/2014 12:10 PM, George Dunlap wrote:
> On Wed, Nov 12, 2014 at 10:40 AM, Juergen Gross <jgross@suse.com> wrote:
>> Commit bac6334b51d9bcfe57ecf4a4cb5288348fcf044a (move domain to
>> cpupool0 before destroying it) introduced an error in the accounting
>> of cpupools regarding the number of domains. The number of domains
>> is nor adjusted when a domain is moved to cpupool0 in kill_domain().
>>
>> Correct this by introducing a cpupool function doing the move
>> instead of open coding it by calling sched_move_domain().
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Tested-by: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
>
> Juergen / Dietmar -- do either of you have a reasonably complete set
> of tests for cpupools?  It seems like even basic corner cases (like
> shutting down a domain in a pool and then destroying a pool) aren't
> being tested.
>
> It would be really good if someone could try to do a more thorough
> test before the 4.5 release.  It shouldn't be too hard to write a
> script to test a lot of this functionality programmatically.

For the xm toolstack we had some tests at Fujitsu. Dietmar, you could
ask Lutz for advice. He might still have the scripts somewhere. They
should be easily adaptable to xl. In case you don't have time to try
them would you send them to me?

Juergen