From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>,
John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com
Subject: Re: [PATCH 1/6] ath9k: disable overriding AR9340 SLP32 registers
Date: Wed, 12 Nov 2014 12:26:39 +0100 [thread overview]
Message-ID: <546343EF.5090803@openwrt.org> (raw)
In-Reply-To: <1415689644-29693-2-git-send-email-sujith@msujith.org>
On 2014-11-11 08:07, Sujith Manoharan wrote:
> From: Miaoqing Pan <miaoqing@qca.qualcomm.com>
>
> For AR9340, the correct values for SLP32 registers are present
> in the initvals, so overriding them is not needed.
>
> Signed-off-by: Miaoqing Pan <miaoqing@qca.qualcomm.com>
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
What's the point in doing this? The writes don't hurt, and this change
is making the code uglier.
- Felix
next prev parent reply other threads:[~2014-11-12 11:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 7:07 [PATCH 0/6] ath9k patches Sujith Manoharan
2014-11-11 7:07 ` [PATCH 1/6] ath9k: disable overriding AR9340 SLP32 registers Sujith Manoharan
2014-11-12 11:26 ` Felix Fietkau [this message]
2014-11-13 0:05 ` Sujith Manoharan
2014-11-14 6:02 ` Sujith Manoharan
2014-11-11 7:07 ` [PATCH 2/6] ath9k: Update QCA953x initvals Sujith Manoharan
2014-11-11 7:07 ` [PATCH 3/6] ath9k: Use new " Sujith Manoharan
2014-11-11 7:07 ` [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode Sujith Manoharan
2014-11-11 14:23 ` Felix Fietkau
2014-11-11 23:38 ` Sujith Manoharan
2014-11-12 1:54 ` Pan, Miaoqing
2014-11-12 3:34 ` Sujith Manoharan
2014-11-12 8:48 ` Felix Fietkau
2014-11-13 0:00 ` Sujith Manoharan
2014-11-11 7:07 ` [PATCH 5/6] ath9k: Fix LED configuration Sujith Manoharan
2014-11-11 7:07 ` [PATCH 6/6] ath9k: Enable TSF2 for generic HW timers Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546343EF.5090803@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.