All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH] ALSA: firewire-lib: add missing description for kerneldoc
Date: Thu, 13 Nov 2014 01:11:57 +0900	[thread overview]
Message-ID: <546386CD.9090306@sakamocchi.jp> (raw)
In-Reply-To: <s5h1tp8mseb.wl-tiwai@suse.de>

HI,

On Nov 12 2014 22:59, Takashi Iwai wrote:
> Could you fix these as well?
> (amdtp.h enum errors look stupid, though...)

OK.

> Warning(amdtp.h:44): Enum value 'CIP_SKIP_DBC_ZERO_CHECK' not described in enum 'cip_flags'

This is due to my typo.

> Warning(amdtp.h:58): Enum value 'CIP_SFC_32000' not described in enum 'cip_sfc'
> Warning(amdtp.h:58): Enum value 'CIP_SFC_44100' not described in enum 'cip_sfc'
> Warning(amdtp.h:58): Enum value 'CIP_SFC_48000' not described in enum 'cip_sfc'
> Warning(amdtp.h:58): Enum value 'CIP_SFC_88200' not described in enum 'cip_sfc'
> Warning(amdtp.h:58): Enum value 'CIP_SFC_96000' not described in enum 'cip_sfc'
> Warning(amdtp.h:58): Enum value 'CIP_SFC_176400' not described in enum 'cip_sfc'
> Warning(amdtp.h:58): Enum value 'CIP_SFC_192000' not described in enum 'cip_sfc'
> Warning(amdtp.h:58): Enum value 'CIP_SFC_COUNT' not described in enum 'cip_sfc'

A lack of descriptions.
I think it good to refer to IEC 61883-1 in these description.


Regards

Takashi Sakamoto
o-takashi@sakamocchi.jp

      reply	other threads:[~2014-11-12 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 13:55 [PATCH] ALSA: firewire-lib: add missing description for kerneldoc Takashi Sakamoto
2014-11-12 13:59 ` Takashi Iwai
2014-11-12 16:11   ` Takashi Sakamoto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546386CD.9090306@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.