From: joel.schopp@amd.com (Joel Schopp)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: efi: Fix stub cache maintenance
Date: Wed, 12 Nov 2014 11:12:32 -0600 [thread overview]
Message-ID: <54639500.5010309@amd.com> (raw)
In-Reply-To: <1415810351-3462-1-git-send-email-mark.rutland@arm.com>
>
> + /*
> + * Ensure that the rest of this function (in the original Image) is
> + * visible when the caches are disabled. The I-cache can't have stale
> + * entries for the VA range of the current image, so no maintenance is
> + * necessary.
> + */
> + adr x0, efi_stub_entry
> + adr x1, efi_stub_entry_end
> + sub x1, x1, x0
> + bl __flush_dcache_area
It is my understdanding that you also need an isb here. Tom's testing
confirms this on my patch with the dsb and without the isb.
Also, since this is not a performance critical path it seems more
straightforward to just flush everything. I'm happy either way. We
will test your patch as is and let you know.
next prev parent reply other threads:[~2014-11-12 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 16:39 [PATCH] arm64: efi: Fix stub cache maintenance Mark Rutland
2014-11-12 16:44 ` Roy Franz
2014-11-12 17:12 ` Joel Schopp [this message]
2014-11-12 17:41 ` Mark Rutland
2014-11-12 18:14 ` Joel Schopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54639500.5010309@amd.com \
--to=joel.schopp@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.