From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhigang Wang <zhigang.x.wang@oracle.com>
Subject: Re: [PATCH for-4.5 0/2] xl/libxl: return and print
 partial config
Date: Wed, 12 Nov 2014 14:54:00 -0500
Message-ID: <5463BAD8.9090407@oracle.com>
References: <1415811865-19981-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1415811865-19981-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 11/12/2014 12:04 PM, Wei Liu wrote:
> This small series change the behavior of libxl_retrieve_domain_configuration,
> to make it continue to retrieve information from xenstore even if JSON template
> is not available.
> 
> This change of API behaviour is only internal. Conceptually speaking, any
> non-zero return value means d_config is partially filled. The chanage just
> makes it fill in more information (xenstore entries) than before (empty).
> Caller can still expect zero on success and non-zero on error and act
> accordingly.
> 
> "xl list -l" is now changed to print out the partial configuration, since it
> needs to be consistent with the short output.
> 
> Wei.
> 
> Wei Liu (2):
>   libxl: continue when encounter ERROR_JSON_CONFIG_EMPTY
>   xl: print out partial configuration in long mode of list command
> 
>  tools/libxl/libxl.c      |    6 +++++-
>  tools/libxl/xl_cmdimpl.c |    6 ++----
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 

It seem some other places may need fix too. Here is the test result:

# xl list -l
libxl: error: libxl.c:4844:libxl__get_memory_target: cannot get target memory info from /local/domain/1/memory/target
: No such file or directory
libxl: error: libxl.c:6582:libxl_retrieve_domain_configuration: fail to get memory target for domain 1
[
    {
        "domid": 0,
        "config": {
            "c_info": {
                "type": "pv",
                "name": "Domain-0"
            },
            "b_info": {
                "max_memkb": 876544,
                "target_memkb": 876543,
                "sched_params": {

                },
                "type.pv": {

                }
            }
        }
    },
    {
        "domid": 1,
        "config": {
            "c_info": {
                "name": "0004fb00000600008b1d33e2704548b7--incoming",
                "uuid": "0004fb00-0006-0000-8b1d-33e2704548b7"
            },
            "b_info": {
                "sched_params": {

                },
                "type.invalid": {

                }
            }
        }
    }
]

Thanks,

Zhigang