All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, tony@bakeyournoodle.com, stefanha@redhat.com,
	mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] raw-posix: Get rid of FIEMAP
Date: Wed, 12 Nov 2014 23:14:18 +0100	[thread overview]
Message-ID: <5463DBBA.1000802@redhat.com> (raw)
In-Reply-To: <1415820422-17796-1-git-send-email-armbru@redhat.com>



On 12/11/2014 20:27, Markus Armbruster wrote:
> See PATCH 2/2 for rationale.
> 
> Would you like this included in 2.2?
> 
> Markus Armbruster (2):
>   raw-posix: Fix comment for raw_co_get_block_status()
>   raw-posix: SEEK_HOLE suffices, get rid of FIEMAP
> 
>  block/raw-posix.c | 132 ++++++++++++++++++++----------------------------------
>  1 file changed, 48 insertions(+), 84 deletions(-)
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

though I'm not sure (and for once _I_ can say this to you :)) why you
did a bigger change than just removing the call to try_fiemap and the
definition of the function.

Paolo

  parent reply	other threads:[~2014-11-12 22:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 19:27 [Qemu-devel] [PATCH 0/2] raw-posix: Get rid of FIEMAP Markus Armbruster
2014-11-12 19:27 ` [Qemu-devel] [PATCH 1/2] raw-posix: Fix comment for raw_co_get_block_status() Markus Armbruster
2014-11-12 23:18   ` Eric Blake
2014-11-13  1:46   ` Fam Zheng
2014-11-13  8:39   ` Max Reitz
2014-11-12 19:27 ` [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP Markus Armbruster
2014-11-12 23:25   ` Eric Blake
2014-11-13  8:53     ` Markus Armbruster
2014-11-13 11:40     ` Kevin Wolf
2014-11-13 11:45       ` Max Reitz
2014-11-13 12:00         ` Kevin Wolf
2014-11-13 12:05           ` Max Reitz
2014-11-13 12:38           ` Markus Armbruster
2014-11-13 13:10             ` Kevin Wolf
2014-11-13  2:21   ` Fam Zheng
2014-11-13  8:26     ` Markus Armbruster
2014-11-13  8:39   ` Max Reitz
2014-11-13  9:25     ` Markus Armbruster
2014-11-12 22:14 ` Paolo Bonzini [this message]
2014-11-13  8:53   ` [Qemu-devel] [PATCH 0/2] raw-posix: Get " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5463DBBA.1000802@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=tony@bakeyournoodle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.