From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable Date: Thu, 13 Nov 2014 17:50:04 +0900 Message-ID: <546470BC.4020104@samsung.com> References: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: Kukjin Kim , Seung-Woo Kim , open list , "open list:DRM DRIVERS FOR E..." , Kyungmin Park , "moderated list:ARM/S5P EXYNOS AR..." , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNOuFhCAxMOyblCAwN+ydvCAyMTowMSwgQW5kcnplaiBIYWpkYSB3cm90ZToKPiBIaSBJ bmtpLAo+IAo+IE1hbnkgRXh5bm9zIERSTSBkcml2ZXJzIHVzZXMgZ2xvYmFsIHZhcmlhYmxlcyB0 byByZXByZXNlbnQgYXNzb2NpYXRlZCBkZXZpY2VzCj4gaW4gRXh5bm9zIERSTSBpbnRlcm5hbCBm cmFtZXdvcmsuIEl0IGlzIHF1aXRlIGNvbmZ1c2luZywgaXQgYWRkcyBkYXRhIGR1cGxpY2F0aW9u Cj4gYW5kIGZpbmFsbHkgaXQgZG9lcyBub3QgYWxsb3cgdG8gaGFuZGxlIG1vcmUgdGhhbiBvbmUg ZGV2aWNlIGluIHN5c3RlbS4KPiBJdCBzZWVtcyBiZXR0ZXIgdG8gZW1iZWQgc3VjaCBzdHJ1Y3R1 cmVzIGluIHByaXZhdGUgY29udGV4dCBvZiB0aGUgZGV2aWNlLgo+IAo+IFRoZSBwYXRjaHNldCBp cyBiYXNlZCBvbiBleHlub3NfZHJtX25leHQgcGx1cyBteSBwYXRjaCBbMV06Cj4gJ2RybS9leHlu b3M6IHJlbW92ZSBleHBsaWNpdCBlbmNvZGVyL2Nvbm5lY3RvciBkZS1pbml0aWFsaXphdGlvbicu Cj4gCj4gSWYgdGhlIHBhdGNoc2V0IGlzIE9LIGZvciB5b3UgSSBjYW4gcHJlcGFyZSBzaW1pbGFy IHBhdGNoZXMgZm9yIG90aGVyIEV4eW5vcyBEUk0gY29tcG9uZW50cy4KClNvcnJ5IGZvciBsYXRl LiBBcHBsaWVkLiBDYW4geW91IHByZXBhcmUgc2ltaWxhciBwYXRjaGVzIGZvciBvdGhlcj8gSWYK c28sIEknZCBoYXBweS4KClRoYW5rcywKSW5raSBEYWUKCj4gCj4gWzFdOiBodHRwczovL2xrbWwu b3JnL2xrbWwvMjAxNC85LzIyLzE0OAo+IAo+IFJlZ2FyZHMKPiBBbmRyemVqCj4gCj4gCj4gQW5k cnplaiBIYWpkYSAoNCk6Cj4gICBkcm0vZXh5bm9zL2RzaTogcmVtb3ZlIGdsb2JhbCB2YXJpYWJs ZSBleHlub3NfZHNpX2Rpc3BsYXkKPiAgIGRybS9leHlub3MvZHNpOiBzaW1wbGlmeSBkZXZpY2Ug cG9pbnRlciBldmFsdWF0aW9uCj4gICBkcm0vZXh5bm9zL2RzaTogcmVtb3ZlIHJlZHVuZGFudCBl bmNvZGVyIGZpZWxkCj4gICBkcm0vZXh5bm9zL2RzaTogc3RvcCB1c2luZyBkaXNwbGF5LT5jdHgg cG9pbnRlcgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZHNpLmMgfCA5 NiArKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ3 IGluc2VydGlvbnMoKyksIDQ5IGRlbGV0aW9ucygtKQo+IAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932295AbaKMIuJ (ORCPT ); Thu, 13 Nov 2014 03:50:09 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:62003 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065AbaKMIuG convert rfc822-to-8bit (ORCPT ); Thu, 13 Nov 2014 03:50:06 -0500 X-AuditID: cbfee68d-f79296d000004278-fe-546470bc3938 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <546470BC.4020104@samsung.com> Date: Thu, 13 Nov 2014 17:50:04 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Andrzej Hajda Cc: Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , "open list:DRM DRIVERS FOR E..." , "moderated list:ARM/S5P EXYNOS AR..." , open list Subject: Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable References: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> In-reply-to: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsWyRsSkSHdPQUqIwczNEha31p1jtbjy9T2b xYt7F1ksehdcZbM42/SG3eLyrjlsFjPO72OyWHvkLrvFjMkv2Rw4Pe53H2fy6NuyitHj8ya5 AOYoLpuU1JzMstQifbsEroxzP+4zFVzgrNh/eAZjA+NT9i5GDg4JAROJ9nc2XYycQKaYxIV7 69m6GLk4hASWMkrcfdfODJEwkTgz9wcrRGI6o8TXU08ZQRK8AoISPybfYwGxmQXUJSbNW8QM YYtIfJs/lRXC1pZYtvA1M0TzK0aJV1P7mCCatST2zV0E1swioCrR/ruTDcRmA7InrrgPZosK hEm8eLULbKgI0ILZJ++ADWIWmMoscWFRD1izsIC7xKPVa8BsIQFnicmnt4It4BRwkZi34RXY PxICl9glLhx+zAyxTUDi2+RDLBD/y0psOgD1pqTEwRU3WCYwis9C8twsJM/NQvLcLCTPLWBk WcUomlqQXFCclF5kqFecmFtcmpeul5yfu4kRGKmn/z3r3cF4+4D1IUYBDkYlHt4XLCkhQqyJ ZcWVuYcYTYEumsgsJZqcD0wHeSXxhsZmRhamJqbGRuaWZkrivIpSP4OFBNITS1KzU1MLUovi i0pzUosPMTJxcEo1MEq0nzCd3XHgdH7t7rIJtdzaLhmZE81rLtf6L937r05dR0nBtmvu1pjC 6NSHYrIpex04JinaZVVHToprnC0Xs1zvvoyF6p7gJfdqnM8c2FQYm8t83/jd1cAH2j9zs84d nVpqUxIgv+hdYlQ4u9tfpx0Ryzv/5uSV77dcVsu2lPmWwDJFUVMPJZbijERDLeai4kQA1bOV W88CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jQd09BSkhBnOe8FvcWneO1eLK1/ds Fi/uXWSx6F1wlc3ibNMbdovLu+awWcw4v4/JYu2Ru+wWMya/ZHPg9LjffZzJo2/LKkaPz5vk ApijGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4Du UFIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBmXLtzm6VgD2fFnV+LWBsY L7J3MXJySAiYSJyZ+4MVwhaTuHBvPVsXIxeHkMB0Romvp54ygiR4BQQlfky+x9LFyMHBLCAv ceRSNkiYWUBdYtK8RcwQ9a8YJV5N7WOCqNeS2Dd3EQuIzSKgKtH+u5MNxGYDsieuuA9miwqE Sbx4tYsZxBYBGjT75B2wQcwCU5klLizqAWsWFnCXeLR6DZgtJOAsMfn0VrAFnAIuEvM2vGKb wCgwC8l9sxDum4XkvgWMzKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxgqP6mfQOxlUNFocY BTgYlXh4X7CkhAixJpYVV+YeYpTgYFYS4W3SAQrxpiRWVqUW5ccXleakFh9iNAX6biKzlGhy PjDh5JXEGxqbmBlZGpkbWhgZmyuJ8x5stQ4UEkhPLEnNTk0tSC2C6WPi4JRqYLQ7Zbb8y/E7 SaJPKsy+zSvfp5DJ7hAyzfeYyam5zBuiin6meBX/r/SbM7vrUYCzl9gm7+X82+ZMz268rCTj dF/x9GL1XfdeL65buXXKo6UH7j9g2vSZ+Vonc7RG5rLZTB337k6Y9MHvxEFDO67Up55cxnM3 uMi9WaDHsnJz1HkzHl4L/bMVJmeUWIozEg21mIuKEwHLCm5AAAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014년 10월 07일 21:01, Andrzej Hajda wrote: > Hi Inki, > > Many Exynos DRM drivers uses global variables to represent associated devices > in Exynos DRM internal framework. It is quite confusing, it adds data duplication > and finally it does not allow to handle more than one device in system. > It seems better to embed such structures in private context of the device. > > The patchset is based on exynos_drm_next plus my patch [1]: > 'drm/exynos: remove explicit encoder/connector de-initialization'. > > If the patchset is OK for you I can prepare similar patches for other Exynos DRM components. Sorry for late. Applied. Can you prepare similar patches for other? If so, I'd happy. Thanks, Inki Dae > > [1]: https://lkml.org/lkml/2014/9/22/148 > > Regards > Andrzej > > > Andrzej Hajda (4): > drm/exynos/dsi: remove global variable exynos_dsi_display > drm/exynos/dsi: simplify device pointer evaluation > drm/exynos/dsi: remove redundant encoder field > drm/exynos/dsi: stop using display->ctx pointer > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 96 ++++++++++++++++----------------- > 1 file changed, 47 insertions(+), 49 deletions(-) >