From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH v3 RESEND 1/2] drm/exynos: dp: Remove support for unused dptx-phy Date: Thu, 13 Nov 2014 17:51:10 +0900 Message-ID: <546470FE.90008@samsung.com> References: <000001cffe5c3df5500$%han@samsung.com> <1415785330-28123-1-git-send-email-gautam.vivek@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1415785330-28123-1-git-send-email-gautam.vivek@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vivek Gautam Cc: kgene.kim@samsung.com, seanpaul@google.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, "cpgs ." , ajaykumar.rs@samsung.com List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNOuFhCAxMeyblCAxMuydvCAxODo0MiwgVml2ZWsgR2F1dGFtIHdyb3RlOgo+IE5vdyB0 aGF0IHdlIGhhdmUgbW92ZWQgdG8gZ2VuZXJpYyBwaHkgYmFzZWQgYmluZGluZ3MsCj4gd2UgZG9u J3QgbmVlZCB0byBoYXZlIGFueSBjb2RlIHJlbGF0ZWQgdG8gb2xkZXIgZHB0eC1waHkuCj4gTm9i b2R5IGlzIHVzaW5nIHRoaXMgZHB0eC1waHkgYW55bW9yZSwgc28gcmVtb3ZpbmcgdGhlCj4gc2Ft ZS4KCkFwcGxpZWQuCgpUaGFua3MsCklua2kgRGFlCgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZpdmVr IEdhdXRhbSA8Z2F1dGFtLnZpdmVrQHNhbXN1bmcuY29tPgo+IEFja2VkLWJ5OiBKaW5nb28gSGFu IDxqZzEuaGFuQHNhbXN1bmcuY29tPgo+IENjOiBJbmtpIERhZSA8aW5raS5kYWVAc2Ftc3VuZy5j b20+Cj4gLS0tCj4gCj4gUHJvYmxlbSB3aXRoIG15IG1haWwgY2xpZW50IGNhdXNlZCBjaGFuZ2Ug aW4gYXV0aG9yJ3MgbWFpbCBpZC4KPiBTbyByZXNlbmRpbmcgaXQgd2l0aCBhdXRob3JzaGlwIHVu ZGVyIG15IFNhbXN1bmcgaWQuCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2Rw X2NvcmUuYyB8ICAgNzQgKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmggfCAgICAyIC0KPiAgMiBmaWxlcyBjaGFu Z2VkLCAxNyBpbnNlcnRpb25zKCspLCA1OSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHBfY29yZS5jIGIvZHJpdmVycy9ncHUvZHJt L2V4eW5vcy9leHlub3NfZHBfY29yZS5jCj4gaW5kZXggY2Q1MGVjZS4uZGJlOWFkZCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmMKPiBAQCAtMTA1MiwyOCArMTA1 MiwxNCBAQCBzdGF0aWMgaW50IGV4eW5vc19kcF9jcmVhdGVfY29ubmVjdG9yKHN0cnVjdCBleHlu b3NfZHJtX2Rpc3BsYXkgKmRpc3BsYXksCj4gIAo+ICBzdGF0aWMgdm9pZCBleHlub3NfZHBfcGh5 X2luaXQoc3RydWN0IGV4eW5vc19kcF9kZXZpY2UgKmRwKQo+ICB7Cj4gLQlpZiAoZHAtPnBoeSkg ewo+ICsJaWYgKGRwLT5waHkpCj4gIAkJcGh5X3Bvd2VyX29uKGRwLT5waHkpOwo+IC0JfSBlbHNl IGlmIChkcC0+cGh5X2FkZHIpIHsKPiAtCQl1MzIgcmVnOwo+IC0KPiAtCQlyZWcgPSBfX3Jhd19y ZWFkbChkcC0+cGh5X2FkZHIpOwo+IC0JCXJlZyB8PSBkcC0+ZW5hYmxlX21hc2s7Cj4gLQkJX19y YXdfd3JpdGVsKHJlZywgZHAtPnBoeV9hZGRyKTsKPiAtCX0KPiAgfQo+ICAKPiAgc3RhdGljIHZv aWQgZXh5bm9zX2RwX3BoeV9leGl0KHN0cnVjdCBleHlub3NfZHBfZGV2aWNlICpkcCkKPiAgewo+ IC0JaWYgKGRwLT5waHkpIHsKPiArCWlmIChkcC0+cGh5KQo+ICAJCXBoeV9wb3dlcl9vZmYoZHAt PnBoeSk7Cj4gLQl9IGVsc2UgaWYgKGRwLT5waHlfYWRkcikgewo+IC0JCXUzMiByZWc7Cj4gLQo+ IC0JCXJlZyA9IF9fcmF3X3JlYWRsKGRwLT5waHlfYWRkcik7Cj4gLQkJcmVnICY9IH4oZHAtPmVu YWJsZV9tYXNrKTsKPiAtCQlfX3Jhd193cml0ZWwocmVnLCBkcC0+cGh5X2FkZHIpOwo+IC0JfQo+ ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBleHlub3NfZHBfcG93ZXJvbihzdHJ1Y3QgZXh5bm9zX2Ry bV9kaXNwbGF5ICpkaXNwbGF5KQo+IEBAIC0xMjEwLDQ0ICsxMTk2LDYgQEAgc3RhdGljIHN0cnVj dCB2aWRlb19pbmZvICpleHlub3NfZHBfZHRfcGFyc2VfcGRhdGEoc3RydWN0IGRldmljZSAqZGV2 KQo+ICAJcmV0dXJuIGRwX3ZpZGVvX2NvbmZpZzsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBleHlu b3NfZHBfZHRfcGFyc2VfcGh5ZGF0YShzdHJ1Y3QgZXh5bm9zX2RwX2RldmljZSAqZHApCj4gLXsK PiAtCXN0cnVjdCBkZXZpY2Vfbm9kZSAqZHBfcGh5X25vZGUgPSBvZl9ub2RlX2dldChkcC0+ZGV2 LT5vZl9ub2RlKTsKPiAtCXUzMiBwaHlfYmFzZTsKPiAtCWludCByZXQgPSAwOwo+IC0KPiAtCWRw X3BoeV9ub2RlID0gb2ZfZmluZF9ub2RlX2J5X25hbWUoZHBfcGh5X25vZGUsICJkcHR4LXBoeSIp Owo+IC0JaWYgKCFkcF9waHlfbm9kZSkgewo+IC0JCWRwLT5waHkgPSBkZXZtX3BoeV9nZXQoZHAt PmRldiwgImRwIik7Cj4gLQkJcmV0dXJuIFBUUl9FUlJfT1JfWkVSTyhkcC0+cGh5KTsKPiAtCX0K PiAtCj4gLQlpZiAob2ZfcHJvcGVydHlfcmVhZF91MzIoZHBfcGh5X25vZGUsICJyZWciLCAmcGh5 X2Jhc2UpKSB7Cj4gLQkJZGV2X2VycihkcC0+ZGV2LCAiZmFpbGVkIHRvIGdldCByZWcgZm9yIGRw dHgtcGh5XG4iKTsKPiAtCQlyZXQgPSAtRUlOVkFMOwo+IC0JCWdvdG8gZXJyOwo+IC0JfQo+IC0K PiAtCWlmIChvZl9wcm9wZXJ0eV9yZWFkX3UzMihkcF9waHlfbm9kZSwgInNhbXN1bmcsZW5hYmxl LW1hc2siLAo+IC0JCQkJJmRwLT5lbmFibGVfbWFzaykpIHsKPiAtCQlkZXZfZXJyKGRwLT5kZXYs ICJmYWlsZWQgdG8gZ2V0IGVuYWJsZS1tYXNrIGZvciBkcHR4LXBoeVxuIik7Cj4gLQkJcmV0ID0g LUVJTlZBTDsKPiAtCQlnb3RvIGVycjsKPiAtCX0KPiAtCj4gLQlkcC0+cGh5X2FkZHIgPSBpb3Jl bWFwKHBoeV9iYXNlLCBTWl80KTsKPiAtCWlmICghZHAtPnBoeV9hZGRyKSB7Cj4gLQkJZGV2X2Vy cihkcC0+ZGV2LCAiZmFpbGVkIHRvIGlvcmVtYXAgZHAtcGh5XG4iKTsKPiAtCQlyZXQgPSAtRU5P TUVNOwo+IC0JCWdvdG8gZXJyOwo+IC0JfQo+IC0KPiAtZXJyOgo+IC0Jb2Zfbm9kZV9wdXQoZHBf cGh5X25vZGUpOwo+IC0KPiAtCXJldHVybiByZXQ7Cj4gLX0KPiAtCj4gIHN0YXRpYyBpbnQgZXh5 bm9zX2RwX2R0X3BhcnNlX3BhbmVsKHN0cnVjdCBleHlub3NfZHBfZGV2aWNlICpkcCkKPiAgewo+ ICAJaW50IHJldDsKPiBAQCAtMTI3Nyw5ICsxMjI1LDIxIEBAIHN0YXRpYyBpbnQgZXh5bm9zX2Rw X2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRh dGEpCj4gIAlpZiAoSVNfRVJSKGRwLT52aWRlb19pbmZvKSkKPiAgCQlyZXR1cm4gUFRSX0VSUihk cC0+dmlkZW9faW5mbyk7Cj4gIAo+IC0JcmV0ID0gZXh5bm9zX2RwX2R0X3BhcnNlX3BoeWRhdGEo ZHApOwo+IC0JaWYgKHJldCkKPiAtCQlyZXR1cm4gcmV0Owo+ICsJZHAtPnBoeSA9IGRldm1fcGh5 X2dldChkcC0+ZGV2LCAiZHAiKTsKPiArCWlmIChJU19FUlIoZHAtPnBoeSkpIHsKPiArCQlkZXZf ZXJyKGRwLT5kZXYsICJubyBEUCBwaHkgY29uZmlndXJlZFxuIik7Cj4gKwkJcmV0ID0gUFRSX0VS UihkcC0+cGh5KTsKPiArCQlpZiAocmV0KSB7Cj4gKwkJCS8qCj4gKwkJCSAqIHBoeSBpdHNlbGYg aXMgbm90IGVuYWJsZWQsIHNvIHdlIGNhbiBtb3ZlIGZvcndhcmQKPiArCQkJICogYXNzaWduaW5n IE5VTEwgdG8gcGh5IHBvaW50ZXIuCj4gKwkJCSAqLwo+ICsJCQlpZiAocmV0ID09IC1FTk9TWVMg fHwgcmV0ID09IC1FTk9ERVYpCj4gKwkJCQlkcC0+cGh5ID0gTlVMTDsKPiArCQkJZWxzZQo+ICsJ CQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gKwl9Cj4gIAo+ICAJaWYgKCFkcC0+cGFuZWwpIHsKPiAg CQlyZXQgPSBleHlub3NfZHBfZHRfcGFyc2VfcGFuZWwoZHApOwo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmggYi9kcml2ZXJzL2dwdS9kcm0vZXh5 bm9zL2V4eW5vc19kcF9jb3JlLmgKPiBpbmRleCBhMWFlZTY5Li42NDI2MjAxIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwX2NvcmUuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwX2NvcmUuaAo+IEBAIC0xNTMsOCArMTUzLDYgQEAg c3RydWN0IGV4eW5vc19kcF9kZXZpY2Ugewo+ICAJc3RydWN0IGNsawkJKmNsb2NrOwo+ICAJdW5z aWduZWQgaW50CQlpcnE7Cj4gIAl2b2lkIF9faW9tZW0JCSpyZWdfYmFzZTsKPiAtCXZvaWQgX19p b21lbQkJKnBoeV9hZGRyOwo+IC0JdW5zaWduZWQgaW50CQllbmFibGVfbWFzazsKPiAgCj4gIAlz dHJ1Y3QgdmlkZW9faW5mbwkqdmlkZW9faW5mbzsKPiAgCXN0cnVjdCBsaW5rX3RyYWluCWxpbmtf dHJhaW47Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932341AbaKMIvR (ORCPT ); Thu, 13 Nov 2014 03:51:17 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:52956 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932302AbaKMIvM convert rfc822-to-8bit (ORCPT ); Thu, 13 Nov 2014 03:51:12 -0500 X-AuditID: cbfee68d-f79296d000004278-3a-546470fe4314 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <546470FE.90008@samsung.com> Date: Thu, 13 Nov 2014 17:51:10 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Vivek Gautam Cc: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kgene.kim@samsung.com, seanpaul@google.com, ajaykumar.rs@samsung.com, "cpgs ." Subject: Re: [PATCH v3 RESEND 1/2] drm/exynos: dp: Remove support for unused dptx-phy References: <000001cffe5c3df5500$%han@samsung.com> <1415785330-28123-1-git-send-email-gautam.vivek@samsung.com> In-reply-to: <1415785330-28123-1-git-send-email-gautam.vivek@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsWyRsSkSPdfQUqIwaW1WhYH3h9ksXh5SNPi ytf3bBZtVw6yW/QuuMpmcXnXHDaLGef3MVnMPZjrwOGxYFOpx/3u40wefVtWMXp83iQXwBLF ZZOSmpNZllqkb5fAlfHiZAtTwX3FitPNJ1kaGF9LdTFycEgImEhcflnSxcgJZIpJXLi3nq2L kYtDSGApo8SXv5tYIRImEv0zX0MlpgMlrt4HS/AKCEr8mHyPBcRmFlCXmDRvETOELSJxZF8r O4StLbFs4WtmiOZXjBI9K08wQzRrSPxeeIcJxGYRUJWYt/sYmM0GZE9ccZ8NxBYVCJN48WoX WL0I0KDtcyexggxiFjjNKDGj5ShYkbBAuMSRDdvALhISKJS403WXEcTmFPCU2Pj5ERNIg4TA KXaJt78Ws0FsE5D4NvkQC8T/shKbDjBDvCkpcXDFDZYJjOKzkDw3C8lzs5A8NwvJcwsYWVYx iqYWJBcUJ6UXGeoVJ+YWl+al6yXn525iBMbo6X/Pencw3j5gfYhRgINRiYf3BUtKiBBrYllx Ze4hRlOgiyYyS4km5wMTQV5JvKGxmZGFqYmpsZG5pZmSOK+i1M9gIYH0xJLU7NTUgtSi+KLS nNTiQ4xMHJxSDYwnP2k2X7+twHP+5TSP1yFOG6tCGzj+aKh8YDyU2pfXLyjTFzJtZnfB4vrN tlVHXPtrWQJtgxTaP33VSRfN+nztikGU6+M2D/ci+ccqa789uLbC48Kkqt2WK9n0Va9c+ymY eabH92HH80MBW2VcDKSaW7/8/aW8aEn3Url5X/g+HbVc/3HK6SolluKMREMt5qLiRAB15v0I zAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsVy+t9jQd1/BSkhBiemKVsceH+QxeLlIU2L K1/fs1m0XTnIbtG74CqbxeVdc9gsZpzfx2Qx92CuA4fHgk2lHve7jzN59G1ZxejxeZNcAEtU A6NNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtARSgpl iTmlQKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaMH6vPsRQsVqxoa8tvYFwv1cXI ySEhYCLRP/M1G4QtJnHh3nogm4tDSGA6o8SXq/dZQRK8AoISPybfY+li5OBgFpCXOHIpGyTM LKAuMWneImaI+leMEj0rTzBD1GtI/F54hwnEZhFQlZi3+xiYzQZkT1xxH2yZqECYxItXu8Dq RQS0JbbPncQKMohZ4DSjxIyWo2BFwgLhEkc2bAM7QkigUOJO111GEJtTwFNi4+dHTBMYBWYh uW8Wwn2zkNy3gJF5FaNoakFyQXFSeq6hXnFibnFpXrpecn7uJkZwND+T2sG4ssHiEKMAB6MS D+8LlpQQIdbEsuLK3EOMEhzMSiK8TTpAId6UxMqq1KL8+KLSnNTiQ4ymQN9NZJYSTc4HJpq8 knhDYxMzI0sjc0MLI2NzJXHeA63WgUIC6YklqdmpqQWpRTB9TBycUg2MZhVKrMFaEz7f6/x/ Pb2x5t+2XU61c9mUpq28Ju4saxW97NqB5sOswZ/Kp1kezbT7elv50xTOpaq6FseqXqvwHzzx ne9BmEUan8iFl7IK73LzU5auFvko73JF0Oj9du1fUgXzAqaZCSc+4FgxK9P625cTDPNMvqdd /lgn5B7Es4uLvz8i/ImvEktxRqKhFnNRcSIA3RkOqfwCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014년 11월 12일 18:42, Vivek Gautam wrote: > Now that we have moved to generic phy based bindings, > we don't need to have any code related to older dptx-phy. > Nobody is using this dptx-phy anymore, so removing the > same. Applied. Thanks, Inki Dae > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > Cc: Inki Dae > --- > > Problem with my mail client caused change in author's mail id. > So resending it with authorship under my Samsung id. > > drivers/gpu/drm/exynos/exynos_dp_core.c | 74 +++++++------------------------ > drivers/gpu/drm/exynos/exynos_dp_core.h | 2 - > 2 files changed, 17 insertions(+), 59 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c > index cd50ece..dbe9add 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp_core.c > +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c > @@ -1052,28 +1052,14 @@ static int exynos_dp_create_connector(struct exynos_drm_display *display, > > static void exynos_dp_phy_init(struct exynos_dp_device *dp) > { > - if (dp->phy) { > + if (dp->phy) > phy_power_on(dp->phy); > - } else if (dp->phy_addr) { > - u32 reg; > - > - reg = __raw_readl(dp->phy_addr); > - reg |= dp->enable_mask; > - __raw_writel(reg, dp->phy_addr); > - } > } > > static void exynos_dp_phy_exit(struct exynos_dp_device *dp) > { > - if (dp->phy) { > + if (dp->phy) > phy_power_off(dp->phy); > - } else if (dp->phy_addr) { > - u32 reg; > - > - reg = __raw_readl(dp->phy_addr); > - reg &= ~(dp->enable_mask); > - __raw_writel(reg, dp->phy_addr); > - } > } > > static void exynos_dp_poweron(struct exynos_drm_display *display) > @@ -1210,44 +1196,6 @@ static struct video_info *exynos_dp_dt_parse_pdata(struct device *dev) > return dp_video_config; > } > > -static int exynos_dp_dt_parse_phydata(struct exynos_dp_device *dp) > -{ > - struct device_node *dp_phy_node = of_node_get(dp->dev->of_node); > - u32 phy_base; > - int ret = 0; > - > - dp_phy_node = of_find_node_by_name(dp_phy_node, "dptx-phy"); > - if (!dp_phy_node) { > - dp->phy = devm_phy_get(dp->dev, "dp"); > - return PTR_ERR_OR_ZERO(dp->phy); > - } > - > - if (of_property_read_u32(dp_phy_node, "reg", &phy_base)) { > - dev_err(dp->dev, "failed to get reg for dptx-phy\n"); > - ret = -EINVAL; > - goto err; > - } > - > - if (of_property_read_u32(dp_phy_node, "samsung,enable-mask", > - &dp->enable_mask)) { > - dev_err(dp->dev, "failed to get enable-mask for dptx-phy\n"); > - ret = -EINVAL; > - goto err; > - } > - > - dp->phy_addr = ioremap(phy_base, SZ_4); > - if (!dp->phy_addr) { > - dev_err(dp->dev, "failed to ioremap dp-phy\n"); > - ret = -ENOMEM; > - goto err; > - } > - > -err: > - of_node_put(dp_phy_node); > - > - return ret; > -} > - > static int exynos_dp_dt_parse_panel(struct exynos_dp_device *dp) > { > int ret; > @@ -1277,9 +1225,21 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) > if (IS_ERR(dp->video_info)) > return PTR_ERR(dp->video_info); > > - ret = exynos_dp_dt_parse_phydata(dp); > - if (ret) > - return ret; > + dp->phy = devm_phy_get(dp->dev, "dp"); > + if (IS_ERR(dp->phy)) { > + dev_err(dp->dev, "no DP phy configured\n"); > + ret = PTR_ERR(dp->phy); > + if (ret) { > + /* > + * phy itself is not enabled, so we can move forward > + * assigning NULL to phy pointer. > + */ > + if (ret == -ENOSYS || ret == -ENODEV) > + dp->phy = NULL; > + else > + return ret; > + } > + } > > if (!dp->panel) { > ret = exynos_dp_dt_parse_panel(dp); > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h > index a1aee69..6426201 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp_core.h > +++ b/drivers/gpu/drm/exynos/exynos_dp_core.h > @@ -153,8 +153,6 @@ struct exynos_dp_device { > struct clk *clock; > unsigned int irq; > void __iomem *reg_base; > - void __iomem *phy_addr; > - unsigned int enable_mask; > > struct video_info *video_info; > struct link_train link_train; >