From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file
Date: Thu, 13 Nov 2014 09:58:54 +0100 [thread overview]
Message-ID: <546472CE.3050109@denx.de> (raw)
In-Reply-To: <1415831265-46636-5-git-send-email-john.tobias.ph@gmail.com>
On 12/11/2014 23:27, John Tobias wrote:
> add the spl info in the header file.
> Also, added a macro statement in m6sabre_common.h to avoid compiler
> warning.
>
> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> ---
> include/configs/mx6sabre_common.h | 2 ++
> include/configs/mx6sabresd.h | 6 ++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
> index c81e9e9..e4d0d14 100644
> --- a/include/configs/mx6sabre_common.h
> +++ b/include/configs/mx6sabre_common.h
> @@ -95,7 +95,9 @@
> #define CONFIG_BOOTDELAY 1
>
> #define CONFIG_LOADADDR 0x12000000
> +#ifndef CONFIG_SYS_TEXT_BASE
> #define CONFIG_SYS_TEXT_BASE 0x17800000
> +#endif
>
Why is that needed ? SPL does not use it, because it use
CONFIG_SPL_TEXT_BASE, and this is defined in imx6_spl.h. And you do not
redefine it, meaning that overwriting the value is not necessary at all,
as we expect.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2014-11-13 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 22:27 [U-Boot] [PATCH v7 0/5] iMX6 SabreSD SPL Support John Tobias
2014-11-12 22:27 ` [U-Boot] [PATCH v7 1/5] imx6: add spl config for mx6sabresd John Tobias
2014-11-12 22:27 ` [U-Boot] [PATCH v7 2/5] imx6: add data configuration file for SPL John Tobias
2014-11-12 22:27 ` [U-Boot] [PATCH v7 3/5] kconfig: imx6: add SUPPORT_SPL John Tobias
2014-11-12 22:27 ` [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file John Tobias
2014-11-13 8:58 ` Stefano Babic [this message]
2014-11-13 12:41 ` Fabio Estevam
2014-11-13 12:49 ` Fabio Estevam
2014-11-13 14:39 ` Fabio Estevam
2014-11-13 14:42 ` Stefano Babic
2014-11-13 14:43 ` Fabio Estevam
2014-11-13 15:49 ` John Tobias
2014-11-13 15:47 ` John Tobias
2014-11-13 16:29 ` Stefano Babic
2014-11-12 22:27 ` [U-Boot] [PATCH v7 5/5] imx6: SPL support for iMX6 SabreSD John Tobias
2014-11-13 8:22 ` Stefano Babic
2014-11-12 22:44 ` [U-Boot] [PATCH v7 0/5] iMX6 SabreSD SPL Support Fabio Estevam
2014-11-13 15:32 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546472CE.3050109@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.