Re: [PATCH 1/7] drm/exynos: fimd: remove unnecessary waiting vblank routine

[Inki Dae <inki.dae@samsung.com>]

On 2014년 10월 01일 15:19, YoungJun Cho wrote:
> The exynos_drm_crtc_dpms() waits until pended page flip
> queue is empty, calls the drm_vblank_off() then calls
> manager->ops->dpms() when mode is DRM_MODE_DPMS_OFF.
> The fimd_dpms() is one of manager->ops->dpms()s and
> finally calls fimd_window_suspend().
> But there is no active window and vblank is already off
> when it is called.
> So addtional waiting vblank is not necessary any more.

Applied.

Thanks,
Inki Dae

> 
> Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
> Acked-by: Inki Dae <inki.dae@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 085b066..8b31b7e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -803,7 +803,6 @@ static void fimd_window_suspend(struct exynos_drm_manager *mgr)
>  		if (win_data->enabled)
>  			fimd_win_disable(mgr, i);
>  	}
> -	fimd_wait_for_vblank(mgr);
>  }
>  
>  static void fimd_window_resume(struct exynos_drm_manager *mgr)
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel