From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH 2/7] drm/exynos: fimd: add fimd_channel_win() to clean up code Date: Thu, 13 Nov 2014 18:05:53 +0900 Message-ID: <54647471.6030502@samsung.com> References: <1412144353-13114-1-git-send-email-yj44.cho@samsung.com> <1412144353-13114-3-git-send-email-yj44.cho@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E7016EA32 for ; Thu, 13 Nov 2014 01:05:55 -0800 (PST) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NEY003OKZXUSBD0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 13 Nov 2014 18:05:54 +0900 (KST) In-reply-to: <1412144353-13114-3-git-send-email-yj44.cho@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YoungJun Cho Cc: sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org, a.hajda@samsung.com, kyungmin.park@samsung.com List-Id: dri-devel@lists.freedesktop.org T24gMjAxNOuFhCAxMOyblCAwMeydvCAxNToxOSwgWW91bmdKdW4gQ2hvIHdyb3RlOgo+IFRoZSBF TldJTl9GIGluIFdJTkNPTiMgcmVnaXN0ZXIgYW5kIEMjX0VOX0ZzIGluIFNIQURPV0NPTiByZWdp c3Rlcgo+IHNob3VsZCBiZSBhbHdheXMgbWF0Y2hlZCB0b2dldGhlciwgc28gYWRkcyBmaW1kX2No YW5uZWxfd2luKCkKPiB0byBjbGVhbiB1cCBjb2RlLgo+IEFuZCB0aGlzIGZpbWRfY2hhbm5lbF93 aW4oKSBzaG91bGQgYmUgY2FsbGVkIGJlZm9yZSB1bnByb3RlY3RpbmcKPiB3aW5kb3cgaW4gZmlt ZF93aW5fY29tbWl0KCkuCgpTb3JyeSBmb3IgbGF0ZS4gYmVsb3cgaXMgbXkgY29tbWVudC4KCj4g Cj4gU2lnbmVkLW9mZi1ieTogWW91bmdKdW4gQ2hvIDx5ajQ0LmNob0BzYW1zdW5nLmNvbT4KPiBB Y2tlZC1ieTogSW5raSBEYWUgPGlua2kuZGFlQHNhbXN1bmcuY29tPgo+IEFja2VkLWJ5OiBLeXVu Z21pbiBQYXJrIDxreXVuZ21pbi5wYXJrQHNhbXN1bmcuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZmltZC5jIHwgNjIgKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDMyIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19k cm1fZmltZC5jIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2ZpbWQuYwo+IGlu ZGV4IDhiMzFiN2UuLmIyZjYwMDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5v cy9leHlub3NfZHJtX2ZpbWQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9z X2RybV9maW1kLmMKPiBAQCAtMjE0LDYgKzIxNCwzMyBAQCBzdGF0aWMgdm9pZCBmaW1kX3dhaXRf Zm9yX3ZibGFuayhzdHJ1Y3QgZXh5bm9zX2RybV9tYW5hZ2VyICptZ3IpCj4gIAkJRFJNX0RFQlVH X0tNUygidmJsYW5rIHdhaXQgdGltZWQgb3V0LlxuIik7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lk IGZpbWRfY2hhbm5lbF93aW4oc3RydWN0IGZpbWRfY29udGV4dCAqY3R4LCBpbnQgd2luLCBib29s IGVuYWJsZSkKPiArewo+ICsJdTMyIHZhbDsKPiArCj4gKwkvKiBmb3IgRE1BIG91dHB1dCAqLwo+ ICsJdmFsID0gcmVhZGwoY3R4LT5yZWdzICsgV0lOQ09OKHdpbikpOwo+ICsKPiArCWlmIChlbmFi bGUpCj4gKwkJdmFsIHw9IFdJTkNPTnhfRU5XSU47Cj4gKwllbHNlCj4gKwkJdmFsICY9IH5XSU5D T054X0VOV0lOOwo+ICsKPiArCXdyaXRlbCh2YWwsIGN0eC0+cmVncyArIFdJTkNPTih3aW4pKTsK PiArCj4gKwkvKiBmb3Igc2hhZG93IGNoYW5uZWwgKi8KPiArCWlmIChjdHgtPmRyaXZlcl9kYXRh LT5oYXNfc2hhZG93Y29uKSB7Cj4gKwkJdmFsID0gcmVhZGwoY3R4LT5yZWdzICsgU0hBRE9XQ09O KTsKPiArCj4gKwkJaWYgKGVuYWJsZSkKPiArCQkJdmFsIHw9IFNIQURPV0NPTl9DSHhfRU5BQkxF KHdpbik7Cj4gKwkJZWxzZQo+ICsJCQl2YWwgJj0gflNIQURPV0NPTl9DSHhfRU5BQkxFKHdpbik7 Cj4gKwo+ICsJCXdyaXRlbCh2YWwsIGN0eC0+cmVncyArIFNIQURPV0NPTik7Cj4gKwl9Cj4gK30K CgpUaGlzIGZ1bmN0aW9uIGluY2x1ZGVzIHR3byBmdW5jdGlvbmFsaXRpZXMuIE9uZSBpcyBjb250 cm9sbGluZyBETUEKb3V0cHV0LiBPdGhlciBpcyBjb250cm9sbGluZyBzaGFkb3cgY2hhbm5lbC4g SG93IGFib3V0IHVzaW5nIHNlcGFyYXRlZAp0d28gZnVuY3Rpb25zIGluc3RlYWQ/IEFuZCBsZXQn cyBjYWxsIHNoYWRvd2NvbiBjb250cm9sIGZ1bmN0aW9uIG9ubHkgaWYKaGFzX3NoYWRvd2NvbiBp cyAxLgoKVGhhbmtzLApJbmtpIERhZQoKCj4gKwo+ICBzdGF0aWMgdm9pZCBmaW1kX2NsZWFyX2No YW5uZWwoc3RydWN0IGV4eW5vc19kcm1fbWFuYWdlciAqbWdyKQo+ICB7Cj4gIAlzdHJ1Y3QgZmlt ZF9jb250ZXh0ICpjdHggPSBtZ3ItPmN0eDsKPiBAQCAtMjI2LDE2ICsyNTMsNyBAQCBzdGF0aWMg dm9pZCBmaW1kX2NsZWFyX2NoYW5uZWwoc3RydWN0IGV4eW5vc19kcm1fbWFuYWdlciAqbWdyKQo+ ICAJCXUzMiB2YWwgPSByZWFkbChjdHgtPnJlZ3MgKyBXSU5DT04od2luKSk7Cj4gIAo+ICAJCWlm ICh2YWwgJiBXSU5DT054X0VOV0lOKSB7Cj4gLQkJCS8qIHdpbmNvbiAqLwo+IC0JCQl2YWwgJj0g fldJTkNPTnhfRU5XSU47Cj4gLQkJCXdyaXRlbCh2YWwsIGN0eC0+cmVncyArIFdJTkNPTih3aW4p KTsKPiAtCj4gLQkJCS8qIHVucHJvdGVjdCB3aW5kb3dzICovCj4gLQkJCWlmIChjdHgtPmRyaXZl cl9kYXRhLT5oYXNfc2hhZG93Y29uKSB7Cj4gLQkJCQl2YWwgPSByZWFkbChjdHgtPnJlZ3MgKyBT SEFET1dDT04pOwo+IC0JCQkJdmFsICY9IH5TSEFET1dDT05fQ0h4X0VOQUJMRSh3aW4pOwo+IC0J CQkJd3JpdGVsKHZhbCwgY3R4LT5yZWdzICsgU0hBRE9XQ09OKTsKPiAtCQkJfQo+ICsJCQlmaW1k X2NoYW5uZWxfd2luKGN0eCwgd2luLCBmYWxzZSk7Cj4gIAkJCWNoX2VuYWJsZWQgPSAxOwo+ICAJ CX0KPiAgCX0KPiBAQCAtNzMwLDIwICs3NDgsMTEgQEAgc3RhdGljIHZvaWQgZmltZF93aW5fY29t bWl0KHN0cnVjdCBleHlub3NfZHJtX21hbmFnZXIgKm1nciwgaW50IHpwb3MpCj4gIAlpZiAod2lu ICE9IDApCj4gIAkJZmltZF93aW5fc2V0X2NvbGtleShjdHgsIHdpbik7Cj4gIAo+IC0JLyogd2lu Y29uICovCj4gLQl2YWwgPSByZWFkbChjdHgtPnJlZ3MgKyBXSU5DT04od2luKSk7Cj4gLQl2YWwg fD0gV0lOQ09OeF9FTldJTjsKPiAtCXdyaXRlbCh2YWwsIGN0eC0+cmVncyArIFdJTkNPTih3aW4p KTsKPiArCWZpbWRfY2hhbm5lbF93aW4oY3R4LCB3aW4sIHRydWUpOwo+ICAKPiAgCS8qIEVuYWJs ZSBETUEgY2hhbm5lbCBhbmQgdW5wcm90ZWN0IHdpbmRvd3MgKi8KPiAgCWZpbWRfc2hhZG93X3By b3RlY3Rfd2luKGN0eCwgd2luLCBmYWxzZSk7Cj4gIAo+IC0JaWYgKGN0eC0+ZHJpdmVyX2RhdGEt Pmhhc19zaGFkb3djb24pIHsKPiAtCQl2YWwgPSByZWFkbChjdHgtPnJlZ3MgKyBTSEFET1dDT04p Owo+IC0JCXZhbCB8PSBTSEFET1dDT05fQ0h4X0VOQUJMRSh3aW4pOwo+IC0JCXdyaXRlbCh2YWws IGN0eC0+cmVncyArIFNIQURPV0NPTik7Cj4gLQl9Cj4gLQo+ICAJd2luX2RhdGEtPmVuYWJsZWQg PSB0cnVlOwo+ICAKPiAgCWlmIChjdHgtPmk4MF9pZikKPiBAQCAtNzU1LDcgKzc2NCw2IEBAIHN0 YXRpYyB2b2lkIGZpbWRfd2luX2Rpc2FibGUoc3RydWN0IGV4eW5vc19kcm1fbWFuYWdlciAqbWdy LCBpbnQgenBvcykKPiAgCXN0cnVjdCBmaW1kX2NvbnRleHQgKmN0eCA9IG1nci0+Y3R4Owo+ICAJ c3RydWN0IGZpbWRfd2luX2RhdGEgKndpbl9kYXRhOwo+ICAJaW50IHdpbiA9IHpwb3M7Cj4gLQl1 MzIgdmFsOwo+ICAKPiAgCWlmICh3aW4gPT0gREVGQVVMVF9aUE9TKQo+ICAJCXdpbiA9IGN0eC0+ ZGVmYXVsdF93aW47Cj4gQEAgLTc3NCwxNyArNzgyLDcgQEAgc3RhdGljIHZvaWQgZmltZF93aW5f ZGlzYWJsZShzdHJ1Y3QgZXh5bm9zX2RybV9tYW5hZ2VyICptZ3IsIGludCB6cG9zKQo+ICAJLyog cHJvdGVjdCB3aW5kb3dzICovCj4gIAlmaW1kX3NoYWRvd19wcm90ZWN0X3dpbihjdHgsIHdpbiwg dHJ1ZSk7Cj4gIAo+IC0JLyogd2luY29uICovCj4gLQl2YWwgPSByZWFkbChjdHgtPnJlZ3MgKyBX SU5DT04od2luKSk7Cj4gLQl2YWwgJj0gfldJTkNPTnhfRU5XSU47Cj4gLQl3cml0ZWwodmFsLCBj dHgtPnJlZ3MgKyBXSU5DT04od2luKSk7Cj4gLQo+IC0JLyogdW5wcm90ZWN0IHdpbmRvd3MgKi8K PiAtCWlmIChjdHgtPmRyaXZlcl9kYXRhLT5oYXNfc2hhZG93Y29uKSB7Cj4gLQkJdmFsID0gcmVh ZGwoY3R4LT5yZWdzICsgU0hBRE9XQ09OKTsKPiAtCQl2YWwgJj0gflNIQURPV0NPTl9DSHhfRU5B QkxFKHdpbik7Cj4gLQkJd3JpdGVsKHZhbCwgY3R4LT5yZWdzICsgU0hBRE9XQ09OKTsKPiAtCX0K PiArCWZpbWRfY2hhbm5lbF93aW4oY3R4LCB3aW4sIGZhbHNlKTsKPiAgCj4gIAlmaW1kX3NoYWRv d19wcm90ZWN0X3dpbihjdHgsIHdpbiwgZmFsc2UpOwo+ICAKPiAKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==