From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable Date: Thu, 13 Nov 2014 15:14:22 +0100 Message-ID: <5464BCBE.1090001@samsung.com> References: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> <546470BC.4020104@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <546470BC.4020104@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae Cc: Kukjin Kim , Seung-Woo Kim , open list , "open list:DRM DRIVERS FOR E..." , Kyungmin Park , "moderated list:ARM/S5P EXYNOS AR..." , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gMTEvMTMvMjAxNCAwOTo1MCBBTSwgSW5raSBEYWUgd3JvdGU6Cj4gT24gMjAxNOuFhCAxMOyb lCAwN+ydvCAyMTowMSwgQW5kcnplaiBIYWpkYSB3cm90ZToKPj4gSGkgSW5raSwKPj4KPj4gTWFu eSBFeHlub3MgRFJNIGRyaXZlcnMgdXNlcyBnbG9iYWwgdmFyaWFibGVzIHRvIHJlcHJlc2VudCBh c3NvY2lhdGVkIGRldmljZXMKPj4gaW4gRXh5bm9zIERSTSBpbnRlcm5hbCBmcmFtZXdvcmsuIEl0 IGlzIHF1aXRlIGNvbmZ1c2luZywgaXQgYWRkcyBkYXRhIGR1cGxpY2F0aW9uCj4+IGFuZCBmaW5h bGx5IGl0IGRvZXMgbm90IGFsbG93IHRvIGhhbmRsZSBtb3JlIHRoYW4gb25lIGRldmljZSBpbiBz eXN0ZW0uCj4+IEl0IHNlZW1zIGJldHRlciB0byBlbWJlZCBzdWNoIHN0cnVjdHVyZXMgaW4gcHJp dmF0ZSBjb250ZXh0IG9mIHRoZSBkZXZpY2UuCj4+Cj4+IFRoZSBwYXRjaHNldCBpcyBiYXNlZCBv biBleHlub3NfZHJtX25leHQgcGx1cyBteSBwYXRjaCBbMV06Cj4+ICdkcm0vZXh5bm9zOiByZW1v dmUgZXhwbGljaXQgZW5jb2Rlci9jb25uZWN0b3IgZGUtaW5pdGlhbGl6YXRpb24nLgo+Pgo+PiBJ ZiB0aGUgcGF0Y2hzZXQgaXMgT0sgZm9yIHlvdSBJIGNhbiBwcmVwYXJlIHNpbWlsYXIgcGF0Y2hl cyBmb3Igb3RoZXIgRXh5bm9zIERSTSBjb21wb25lbnRzLgo+IFNvcnJ5IGZvciBsYXRlLiBBcHBs aWVkLiBDYW4geW91IHByZXBhcmUgc2ltaWxhciBwYXRjaGVzIGZvciBvdGhlcj8gSWYKPiBzbywg SSdkIGhhcHB5LgoKQmVnaW5uaW5nIG9mIHRoZSBuZXh0IHdlZWsgaXMgT0s/CgpSZWdhcmRzCkFu ZHJ6ZWoKCj4KPiBUaGFua3MsCj4gSW5raSBEYWUKPgo+PiBbMV06IGh0dHBzOi8vbGttbC5vcmcv bGttbC8yMDE0LzkvMjIvMTQ4Cj4+Cj4+IFJlZ2FyZHMKPj4gQW5kcnplago+Pgo+Pgo+PiBBbmRy emVqIEhhamRhICg0KToKPj4gICBkcm0vZXh5bm9zL2RzaTogcmVtb3ZlIGdsb2JhbCB2YXJpYWJs ZSBleHlub3NfZHNpX2Rpc3BsYXkKPj4gICBkcm0vZXh5bm9zL2RzaTogc2ltcGxpZnkgZGV2aWNl IHBvaW50ZXIgZXZhbHVhdGlvbgo+PiAgIGRybS9leHlub3MvZHNpOiByZW1vdmUgcmVkdW5kYW50 IGVuY29kZXIgZmllbGQKPj4gICBkcm0vZXh5bm9zL2RzaTogc3RvcCB1c2luZyBkaXNwbGF5LT5j dHggcG9pbnRlcgo+Pgo+PiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2RzaS5j IHwgOTYgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdl ZCwgNDcgaW5zZXJ0aW9ucygrKSwgNDkgZGVsZXRpb25zKC0pCj4+Cj4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933147AbaKMOO2 (ORCPT ); Thu, 13 Nov 2014 09:14:28 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:10408 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933055AbaKMOO0 (ORCPT ); Thu, 13 Nov 2014 09:14:26 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f4-b7f6c6d00000120b-12-5464bcbf1553 Content-transfer-encoding: 8BIT Message-id: <5464BCBE.1090001@samsung.com> Date: Thu, 13 Nov 2014 15:14:22 +0100 From: Andrzej Hajda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 To: Inki Dae Cc: Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , "open list:DRM DRIVERS FOR E..." , "moderated list:ARM/S5P EXYNOS AR..." , open list Subject: Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable References: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> <546470BC.4020104@samsung.com> In-reply-to: <546470BC.4020104@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFLMWRmVeSWpSXmKPExsVy+t/xq7r796SEGCz4aGhx5et7NotJ9yew WLy4d5HFonfBVTaLs01v2C0u75rDZjHj/D4mi7VH7rJbzJj8ks2B0+N+93Emj74tqxg9Pm+S C2CO4rJJSc3JLEst0rdL4Mr4//4nU8Furoo53TtYGhj3cHQxcnJICJhI9O/uY4WwxSQu3FvP 1sXIxSEksJRRoufsNjaQBK+AoMSPyfdYuhg5OJgF5CWOXMqGMNUlpkzJhSj/xCjRfG0tM0ic V0BL4uQaQ5BOFgFViY7bi8HGswloSvzdfBNsoqhAhMSVNXMYQWwRAWWJVfva2UHmMAtMZZa4 sKiHBSQhLOAu8Wj1GjBbSCBFYu68mWCDOAW0Jebv3cU2gVFgFpLrZiFcNwvhugWMzKsYRVNL kwuKk9JzDfWKE3OLS/PS9ZLzczcxQsL7yw7GxcesDjEKcDAq8fB+4E4JEWJNLCuuzD3EKMHB rCTC+2YlUIg3JbGyKrUoP76oNCe1+BAjEwenVAOjzpwHr36ILFDmLz/x60F5YYTzp196MZF3 Jmm+11sQ9nqL455aj1XNqcsSD++2f6hR6KCUPlNT7uTU54E3tneuT+i97b6jXyPh0LJzmQFc 6Re1vTtcva+lsPvdj1EUfjTp7pa/8q8yXK849KRsWBHr97BNfEnagb7L/4KZ73E1rus9EJx+ 3/SfEktxRqKhFnNRcSIAEyk88k0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2014 09:50 AM, Inki Dae wrote: > On 2014년 10월 07일 21:01, Andrzej Hajda wrote: >> Hi Inki, >> >> Many Exynos DRM drivers uses global variables to represent associated devices >> in Exynos DRM internal framework. It is quite confusing, it adds data duplication >> and finally it does not allow to handle more than one device in system. >> It seems better to embed such structures in private context of the device. >> >> The patchset is based on exynos_drm_next plus my patch [1]: >> 'drm/exynos: remove explicit encoder/connector de-initialization'. >> >> If the patchset is OK for you I can prepare similar patches for other Exynos DRM components. > Sorry for late. Applied. Can you prepare similar patches for other? If > so, I'd happy. Beginning of the next week is OK? Regards Andrzej > > Thanks, > Inki Dae > >> [1]: https://lkml.org/lkml/2014/9/22/148 >> >> Regards >> Andrzej >> >> >> Andrzej Hajda (4): >> drm/exynos/dsi: remove global variable exynos_dsi_display >> drm/exynos/dsi: simplify device pointer evaluation >> drm/exynos/dsi: remove redundant encoder field >> drm/exynos/dsi: stop using display->ctx pointer >> >> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 96 ++++++++++++++++----------------- >> 1 file changed, 47 insertions(+), 49 deletions(-) >> >