Re: [lm-sensors] Fancontrol memory consumption

[Taz <rastataz@gmail.com>]

(sorry I just saw my reply still was in my drafts, don't know why...)

Indeed : my current bash version is 4.3.11
Although I don't have line 585 in my fancontrol script
I can apply the the patch (lines 497 & 536 for fancontrol v0.7)

I also gave it a try without the wait lines and not sending to 
background the previous
sleep command the wait was waiting for anyway (useless ?)

=> Mem consumption seems to be the same in all cases, we'll see in the 
long run...

Thanks !

     Cédric L.M.

Le 07/11/2014 10:15, Jean Delvare a écrit :
> On Wed, 5 Nov 2014 17:57:29 +0100, Jean Delvare wrote:
>> As I can reproduce the issue, I tried it myself, and my results are as
>> follows:
>> bash 3.0.16: Memory consumption (RSS) is steady
>> bash 3.1.14: Memory consumption (RSS) increases
>> bash 4.2.53: Memory consumption (RSS) increases
>> bash 4.3.30: Memory consumption (RSS) increases
>>
>> So apparently this is a regression introduced in bash 3.1 and not fixed
>> yet.
> I have created a ticket to track this issue:
>
> http://www.lm-sensors.org/ticket/2391
>
> After discussing the issue with upstream bash maintainer Chet Ramey,
> this is not a memory leak and works as intended, even though this
> behavior is undesirable in the case of the fancontrol script.
>
> Taz, feel free to try the following experimental patch for the time
> being, I believe it should solve the increasing memory consumption
> issue:
>
> ---
>   prog/pwm/fancontrol |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- lm-sensors.orig/prog/pwm/fancontrol	2014-11-05 22:59:21.823226428 +0100
> +++ lm-sensors/prog/pwm/fancontrol	2014-11-07 09:52:14.178257104 +0100
> @@ -546,7 +546,7 @@ function UpdateFanSpeeds
>   		  	echo $minsa > $pwmo
>   			# Sleep while still handling signals
>   			sleep 1 &
> -			wait $!
> +			wait
>   		  fi
>   		fi
>   		echo $pwmval > $pwmo # write new value to pwm output
> @@ -585,5 +585,5 @@ do
>   	UpdateFanSpeeds
>   	# Sleep while still handling signals
>   	sleep $INTERVAL &
> -	wait $!
> +	wait
>   done
>
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors