diff for duplicates of <5464CE41.2090601@sr71.net> diff --git a/a/1.txt b/N1/1.txt index 266644e..bf8abb1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -21,7 +21,7 @@ On 11/13/2014 06:55 AM, Thomas Gleixner wrote: >> + pagefault_enable(); >> + if (!ret) >> + break; ->> + if (ret = -EFAULT) +>> + if (ret == -EFAULT) >> + ret = mpx_resolve_fault(bd_entry, need_write); >> + /* >> + * If we could not resolve the fault, consider it @@ -60,7 +60,7 @@ I've gone and audited the call sites and cleaned this up a bit. >> + unsigned long start, unsigned long end) > >> + ret = unmap_edge_bts(mm, start, end); ->> + if (ret = -EFAULT) +>> + if (ret == -EFAULT) >> + return ret; > > So here you ignore EINVAL despite claiming that it will cause a diff --git a/a/content_digest b/N1/content_digest index 06ceafa..5b6a88d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0alpine.DEB.2.11.1411131541520.3935@nanos\0" "From\0Dave Hansen <dave@sr71.net>\0" "Subject\0Re: [PATCH 10/11] x86, mpx: cleanup unused bound tables\0" - "Date\0Thu, 13 Nov 2014 15:29:05 +0000\0" + "Date\0Thu, 13 Nov 2014 07:29:05 -0800\0" "To\0Thomas Gleixner <tglx@linutronix.de>\0" "Cc\0hpa@zytor.com" mingo@redhat.com @@ -39,7 +39,7 @@ ">> +\t\tpagefault_enable();\n" ">> +\t\tif (!ret)\n" ">> +\t\t\tbreak;\n" - ">> +\t\tif (ret = -EFAULT)\n" + ">> +\t\tif (ret == -EFAULT)\n" ">> +\t\t\tret = mpx_resolve_fault(bd_entry, need_write);\n" ">> +\t\t/*\n" ">> +\t\t * If we could not resolve the fault, consider it\n" @@ -78,7 +78,7 @@ ">> +\t\tunsigned long start, unsigned long end)\n" "> \n" ">> +\tret = unmap_edge_bts(mm, start, end);\n" - ">> +\tif (ret = -EFAULT)\n" + ">> +\tif (ret == -EFAULT)\n" ">> +\t\treturn ret;\n" "> \n" "> So here you ignore EINVAL despite claiming that it will cause a\n" @@ -107,4 +107,4 @@ "should just SIGSEGV and not attempt to keep unmapping things. I've\n" updated the patch. -bf72f1fb53c75f0ee793043c250080b55d635568b02a3579044ab67c1ce38646 +9523eb10223d190e6de6e5dbd2c12ec1a83eb9f6b0a65776ce5d18a9d2349d64
diff --git a/a/1.txt b/N2/1.txt index 266644e..b10e624 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -21,7 +21,7 @@ On 11/13/2014 06:55 AM, Thomas Gleixner wrote: >> + pagefault_enable(); >> + if (!ret) >> + break; ->> + if (ret = -EFAULT) +>> + if (ret == -EFAULT) >> + ret = mpx_resolve_fault(bd_entry, need_write); >> + /* >> + * If we could not resolve the fault, consider it @@ -60,7 +60,7 @@ I've gone and audited the call sites and cleaned this up a bit. >> + unsigned long start, unsigned long end) > >> + ret = unmap_edge_bts(mm, start, end); ->> + if (ret = -EFAULT) +>> + if (ret == -EFAULT) >> + return ret; > > So here you ignore EINVAL despite claiming that it will cause a @@ -88,3 +88,9 @@ the middle of a large unmap we should attempt to complete the unmap. But, I've changed my mind. If we have any kind of validity issue, we should just SIGSEGV and not attempt to keep unmapping things. I've updated the patch. + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index 06ceafa..5a4e12a 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\0alpine.DEB.2.11.1411131541520.3935@nanos\0" "From\0Dave Hansen <dave@sr71.net>\0" "Subject\0Re: [PATCH 10/11] x86, mpx: cleanup unused bound tables\0" - "Date\0Thu, 13 Nov 2014 15:29:05 +0000\0" + "Date\0Thu, 13 Nov 2014 07:29:05 -0800\0" "To\0Thomas Gleixner <tglx@linutronix.de>\0" "Cc\0hpa@zytor.com" mingo@redhat.com @@ -39,7 +39,7 @@ ">> +\t\tpagefault_enable();\n" ">> +\t\tif (!ret)\n" ">> +\t\t\tbreak;\n" - ">> +\t\tif (ret = -EFAULT)\n" + ">> +\t\tif (ret == -EFAULT)\n" ">> +\t\t\tret = mpx_resolve_fault(bd_entry, need_write);\n" ">> +\t\t/*\n" ">> +\t\t * If we could not resolve the fault, consider it\n" @@ -78,7 +78,7 @@ ">> +\t\tunsigned long start, unsigned long end)\n" "> \n" ">> +\tret = unmap_edge_bts(mm, start, end);\n" - ">> +\tif (ret = -EFAULT)\n" + ">> +\tif (ret == -EFAULT)\n" ">> +\t\treturn ret;\n" "> \n" "> So here you ignore EINVAL despite claiming that it will cause a\n" @@ -105,6 +105,12 @@ "the middle of a large unmap we should attempt to complete the unmap.\n" "But, I've changed my mind. If we have any kind of validity issue, we\n" "should just SIGSEGV and not attempt to keep unmapping things. I've\n" - updated the patch. + "updated the patch.\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -bf72f1fb53c75f0ee793043c250080b55d635568b02a3579044ab67c1ce38646 +b7beb67e71ba096c0382777a60f39d4e06861930fd24168ddaa445b00ade38ca
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.