From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: XenServer results from the Test Day for RC2
Date: Thu, 13 Nov 2014 16:02:47 +0000
Message-ID: <5464D627.7060104@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Wilk <konrad.wilk@oracle.com>
Cc: Xen-devel List <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Hi,

While attempting to test Konrads new interrupt injection logic, I got
blocked behind yet another Pygrub bug caused by c/s d1b93ea

This is the first time I have looked into the issue, but a cursory
inspection of the first hunk shows that it cannot possibly be correct as
self._default is either an integer or string.

I have a possible workaround which I am testing, but cursory review of
the patch would have shown that it cannot work as intended.

Notice that self._default is now either a string or an integer,
defaulting to an integer, and the top level code is updated to require a
string.  As a result, any bootloader configuration which doesn't
explicitly set a default, or still drives this logic with integers
(ExtLinux or LiLO) will die with an AttributeError

~Andrew