From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Update github helper URL.
Date: Thu, 13 Nov 2014 21:05:56 +0100 [thread overview]
Message-ID: <54650F24.60707@mind.be> (raw)
In-Reply-To: <54650D55.9060107@mind.be>
On 13/11/14 20:58, Arnout Vandecappelle wrote:
> On 13/11/14 20:48, Patrick Williams wrote:
>> Github changed the URL syntax from 'archive' back to 'tarball'.
>>
>> Signed-off-by: Patrick Williams <iawillia@us.ibm.com>
>> ---
>> package/pkg-download.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
>> index 4cfb913..03907f1 100644
>> --- a/package/pkg-download.mk
>> +++ b/package/pkg-download.mk
>> @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c
>> domainseparator=$(if $(1),$(1),/)
>>
>> # github(user,package,version): returns site of GitHub repository
>> -github = https://github.com/$(1)/$(2)/archive/$(3)
>> +github = https://github.com/$(1)/$(2)/tarball/$(3)
>>
>> ################################################################################
>> # The DOWNLOAD_* helpers are in charge of getting a working copy
>>
>
> Yep, that seems to work! So Yann, stop working :-)
>
> I haven't tested if it's exactly the same tarball. It redirects to a URL
> containing legacy.tar.gz instead of tar.gz, so who knows...
Checked with a few tarballs, and it seems they only differ in the basename:
legacy (i.e., this patch):
zeromq-cppzmq-1f05e0d/
current (i.e., archive/version.tar.gz):
cppzmq-1f05e0d111197c64be32ad5aecd59f4d1b05a819/
So the legacy really looks better :-)
Therefore:
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-11-13 20:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 19:48 [Buildroot] [PATCH] Update github helper URL Patrick Williams
2014-11-13 19:58 ` Arnout Vandecappelle
2014-11-13 20:05 ` Arnout Vandecappelle [this message]
2014-11-13 20:06 ` Thomas De Schampheleire
2014-11-13 20:15 ` Arnout Vandecappelle
2014-11-13 20:20 ` Samuel Martin
2014-11-13 20:22 ` Yann E. MORIN
2014-11-14 15:13 ` Peter Korsgaard
2014-11-14 15:25 ` Samuel Martin
2014-11-14 17:51 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54650F24.60707@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.