All of lore.kernel.org
 help / color / mirror / Atom feed
From: Murali Karicheri <m-karicheri2@ti.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jingoo Han <jg1.han@samsung.com>, <linux-pci@vger.kernel.org>,
	"'Santosh Shilimkar'" <ssantosh@kernel.org>
Subject: Re: [PATCH] PCI: keystone: Remove unnecessary OOM message
Date: Thu, 13 Nov 2014 18:18:26 -0500	[thread overview]
Message-ID: <54653C42.7050405@ti.com> (raw)
In-Reply-To: <20141113174756.GL5064@google.com>

On 11/13/2014 12:47 PM, Bjorn Helgaas wrote:
> On Wed, Nov 12, 2014 at 12:22:56PM +0900, Jingoo Han wrote:
>> The site-specific OOM messages are unnecessary, because they
>> duplicate the MM subsystem generic OOM message. This patch
>> fixes the following checkpatch warning.
>>
>>    WARNING: Possible unnecessary 'out of memory' message
>>
>> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> Applied to pci/host-keystone for v3.19, thanks!
>
> Murali, let me know if you object.  I'm trying to clear the easy stuff out
> of my queue.
I think this checkpatch warning is due to recent update to checkpatch.pl 
script. Looks good to apply.  Thanks

Murali
>> ---
>>   drivers/pci/host/pci-keystone.c |    5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
>> index 1b893bc..62b9454 100644
>> --- a/drivers/pci/host/pci-keystone.c
>> +++ b/drivers/pci/host/pci-keystone.c
>> @@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
>>
>>   	ks_pcie = devm_kzalloc(&pdev->dev, sizeof(*ks_pcie),
>>   				GFP_KERNEL);
>> -	if (!ks_pcie) {
>> -		dev_err(dev, "no memory for keystone pcie\n");
>> +	if (!ks_pcie)
>>   		return -ENOMEM;
>> -	}
>> +
>>   	pp =&ks_pcie->pp;
>>
>>   	/* initialize SerDes Phy if present */
>> -- 
>> 1.7.9.5
>>
>>


-- 
Murali Karicheri
Linux Kernel, Texas Instruments


      reply	other threads:[~2014-11-13 23:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12  3:22 [PATCH] PCI: keystone: Remove unnecessary OOM message Jingoo Han
2014-11-13 17:47 ` Bjorn Helgaas
2014-11-13 23:18   ` Murali Karicheri [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54653C42.7050405@ti.com \
    --to=m-karicheri2@ti.com \
    --cc=bhelgaas@google.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.