From: Leon Alrae <leon.alrae@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too
Date: Fri, 14 Nov 2014 09:24:18 +0000 [thread overview]
Message-ID: <5465CA42.1070305@imgtec.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1411031848030.2881@tp.orcam.me.uk>
On 03/11/2014 18:51, Maciej W. Rozycki wrote:
> CP1.FIR is read-only in hardware so gdbstub must respect it. We already
> respect it for CTC1 instructions, so do it here too.
>
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
> Not much to say about it here. Please apply.
>
> Maciej
>
> qemu-mips-fir.diff
> Index: qemu-git-trunk/target-mips/gdbstub.c
> ===================================================================
> --- qemu-git-trunk.orig/target-mips/gdbstub.c 2014-11-02 17:51:33.458968203 +0000
> +++ qemu-git-trunk/target-mips/gdbstub.c 2014-11-02 17:51:35.958924223 +0000
> @@ -112,7 +112,7 @@ int mips_cpu_gdb_write_register(CPUState
> RESTORE_ROUNDING_MODE;
> break;
> case 71:
> - env->active_fpu.fcr0 = tmp;
> + /* FIR is read-only. Ignore writes. */
> break;
> }
> return sizeof(target_ulong);
>
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
prev parent reply other threads:[~2014-11-14 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 18:51 [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too Maciej W. Rozycki
2014-11-14 9:24 ` Leon Alrae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5465CA42.1070305@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=macro@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.