From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver Date: Fri, 14 Nov 2014 18:53:00 +0800 Message-ID: <5465DF0C.50301@rock-chips.com> References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935631-16826-1-git-send-email-andy.yan@rock-chips.com> <5465D73C.9030507@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5465D73C.9030507@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach List-Id: devicetree@vger.kernel.org SGkgWnViYWlyTEs6CiAgICBUaGFua3MgZm9yIHlvdXIgcmV2aWV3LgpPbiAyMDE05bm0MTHmnIgx NOaXpSAxODoxOSwgWnViYWlyIEx1dGZ1bGxhaCBLYWtha2hlbCB3cm90ZToKPiBIaSBBbmR5LAo+ Cj4gTmljZSB3b3JrIG9uIHRoaXMgcGF0Y2ggc2VyaWVzLiBJdHMgZ2V0dGluZyBiZXR0ZXIgYW5k IGJldHRlciA6KS4KPgo+IE9uIDE0LzExLzE0IDAzOjI3LCBBbmR5IFlhbiB3cm90ZToKPj4gaGRt aSBwaHkgY2xvY2sgc3ltYm9sIGFuZCB0cmFuc21pc3Npb24gdGVybWluYXRpb24gdmFsdWUKPj4g Y2FuIGFkanVzdCBwbGF0Zm9ybSBzcGVjaWZpYyB0byBnZXQgdGhlIGJlc3QgU0kKPiAJCQkJCQle SXMgdGhpcyBzaWduYWwgaW50ZWdyaXR5PwogICAgeWVzICwgU0kgIGlzIHNpZ25hbCBpbnRlZ3Jp dHksIHN1Y2ggYXMgZXllIGRpYWdyYW0gbWVhc3VyZW1lbnQKPgo+IEFyZSB0aGVzZSB0d28gZGlz am9pbnQgZmVhdHVyZXMgaW4gc2VwYXJhdGUgcGF0Y2hlcz8KPgo+PiBhbHNvIGFkZCBtb2RlX3Zh bGlkIGludGVyZmFjZSBmb3Igc29tZSBwbGF0Zm9ybSBtYXkgbm90IHN1cHBvcnQKPj4gYWxsIHRo ZSBkaXNwbGF5IG1vZGUKPiBTb3VuZHMgbGlrZSBhbm90aGVyIHNlcGFyYXRlIHBhdGNoIHRvIG1l LiA6KQogICAgdGhleSBjYW4gc2VwZXJhdGUKPgo+IEFsc28sIFRoaXMgc2VyaWVzIGlzIGJlY29t aW5nIHF1aXRlIGxhcmdlLiBXaXRoIG1ham9yIGNoYW5nZXMgYW5kIGZpeGVzIG1peGVkIHRvZ2V0 aGVyLgo+Cj4gUGF0Y2ggMyBzcGxpdHMgaW14LWRybS4KPiBQYXRjaCA0IG1vdmVzIGR3LWRybSBv dXQgb2YgaW14LWRybSBmb2xkZXIuCj4gUGF0Y2ggNyBhZGRzIGJpbmRpbmcKPiBQYXRjaCA5IGNv bnZlcnRzIHRvIGRybSBicmlkZ2UuCj4KPiBDYW4gdGhlc2UgYmUgcGxhY2VkIHRvZ2V0aGVyIGVh c2lseT8KPiBBbmQgaW4gdGhlIHN0YXJ0LiBpLmUuIHBhdGNoIDEsIDIsIDMsIDQsCj4KPiBUaGVu IGFsbCBmaXhlcyBldGMgY2FuIGNvbWUgYWZ0ZXJ3YXJkcz8KPgo+IEl0IGhlbHBzIHdoZW4gY2hl Y2tpbmcgaGlzdG9yaWVzIGxhdGVyIGFzIHRvIGhvdyBhIGRyaXZlciB3YXMgbWFkZSBhbmQgaG93 IGZpeGVzIGhhcHBlbmVkLgo+Cj4gRXNwZWNpYWxseSB3aGVuIGZpbGUgbW92ZXMgaGFwcGVuLi4K ICAgRG8geW91IG1lYW4gd2UgY2FuIHJlYXJyYW5nZSB0aGUgcGF0Y2ggc2VyaWVzPwogICBwdXQg cGF0Y2ggMywgNCAsNywgOSB0b2dldGhlciAgb25lIGJ5ZSBvbmUKICAgdGhhbiBmb2xsb3dlZCBi eSB0aGUgZml4ZXMgcGF0Y2hlcyAgNSAsNiwgOCwgMTEgPwo+Cj4gQ2hlZXJzLAo+IFp1YmFpckxL Cj4KPj4gU2lnbmVkLW9mZi1ieTogQW5keSBZYW4gPGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgo+ Pgo+PiAtLS0KPj4KPj4gQ2hhbmdlcyBpbiB2MTA6Cj4+IC0gc3BsaXQgZ2VuZXJpYyBkd19oZG1p LmMgaW1wcm92ZW1lbnRzIGZyb20gcGF0Y2gjMTEgKGFkZCByazMyODggc3VwcG9ydCkKPj4KPj4g Q2hhbmdlcyBpbiB2OTogTm9uZQo+PiBDaGFuZ2VzIGluIHY4OiBOb25lCj4+IENoYW5nZXMgaW4g djc6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2NjogTm9uZQo+PiBDaGFuZ2VzIGluIHY1OiBOb25lCj4+ IENoYW5nZXMgaW4gdjQ6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2MzogTm9uZQo+PiBDaGFuZ2VzIGlu IHYyOiBOb25lCj4+Cj4+ICAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9kd19oZG1pLmMgICAgICB8 IDI5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4+ICAgZHJpdmVycy9zdGFnaW5nL2lt eC1kcm0vZHdfaGRtaS1pbXguYyB8IDEwICsrKysrKysrKy0KPj4gICBpbmNsdWRlL2RybS9icmlk Z2UvZHdfaGRtaS5oICAgICAgICAgIHwgIDcgKysrKysrKwo+PiAgIDMgZmlsZXMgY2hhbmdlZCwg NDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPj4KPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlz dAo+IExpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCj4KPgo+CgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBs aXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRy aXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965322AbaKNKxR (ORCPT ); Fri, 14 Nov 2014 05:53:17 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:54828 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965238AbaKNKxN (ORCPT ); Fri, 14 Nov 2014 05:53:13 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <86d64fe61f6d7613653ed283e5b0ef45> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5465DF0C.50301@rock-chips.com> Date: Fri, 14 Nov 2014 18:53:00 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach Subject: Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935631-16826-1-git-send-email-andy.yan@rock-chips.com> <5465D73C.9030507@imgtec.com> In-Reply-To: <5465D73C.9030507@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ZubairLK: Thanks for your review. On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote: > Hi Andy, > > Nice work on this patch series. Its getting better and better :). > > On 14/11/14 03:27, Andy Yan wrote: >> hdmi phy clock symbol and transmission termination value >> can adjust platform specific to get the best SI > ^Is this signal integrity? yes , SI is signal integrity, such as eye diagram measurement > > Are these two disjoint features in separate patches? > >> also add mode_valid interface for some platform may not support >> all the display mode > Sounds like another separate patch to me. :) they can seperate > > Also, This series is becoming quite large. With major changes and fixes mixed together. > > Patch 3 splits imx-drm. > Patch 4 moves dw-drm out of imx-drm folder. > Patch 7 adds binding > Patch 9 converts to drm bridge. > > Can these be placed together easily? > And in the start. i.e. patch 1, 2, 3, 4, > > Then all fixes etc can come afterwards? > > It helps when checking histories later as to how a driver was made and how fixes happened. > > Especially when file moves happen.. Do you mean we can rearrange the patch series? put patch 3, 4 ,7, 9 together one bye one than followed by the fixes patches 5 ,6, 8, 11 ? > > Cheers, > ZubairLK > >> Signed-off-by: Andy Yan >> >> --- >> >> Changes in v10: >> - split generic dw_hdmi.c improvements from patch#11 (add rk3288 support) >> >> Changes in v9: None >> Changes in v8: None >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> drivers/gpu/drm/bridge/dw_hdmi.c | 29 +++++++++++++++++++++++++++-- >> drivers/staging/imx-drm/dw_hdmi-imx.c | 10 +++++++++- >> include/drm/bridge/dw_hdmi.h | 7 +++++++ >> 3 files changed, 43 insertions(+), 3 deletions(-) >> > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >