From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zubair Lutfullah Kakakhel Subject: Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support Date: Fri, 14 Nov 2014 10:53:40 +0000 Message-ID: <5465DF34.303@imgtec.com> References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935884-17130-1-git-send-email-andy.yan@rock-chips.com> <5465D816.3020708@imgtec.com> <5465DB4F.7090402@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5465DB4F.7090402@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Andy Yan , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach List-Id: devicetree@vger.kernel.org CgpPbiAxNC8xMS8xNCAxMDozNywgQW5keSBZYW4gd3JvdGU6Cj4gCj4gT24gMjAxNOW5tDEx5pyI MTTml6UgMTg6MjMsIFp1YmFpciBMdXRmdWxsYWggS2FrYWtoZWwgd3JvdGU6Cj4+IEhpIEFuZHkK Pj4KPj4gT24gMTQvMTEvMTQgMDM6MzEsIEFuZHkgWWFuIHdyb3RlOgo+Pj4gUm9ja2NoaXAgUksz Mjg4IGhkbWkgaXMgY29tcGF0aWJsZSB3aXRoIGR3X2hkbWkKPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5 OiBBbmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5jb20+Cj4+Pgo+Pj4gLS0tCj4+Pgo+Pj4g Q2hhbmdlcyBpbiB2MTA6Cj4+PiAtIGFkZCBtb3JlIGRpc3BsYXkgbW9kZSBzdXBwb3J0IG1wbGwg Y29uZmlndXJhdGlvbiBmb3IgcmszMjg4Cj4+Pgo+Pj4gQ2hhbmdlcyBpbiB2OToKPj4+IC0gbW92 ZSBzb21lIHBoeSBjb25maWd1cmF0aW9uIHRvIHBsYXRmb3JtIGRyaXZlcgo+Pj4KPj4+IENoYW5n ZXMgaW4gdjg6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjc6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjY6 IE5vbmUKPj4+IENoYW5nZXMgaW4gdjU6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjQ6IE5vbmUKPj4+ IENoYW5nZXMgaW4gdjM6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjI6IE5vbmUKPj4+Cj4+PiAgIGRy aXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jICAgICAgICAgICAgfCAgMTAgKwo+Pj4gICBk cml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3X2hkbWkuaCAgICAgICAgICAgIHwgICAzICstCj4+PiAg IGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnICAgICAgICAgICAgfCAgMTAgKwo+Pj4g ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvTWFrZWZpbGUgICAgICAgICAgIHwgICAyICstCj4+ PiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kd19oZG1pLXJvY2tjaGlwLmMgfCAzNTUgKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+Pj4gICBpbmNsdWRlL2RybS9icmlkZ2UvZHdfaGRt aS5oICAgICAgICAgICAgICAgIHwgICAxICsKPj4+ICAgNiBmaWxlcyBjaGFuZ2VkLCAzNzkgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9kd19oZG1pLXJvY2tjaGlwLmMKPj4+Cj4+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9kd19oZG1pLmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL2R3X2hkbWkuYwo+Pj4gaW5kZXggYTI4NzZmZS4uMWRkMWYwYiAxMDA2NDQKPj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vYnJpZGdlL2R3X2hkbWkuYwo+Pj4gQEAgLTcxNSw2ICs3MTUsMTMgQEAgc3RhdGljIHZvaWQg ZHdfaGRtaV9waHlfZW5hYmxlX3RtZHMoc3RydWN0IGR3X2hkbWkgKmhkbWksIHU4IGVuYWJsZSkK Pj4+ICAgICAgICAgICAgICAgIEhETUlfUEhZX0NPTkYwX0VOVE1EU19NQVNLKTsKPj4+ICAgfQo+ Pj4gICArc3RhdGljIHZvaWQgZHdfaGRtaV9waHlfZW5hYmxlX3NwYXJlKHN0cnVjdCBkd19oZG1p ICpoZG1pLCB1OCBlbmFibGUpCj4+PiArewo+Pj4gKyAgICBoZG1pX21hc2tfd3JpdGViKGhkbWks IGVuYWJsZSwgSERNSV9QSFlfQ09ORjAsCj4+PiArICAgICAgICAgICAgIEhETUlfUEhZX0NPTkYw X1NQQVJFQ1RSTF9PRkZTRVQsCj4+PiArICAgICAgICAgICAgIEhETUlfUEhZX0NPTkYwX1NQQVJF Q1RSTF9NQVNLKTsKPj4+ICt9Cj4+PiArCj4+IFdoYXQgZG9lcyBlbmFibGUgc3BhcmUgZG8/IENh biBvdGhlciBmdXR1cmUgU29DcyB1c2UgaXQ/Cj4+Cj4+IFRoaXMgbG9va3MgbGlrZSBEVyBzcGVj aWZpYy4gQW5kIGNhbiBiZSBhIHNlcGFyYXRlIGNvbW1pdCB0aGF0IGFkZHMgYSBmZWF0dXJlIHRv IHRoZSBkdyBoZG1pIGRyaXZlci4KPiAgIEFjdHVhbGx5IEkgYW0gbm90IHZlcnkgY2xlYXJseSBh Ym91dCB0aGlzIGJpdCwgYnV0IFJLMzI4OCBIRE1JIHdpbGwgbm90IHdvcmsgd2l0aG91dCB0aGlz IGJpdCBlbmFibGUuCj4gICBPbiBpbXg2LCB0aGUgZGVzY3JpcHRpb24gYWJvdXQgdGhpcyBiaXQg aXM6UmVzZXJ2ZWQuIFNwYXJlIHBpbiBjb250cm9sLgo+ICAgT24gcmszMjg4LCB0aGUgZGVzY3Jp cHRpb24gaXM6IHN2c3JldC9zcGFyZWN0cmwKPiAgICBCb3RoIGFyZSB2ZXJ5IHNpbXBsZS4KClNv dW5kcyBsaWtlIHRoZSBJUCBDb3JlIGluIHRoZSByazMyODggaXMgc2xpZ2h0bHkgdXBncmFkZWQu ClNlcGFyYXRlIHRoaXMgc2VjdGlvbiBpbiBhIGRpZmZlcmVudCBjb21taXQgYXMgaXQgaXMgZ2Vu ZXJpYyBEVyBzdHVmZi4KCkFuZCBhZGQgd2hhdCB5b3Ugd3JvdGUgYWJvdmUgaW4gdGhlIGNvbW1p dCBtZXNzYWdlLgoKVGhhbmtzClp1YmFpckxLCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnBy b2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965355AbaKNKx7 (ORCPT ); Fri, 14 Nov 2014 05:53:59 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:34669 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965194AbaKNKx4 (ORCPT ); Fri, 14 Nov 2014 05:53:56 -0500 Message-ID: <5465DF34.303@imgtec.com> Date: Fri, 14 Nov 2014 10:53:40 +0000 From: Zubair Lutfullah Kakakhel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andy Yan , , , , CC: Mark Rutland , , , , Arnd Bergmann , , Grant Likely , Dave Airlie , , , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , , Josh Boyer , Greg Kroah-Hartman , , , Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach Subject: Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935884-17130-1-git-send-email-andy.yan@rock-chips.com> <5465D816.3020708@imgtec.com> <5465DB4F.7090402@rock-chips.com> In-Reply-To: <5465DB4F.7090402@rock-chips.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.154.89] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/14 10:37, Andy Yan wrote: > > On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: >> Hi Andy >> >> On 14/11/14 03:31, Andy Yan wrote: >>> Rockchip RK3288 hdmi is compatible with dw_hdmi >>> >>> Signed-off-by: Andy Yan >>> >>> --- >>> >>> Changes in v10: >>> - add more display mode support mpll configuration for rk3288 >>> >>> Changes in v9: >>> - move some phy configuration to platform driver >>> >>> Changes in v8: None >>> Changes in v7: None >>> Changes in v6: None >>> Changes in v5: None >>> Changes in v4: None >>> Changes in v3: None >>> Changes in v2: None >>> >>> drivers/gpu/drm/bridge/dw_hdmi.c | 10 + >>> drivers/gpu/drm/bridge/dw_hdmi.h | 3 +- >>> drivers/gpu/drm/rockchip/Kconfig | 10 + >>> drivers/gpu/drm/rockchip/Makefile | 2 +- >>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 355 ++++++++++++++++++++++++++++ >>> include/drm/bridge/dw_hdmi.h | 1 + >>> 6 files changed, 379 insertions(+), 2 deletions(-) >>> create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>> >>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >>> index a2876fe..1dd1f0b 100644 >>> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >>> @@ -715,6 +715,13 @@ static void dw_hdmi_phy_enable_tmds(struct dw_hdmi *hdmi, u8 enable) >>> HDMI_PHY_CONF0_ENTMDS_MASK); >>> } >>> +static void dw_hdmi_phy_enable_spare(struct dw_hdmi *hdmi, u8 enable) >>> +{ >>> + hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0, >>> + HDMI_PHY_CONF0_SPARECTRL_OFFSET, >>> + HDMI_PHY_CONF0_SPARECTRL_MASK); >>> +} >>> + >> What does enable spare do? Can other future SoCs use it? >> >> This looks like DW specific. And can be a separate commit that adds a feature to the dw hdmi driver. > Actually I am not very clearly about this bit, but RK3288 HDMI will not work without this bit enable. > On imx6, the description about this bit is:Reserved. Spare pin control. > On rk3288, the description is: svsret/sparectrl > Both are very simple. Sounds like the IP Core in the rk3288 is slightly upgraded. Separate this section in a different commit as it is generic DW stuff. And add what you wrote above in the commit message. Thanks ZubairLK