From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zubair Lutfullah Kakakhel Subject: Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver Date: Fri, 14 Nov 2014 10:55:46 +0000 Message-ID: <5465DFB2.8060601@imgtec.com> References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935631-16826-1-git-send-email-andy.yan@rock-chips.com> <5465D73C.9030507@imgtec.com> <5465DF0C.50301@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5465DF0C.50301@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Andy Yan , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach List-Id: devicetree@vger.kernel.org CgpPbiAxNC8xMS8xNCAxMDo1MywgQW5keSBZYW4gd3JvdGU6Cj4gSGkgWnViYWlyTEs6Cj4gICAg VGhhbmtzIGZvciB5b3VyIHJldmlldy4KPiBPbiAyMDE05bm0MTHmnIgxNOaXpSAxODoxOSwgWnVi YWlyIEx1dGZ1bGxhaCBLYWtha2hlbCB3cm90ZToKPj4gSGkgQW5keSwKPj4KPj4gTmljZSB3b3Jr IG9uIHRoaXMgcGF0Y2ggc2VyaWVzLiBJdHMgZ2V0dGluZyBiZXR0ZXIgYW5kIGJldHRlciA6KS4K Pj4KPj4gT24gMTQvMTEvMTQgMDM6MjcsIEFuZHkgWWFuIHdyb3RlOgo+Pj4gaGRtaSBwaHkgY2xv Y2sgc3ltYm9sIGFuZCB0cmFuc21pc3Npb24gdGVybWluYXRpb24gdmFsdWUKPj4+IGNhbiBhZGp1 c3QgcGxhdGZvcm0gc3BlY2lmaWMgdG8gZ2V0IHRoZSBiZXN0IFNJCj4+ICAgICAgICAgICAgICAg ICAgICAgICAgIF5JcyB0aGlzIHNpZ25hbCBpbnRlZ3JpdHk/Cj4gICAgeWVzICwgU0kgIGlzIHNp Z25hbCBpbnRlZ3JpdHksIHN1Y2ggYXMgZXllIGRpYWdyYW0gbWVhc3VyZW1lbnQKPj4KPj4gQXJl IHRoZXNlIHR3byBkaXNqb2ludCBmZWF0dXJlcyBpbiBzZXBhcmF0ZSBwYXRjaGVzPwo+Pgo+Pj4g YWxzbyBhZGQgbW9kZV92YWxpZCBpbnRlcmZhY2UgZm9yIHNvbWUgcGxhdGZvcm0gbWF5IG5vdCBz dXBwb3J0Cj4+PiBhbGwgdGhlIGRpc3BsYXkgbW9kZQo+PiBTb3VuZHMgbGlrZSBhbm90aGVyIHNl cGFyYXRlIHBhdGNoIHRvIG1lLiA6KQo+ICAgIHRoZXkgY2FuIHNlcGVyYXRlCj4+Cj4+IEFsc28s IFRoaXMgc2VyaWVzIGlzIGJlY29taW5nIHF1aXRlIGxhcmdlLiBXaXRoIG1ham9yIGNoYW5nZXMg YW5kIGZpeGVzIG1peGVkIHRvZ2V0aGVyLgo+Pgo+PiBQYXRjaCAzIHNwbGl0cyBpbXgtZHJtLgo+ PiBQYXRjaCA0IG1vdmVzIGR3LWRybSBvdXQgb2YgaW14LWRybSBmb2xkZXIuCj4+IFBhdGNoIDcg YWRkcyBiaW5kaW5nCj4+IFBhdGNoIDkgY29udmVydHMgdG8gZHJtIGJyaWRnZS4KPj4KPj4gQ2Fu IHRoZXNlIGJlIHBsYWNlZCB0b2dldGhlciBlYXNpbHk/Cj4+IEFuZCBpbiB0aGUgc3RhcnQuIGku ZS4gcGF0Y2ggMSwgMiwgMywgNCwKPj4KPj4gVGhlbiBhbGwgZml4ZXMgZXRjIGNhbiBjb21lIGFm dGVyd2FyZHM/Cj4+Cj4+IEl0IGhlbHBzIHdoZW4gY2hlY2tpbmcgaGlzdG9yaWVzIGxhdGVyIGFz IHRvIGhvdyBhIGRyaXZlciB3YXMgbWFkZSBhbmQgaG93IGZpeGVzIGhhcHBlbmVkLgo+Pgo+PiBF c3BlY2lhbGx5IHdoZW4gZmlsZSBtb3ZlcyBoYXBwZW4uLgo+ICAgRG8geW91IG1lYW4gd2UgY2Fu IHJlYXJyYW5nZSB0aGUgcGF0Y2ggc2VyaWVzPwo+ICAgcHV0IHBhdGNoIDMsIDQgLDcsIDkgdG9n ZXRoZXIgIG9uZSBieWUgb25lCj4gICB0aGFuIGZvbGxvd2VkIGJ5IHRoZSBmaXhlcyBwYXRjaGVz ICA1ICw2LCA4LCAxMSA/CgpZZXMuIFJlYXJyYW5nZSBzbyB0aGF0IHRoZSBzcGxpdCBpbXgtZHJt L2lteC1oZG1pIGFuZCBjb252ZXJzaW9uIHRvIGRybS1icmlkZ2UgaXMgYXQgdGhlIHN0YXJ0IG9m IHRoZSBzZXJpZXMuClRoZW4gdGhlIHJlc3QgYXJlIGJ1ZyBmaXhlcyBhbmQgZmVhdHVyZSBhZGRp dGlvbnMuCgpDaGVlcnMsClp1YmFpckxLCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2pl Y3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965389AbaKNK4E (ORCPT ); Fri, 14 Nov 2014 05:56:04 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:12743 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964995AbaKNK4C (ORCPT ); Fri, 14 Nov 2014 05:56:02 -0500 Message-ID: <5465DFB2.8060601@imgtec.com> Date: Fri, 14 Nov 2014 10:55:46 +0000 From: Zubair Lutfullah Kakakhel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andy Yan , , , , CC: Mark Rutland , , , , Arnd Bergmann , , Grant Likely , Dave Airlie , , , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , , Josh Boyer , Greg Kroah-Hartman , , , Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach Subject: Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935631-16826-1-git-send-email-andy.yan@rock-chips.com> <5465D73C.9030507@imgtec.com> <5465DF0C.50301@rock-chips.com> In-Reply-To: <5465DF0C.50301@rock-chips.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.154.89] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/14 10:53, Andy Yan wrote: > Hi ZubairLK: > Thanks for your review. > On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote: >> Hi Andy, >> >> Nice work on this patch series. Its getting better and better :). >> >> On 14/11/14 03:27, Andy Yan wrote: >>> hdmi phy clock symbol and transmission termination value >>> can adjust platform specific to get the best SI >> ^Is this signal integrity? > yes , SI is signal integrity, such as eye diagram measurement >> >> Are these two disjoint features in separate patches? >> >>> also add mode_valid interface for some platform may not support >>> all the display mode >> Sounds like another separate patch to me. :) > they can seperate >> >> Also, This series is becoming quite large. With major changes and fixes mixed together. >> >> Patch 3 splits imx-drm. >> Patch 4 moves dw-drm out of imx-drm folder. >> Patch 7 adds binding >> Patch 9 converts to drm bridge. >> >> Can these be placed together easily? >> And in the start. i.e. patch 1, 2, 3, 4, >> >> Then all fixes etc can come afterwards? >> >> It helps when checking histories later as to how a driver was made and how fixes happened. >> >> Especially when file moves happen.. > Do you mean we can rearrange the patch series? > put patch 3, 4 ,7, 9 together one bye one > than followed by the fixes patches 5 ,6, 8, 11 ? Yes. Rearrange so that the split imx-drm/imx-hdmi and conversion to drm-bridge is at the start of the series. Then the rest are bug fixes and feature additions. Cheers, ZubairLK