From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support Date: Fri, 14 Nov 2014 19:13:53 +0800 Message-ID: <5465E3F1.4060407@rock-chips.com> References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935884-17130-1-git-send-email-andy.yan@rock-chips.com> <5465D816.3020708@imgtec.com> <5465DB4F.7090402@rock-chips.com> <5465DF34.303@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5465DF34.303@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach List-Id: devicetree@vger.kernel.org Ck9uIDIwMTTlubQxMeaciDE05pelIDE4OjUzLCBadWJhaXIgTHV0ZnVsbGFoIEtha2FraGVsIHdy b3RlOgo+Cj4gT24gMTQvMTEvMTQgMTA6MzcsIEFuZHkgWWFuIHdyb3RlOgo+PiBPbiAyMDE05bm0 MTHmnIgxNOaXpSAxODoyMywgWnViYWlyIEx1dGZ1bGxhaCBLYWtha2hlbCB3cm90ZToKPj4+IEhp IEFuZHkKPj4+Cj4+PiBPbiAxNC8xMS8xNCAwMzozMSwgQW5keSBZYW4gd3JvdGU6Cj4+Pj4gUm9j a2NoaXAgUkszMjg4IGhkbWkgaXMgY29tcGF0aWJsZSB3aXRoIGR3X2hkbWkKPj4+Pgo+Pj4+IFNp Z25lZC1vZmYtYnk6IEFuZHkgWWFuIDxhbmR5LnlhbkByb2NrLWNoaXBzLmNvbT4KPj4+Pgo+Pj4+ IC0tLQo+Pj4+Cj4+Pj4gQ2hhbmdlcyBpbiB2MTA6Cj4+Pj4gLSBhZGQgbW9yZSBkaXNwbGF5IG1v ZGUgc3VwcG9ydCBtcGxsIGNvbmZpZ3VyYXRpb24gZm9yIHJrMzI4OAo+Pj4+Cj4+Pj4gQ2hhbmdl cyBpbiB2OToKPj4+PiAtIG1vdmUgc29tZSBwaHkgY29uZmlndXJhdGlvbiB0byBwbGF0Zm9ybSBk cml2ZXIKPj4+Pgo+Pj4+IENoYW5nZXMgaW4gdjg6IE5vbmUKPj4+PiBDaGFuZ2VzIGluIHY3OiBO b25lCj4+Pj4gQ2hhbmdlcyBpbiB2NjogTm9uZQo+Pj4+IENoYW5nZXMgaW4gdjU6IE5vbmUKPj4+ PiBDaGFuZ2VzIGluIHY0OiBOb25lCj4+Pj4gQ2hhbmdlcyBpbiB2MzogTm9uZQo+Pj4+IENoYW5n ZXMgaW4gdjI6IE5vbmUKPj4+Pgo+Pj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRt aS5jICAgICAgICAgICAgfCAgMTAgKwo+Pj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdf aGRtaS5oICAgICAgICAgICAgfCAgIDMgKy0KPj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvS2NvbmZpZyAgICAgICAgICAgIHwgIDEwICsKPj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvTWFrZWZpbGUgICAgICAgICAgIHwgICAyICstCj4+Pj4gICAgZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL2R3X2hkbWktcm9ja2NoaXAuYyB8IDM1NSArKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4+Pj4gICAgaW5jbHVkZS9kcm0vYnJpZGdlL2R3X2hkbWkuaCAgICAgICAgICAgICAg ICB8ICAgMSArCj4+Pj4gICAgNiBmaWxlcyBjaGFuZ2VkLCAzNzkgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKPj4+PiAgICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL2R3X2hkbWktcm9ja2NoaXAuYwo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9kd19oZG1p LmMKPj4+PiBpbmRleCBhMjg3NmZlLi4xZGQxZjBiIDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9kd19oZG1pLmMKPj4+PiBAQCAtNzE1LDYgKzcxNSwxMyBAQCBzdGF0aWMgdm9pZCBkd19oZG1p X3BoeV9lbmFibGVfdG1kcyhzdHJ1Y3QgZHdfaGRtaSAqaGRtaSwgdTggZW5hYmxlKQo+Pj4+ICAg ICAgICAgICAgICAgICBIRE1JX1BIWV9DT05GMF9FTlRNRFNfTUFTSyk7Cj4+Pj4gICAgfQo+Pj4+ ICAgICtzdGF0aWMgdm9pZCBkd19oZG1pX3BoeV9lbmFibGVfc3BhcmUoc3RydWN0IGR3X2hkbWkg KmhkbWksIHU4IGVuYWJsZSkKPj4+PiArewo+Pj4+ICsgICAgaGRtaV9tYXNrX3dyaXRlYihoZG1p LCBlbmFibGUsIEhETUlfUEhZX0NPTkYwLAo+Pj4+ICsgICAgICAgICAgICAgSERNSV9QSFlfQ09O RjBfU1BBUkVDVFJMX09GRlNFVCwKPj4+PiArICAgICAgICAgICAgIEhETUlfUEhZX0NPTkYwX1NQ QVJFQ1RSTF9NQVNLKTsKPj4+PiArfQo+Pj4+ICsKPj4+IFdoYXQgZG9lcyBlbmFibGUgc3BhcmUg ZG8/IENhbiBvdGhlciBmdXR1cmUgU29DcyB1c2UgaXQ/Cj4+Pgo+Pj4gVGhpcyBsb29rcyBsaWtl IERXIHNwZWNpZmljLiBBbmQgY2FuIGJlIGEgc2VwYXJhdGUgY29tbWl0IHRoYXQgYWRkcyBhIGZl YXR1cmUgdG8gdGhlIGR3IGhkbWkgZHJpdmVyLgo+PiAgICBBY3R1YWxseSBJIGFtIG5vdCB2ZXJ5 IGNsZWFybHkgYWJvdXQgdGhpcyBiaXQsIGJ1dCBSSzMyODggSERNSSB3aWxsIG5vdCB3b3JrIHdp dGhvdXQgdGhpcyBiaXQgZW5hYmxlLgo+PiAgICBPbiBpbXg2LCB0aGUgZGVzY3JpcHRpb24gYWJv dXQgdGhpcyBiaXQgaXM6UmVzZXJ2ZWQuIFNwYXJlIHBpbiBjb250cm9sLgo+PiAgICBPbiByazMy ODgsIHRoZSBkZXNjcmlwdGlvbiBpczogc3ZzcmV0L3NwYXJlY3RybAo+PiAgICAgQm90aCBhcmUg dmVyeSBzaW1wbGUuCj4gU291bmRzIGxpa2UgdGhlIElQIENvcmUgaW4gdGhlIHJrMzI4OCBpcyBz bGlnaHRseSB1cGdyYWRlZC4KPiBTZXBhcmF0ZSB0aGlzIHNlY3Rpb24gaW4gYSBkaWZmZXJlbnQg Y29tbWl0IGFzIGl0IGlzIGdlbmVyaWMgRFcgc3R1ZmYuCj4KPiBBbmQgYWRkIHdoYXQgeW91IHdy b3RlIGFib3ZlIGluIHRoZSBjb21taXQgbWVzc2FnZS4KICAgT25seSBTZXBhcmF0ZSBmdW5jdGlv biBkd19oZG1pX3BoeV9lbmFsZV9zcGFyZSA/IG5vdCBpbmNsdWRlCiAgIGlmIChoZG1pLT5kZXZf dHlwZSA9PSByazMyODhfaGRtaSkKICAgICAgICAgICAgICAgIGR3X2hkbWlfZW5hYmxlX3BoeV9z cGFyZShoZG1pLCAxKTsKICA/Cj4KPiBUaGFua3MKPiBadWJhaXJMSwo+Cj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBMaW51eC1yb2NrY2hpcCBtYWls aW5nIGxpc3QKPiBMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcg bGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhk cml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965422AbaKNLOD (ORCPT ); Fri, 14 Nov 2014 06:14:03 -0500 Received: from regular1.263xmail.com ([211.150.99.135]:57247 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965132AbaKNLOA (ORCPT ); Fri, 14 Nov 2014 06:14:00 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <0f12b31bcae63e81af35be395d4f26e3> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5465E3F1.4060407@rock-chips.com> Date: Fri, 14 Nov 2014 19:13:53 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach Subject: Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935884-17130-1-git-send-email-andy.yan@rock-chips.com> <5465D816.3020708@imgtec.com> <5465DB4F.7090402@rock-chips.com> <5465DF34.303@imgtec.com> In-Reply-To: <5465DF34.303@imgtec.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年11月14日 18:53, Zubair Lutfullah Kakakhel wrote: > > On 14/11/14 10:37, Andy Yan wrote: >> On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: >>> Hi Andy >>> >>> On 14/11/14 03:31, Andy Yan wrote: >>>> Rockchip RK3288 hdmi is compatible with dw_hdmi >>>> >>>> Signed-off-by: Andy Yan >>>> >>>> --- >>>> >>>> Changes in v10: >>>> - add more display mode support mpll configuration for rk3288 >>>> >>>> Changes in v9: >>>> - move some phy configuration to platform driver >>>> >>>> Changes in v8: None >>>> Changes in v7: None >>>> Changes in v6: None >>>> Changes in v5: None >>>> Changes in v4: None >>>> Changes in v3: None >>>> Changes in v2: None >>>> >>>> drivers/gpu/drm/bridge/dw_hdmi.c | 10 + >>>> drivers/gpu/drm/bridge/dw_hdmi.h | 3 +- >>>> drivers/gpu/drm/rockchip/Kconfig | 10 + >>>> drivers/gpu/drm/rockchip/Makefile | 2 +- >>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 355 ++++++++++++++++++++++++++++ >>>> include/drm/bridge/dw_hdmi.h | 1 + >>>> 6 files changed, 379 insertions(+), 2 deletions(-) >>>> create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>>> >>>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >>>> index a2876fe..1dd1f0b 100644 >>>> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >>>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >>>> @@ -715,6 +715,13 @@ static void dw_hdmi_phy_enable_tmds(struct dw_hdmi *hdmi, u8 enable) >>>> HDMI_PHY_CONF0_ENTMDS_MASK); >>>> } >>>> +static void dw_hdmi_phy_enable_spare(struct dw_hdmi *hdmi, u8 enable) >>>> +{ >>>> + hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0, >>>> + HDMI_PHY_CONF0_SPARECTRL_OFFSET, >>>> + HDMI_PHY_CONF0_SPARECTRL_MASK); >>>> +} >>>> + >>> What does enable spare do? Can other future SoCs use it? >>> >>> This looks like DW specific. And can be a separate commit that adds a feature to the dw hdmi driver. >> Actually I am not very clearly about this bit, but RK3288 HDMI will not work without this bit enable. >> On imx6, the description about this bit is:Reserved. Spare pin control. >> On rk3288, the description is: svsret/sparectrl >> Both are very simple. > Sounds like the IP Core in the rk3288 is slightly upgraded. > Separate this section in a different commit as it is generic DW stuff. > > And add what you wrote above in the commit message. Only Separate function dw_hdmi_phy_enale_spare ? not include if (hdmi->dev_type == rk3288_hdmi) dw_hdmi_enable_phy_spare(hdmi, 1); ? > > Thanks > ZubairLK > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip