From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gary@mlbassoc.com>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id C9E65E008FF; Fri, 14 Nov 2014 05:08:56 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.1
X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id CFE9EE00876
	for <meta-freescale@yoctoproject.org>;
	Fri, 14 Nov 2014 05:08:48 -0800 (PST)
Received: by mail.chez-thomas.org (Postfix, from userid 1998)
	id C4E57F811D8; Fri, 14 Nov 2014 06:08:44 -0700 (MST)
Received: from [192.168.1.114] (zeus [192.168.1.114])
	by mail.chez-thomas.org (Postfix) with ESMTP id E8B3AF811D7;
	Fri, 14 Nov 2014 06:08:43 -0700 (MST)
Message-ID: <5465FEEF.9030300@mlbassoc.com>
Date: Fri, 14 Nov 2014 06:09:03 -0700
From: Gary Thomas <gary@mlbassoc.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: meta-freescale@yoctoproject.org
References: <CAKX08U3LbeOU5jhDhjAnf7fb3MHTWqt1kVFruQeJRK1vZj5euA@mail.gmail.com>	<CAOMZO5Dmb4zX9yBnAmoG0poXRe4gj7=tkUCNXnrV2FXD9SyWcQ@mail.gmail.com>	<CAKX08U3mwz7bi=cco6j2NwAeHXZiLwU2duqbNq7RU__F30ShQg@mail.gmail.com>	<CAKX08U0=OpUkN7iqLQCue33XLapxkEt3FYhrF3MK6DDubz+e1Q@mail.gmail.com>	<CAOMZO5AVwMTbzypCK5NT+QFOrTcw7UXeqQbZCa4CUEvJPxVn9g@mail.gmail.com>	<CAKX08U3M5gMnhWBgP1teskDbhyMRbPvoQp6UXQv1mMMBx81K=w@mail.gmail.com>
	<CAOMZO5D5eSGUtWGDtA5LLtuQoH_kb-KutF6Det+8zbA_FUoS-Q@mail.gmail.com>
In-Reply-To: <CAOMZO5D5eSGUtWGDtA5LLtuQoH_kb-KutF6Det+8zbA_FUoS-Q@mail.gmail.com>
Subject: Re: Is there lcd support for imx6dl in kernel 3.17?
X-BeenThere: meta-freescale@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Usage and development list for the meta-fsl-* layers
	<meta-freescale.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/meta-freescale>,
	<mailto:meta-freescale-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/meta-freescale>
List-Post: <mailto:meta-freescale@yoctoproject.org>
List-Help: <mailto:meta-freescale-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/meta-freescale>,
	<mailto:meta-freescale-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2014 13:08:56 -0000
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

On 2014-11-13 14:10, Fabio Estevam wrote:
> On Thu, Nov 13, 2014 at 7:01 PM, Stefan <strawberryblack@googlemail.com> wrote:
>>> With interface-pix-fmt = "bgr666"; colors are ok,
>>> but there is some noise on the screen - looks like twinkling pixel faults.
>>> This is just the case for images in framebuffer, not for console text.
>>
>> Reason is, that pixelclk-active is not used to set value of sig_cfg.clk_pol,
>> so it's rising instead of falling edge.
>>
>> Used the following workaround:
>>
>> --- a/drivers/staging/imx-drm/ipuv3-crtc.c
>> +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
>> @@ -166,7 +166,9 @@
>>          sig_cfg.Vsync_pol = 1;
>>
>>      sig_cfg.enable_pol = 1;
>> -   sig_cfg.clk_pol = 0;
>> +   sig_cfg.clk_pol = 0; /* rising edge */
>> +   if (mode->private_flags & DRM_MODE_FLAG_PCSYNC) /* falling edge  */
>> +       sig_cfg.clk_pol = 1;
>>      sig_cfg.width = mode->hdisplay;
>>      sig_cfg.height = mode->vdisplay;
>>      sig_cfg.pixel_fmt = out_pixel_fmt;
>> diff --git a/drivers/staging/imx-drm/parallel-display.c
>> b/drivers/staging/imx-drm/parallel-display.c
>> index 4ca61af..bf7eee4 100644
>> --- a/drivers/staging/imx-drm/parallel-display.c
>> +++ b/drivers/staging/imx-drm/parallel-display.c
>> @@ -26,6 +26,8 @@
>>   #include <drm/drm_panel.h>
>>   #include <linux/videodev2.h>
>>   #include <video/of_display_timing.h>
>> +#include <video/videomode.h>
>> +#include <video/of_videomode.h>
>>
>>   #include "imx-drm.h"
>>
>> @@ -80,11 +82,15 @@
>>
>>      if (np) {
>>          struct drm_display_mode *mode = drm_mode_create(connector->dev);
>> +       struct videomode vm;
>>          if (!mode)
>>              return -EINVAL;
>>          of_get_drm_display_mode(np, &imxpd->mode, OF_USE_NATIVE_MODE);
>>          drm_mode_copy(mode, &imxpd->mode);
>>          mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
>> +       /* imxpd->mode.flags does not contain all flags from devicetree */
>> +       of_get_videomode(np, &vm, OF_USE_NATIVE_MODE);
>> +       mode->private_flags=vm.flags;
>>          drm_mode_probed_add(connector, mode);
>>          num_modes++;
>
> It would be nice if you could submit this as a formal patch to the
> devel@driverdev.osuosl.org list.

Stefan,

Could you also send (at least to me if you don't want to CC the list)
your final device tree that works with your LCD display?

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------