From: Richard Henderson <rth@twiddle.net>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 0/4] Add TriCore RCPW, RCRR, RCRW, RLC and RCR instructions
Date: Fri, 14 Nov 2014 14:41:07 +0100 [thread overview]
Message-ID: <54660673.40004@twiddle.net> (raw)
In-Reply-To: <1415898767-20461-1-git-send-email-kbastian@mail.uni-paderborn.de>
On 11/13/2014 06:12 PM, Bastian Koppelmann wrote:
> Hi,
>
> this patch depends on the previous TriCore patches (https://patchwork.ozlabs.org/patch/405459/) and will hopefully end up in 2.3 QEMU.
> Other than adding the RCPW, RCRR, RCRW, RLC and RCR instructions, it cleans up how ISA versions in the feature bitmask are handled,
> to simplify the checks, when instructions are available.
>
> Thanks,
> Bastian
>
> v1 -> v2:
> - Fixed obvious style errors, given by checkpatch.
>
> Bastian Koppelmann (4):
> target-tricore: Make TRICORE_FEATURES implying others.
> target-tricore: Add instructions of RCPW, RCRR and RCRW opcode format
> target-tricore: Add instructions of RLC opcode format
> target-tricore: Add instructions of RCR opcode format
Patches 1-3 get
Reviewed-by: Richard Henderson <rth@twiddle.net>
Patch 4 looks correct, but appears to work too hard.
r~
prev parent reply other threads:[~2014-11-14 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 17:12 [Qemu-devel] [PATCH v2 0/4] Add TriCore RCPW, RCRR, RCRW, RLC and RCR instructions Bastian Koppelmann
2014-11-13 17:12 ` [Qemu-devel] [PATCH v2 1/4] target-tricore: Make TRICORE_FEATURES implying others Bastian Koppelmann
2014-11-13 17:12 ` [Qemu-devel] [PATCH v2 2/4] target-tricore: Add instructions of RCPW, RCRR and RCRW opcode format Bastian Koppelmann
2014-11-13 17:12 ` [Qemu-devel] [PATCH v2 3/4] target-tricore: Add instructions of RLC " Bastian Koppelmann
2014-11-13 17:12 ` [Qemu-devel] [PATCH v2 4/4] target-tricore: Add instructions of RCR " Bastian Koppelmann
2014-11-14 13:39 ` Richard Henderson
2014-11-19 13:35 ` Bastian Koppelmann
2014-11-14 13:41 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54660673.40004@twiddle.net \
--to=rth@twiddle.net \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.