From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) Date: Fri, 14 Nov 2014 16:36:50 +0100 Subject: [PATCH v7 03/13] ARM: Berlin: select the reset controller In-Reply-To: <3287202.nx0cnO5WUI@wuerfel> References: <1415978763-27345-1-git-send-email-antoine.tenart@free-electrons.com> <1415978763-27345-4-git-send-email-antoine.tenart@free-electrons.com> <3287202.nx0cnO5WUI@wuerfel> Message-ID: <54662192.6000403@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/14/2014 04:33 PM, Arnd Bergmann wrote: > On Friday 14 November 2014 16:25:53 Antoine Tenart wrote: >> menuconfig ARCH_BERLIN >> bool "Marvell Berlin SoCs" if ARCH_MULTI_V7 >> + select ARCH_HAS_RESET_CONTROLLER >> select ARCH_REQUIRE_GPIOLIB >> select ARM_GIC >> select GENERIC_IRQ_CHIP >> select DW_APB_ICTL >> select DW_APB_TIMER_OF >> select PINCTRL >> + select RESET_CONTROLLER > > RESET_CONTROLLER is meant to be user-selectable, don't add a 'select' here, > but instead make the driver 'depends on RESET_CONTROLLER'. It already went into arm-soc for v3.19 - ergo, we need an extra patch for removing the current 'select'. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH v7 03/13] ARM: Berlin: select the reset controller Date: Fri, 14 Nov 2014 16:36:50 +0100 Message-ID: <54662192.6000403@gmail.com> References: <1415978763-27345-1-git-send-email-antoine.tenart@free-electrons.com> <1415978763-27345-4-git-send-email-antoine.tenart@free-electrons.com> <3287202.nx0cnO5WUI@wuerfel> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3287202.nx0cnO5WUI@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann , Antoine Tenart Cc: Peter.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 11/14/2014 04:33 PM, Arnd Bergmann wrote: > On Friday 14 November 2014 16:25:53 Antoine Tenart wrote: >> menuconfig ARCH_BERLIN >> bool "Marvell Berlin SoCs" if ARCH_MULTI_V7 >> + select ARCH_HAS_RESET_CONTROLLER >> select ARCH_REQUIRE_GPIOLIB >> select ARM_GIC >> select GENERIC_IRQ_CHIP >> select DW_APB_ICTL >> select DW_APB_TIMER_OF >> select PINCTRL >> + select RESET_CONTROLLER > > RESET_CONTROLLER is meant to be user-selectable, don't add a 'select' here, > but instead make the driver 'depends on RESET_CONTROLLER'. It already went into arm-soc for v3.19 - ergo, we need an extra patch for removing the current 'select'. Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965656AbaKNPg6 (ORCPT ); Fri, 14 Nov 2014 10:36:58 -0500 Received: from mail-wg0-f54.google.com ([74.125.82.54]:52229 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964875AbaKNPg4 (ORCPT ); Fri, 14 Nov 2014 10:36:56 -0500 Message-ID: <54662192.6000403@gmail.com> Date: Fri, 14 Nov 2014 16:36:50 +0100 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 To: Arnd Bergmann , Antoine Tenart CC: Peter.Chen@freescale.com, balbi@ti.com, p.zabel@pengutronix.de, alexandre.belloni@free-electrons.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 03/13] ARM: Berlin: select the reset controller References: <1415978763-27345-1-git-send-email-antoine.tenart@free-electrons.com> <1415978763-27345-4-git-send-email-antoine.tenart@free-electrons.com> <3287202.nx0cnO5WUI@wuerfel> In-Reply-To: <3287202.nx0cnO5WUI@wuerfel> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/2014 04:33 PM, Arnd Bergmann wrote: > On Friday 14 November 2014 16:25:53 Antoine Tenart wrote: >> menuconfig ARCH_BERLIN >> bool "Marvell Berlin SoCs" if ARCH_MULTI_V7 >> + select ARCH_HAS_RESET_CONTROLLER >> select ARCH_REQUIRE_GPIOLIB >> select ARM_GIC >> select GENERIC_IRQ_CHIP >> select DW_APB_ICTL >> select DW_APB_TIMER_OF >> select PINCTRL >> + select RESET_CONTROLLER > > RESET_CONTROLLER is meant to be user-selectable, don't add a 'select' here, > but instead make the driver 'depends on RESET_CONTROLLER'. It already went into arm-soc for v3.19 - ergo, we need an extra patch for removing the current 'select'. Sebastian