From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down Date: Fri, 14 Nov 2014 11:24:17 -0500 Message-ID: <54662CB1.2050505@oracle.com> References: <1415661410-5191-1-git-send-email-boris.ostrovsky@oracle.com> <1415661410-5191-2-git-send-email-boris.ostrovsky@oracle.com> <21606.5282.659930.728522@mariner.uk.xensource.com> <54662004.6050702@oracle.com> <21606.10103.850619.644934@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21606.10103.850619.644934@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 11/14/2014 11:01 AM, Ian Jackson wrote: > Boris Ostrovsky writes ("Re: [PATCH 1/2] libxl: Wait until QEMU removed the device before tearing it down"): > > >> And I believe we still need part of the second patch --- the one that >> removes call to xc_domain_irq_permission() for PV guests (after your >> patch is applied): this call will fail because xc_physdev_unmap_pirq() >> above it will cause hypervisor to do unmap_domain_pirq()->irq_deny_access() > What call to xc_physdev_unmap_pirq ? I see one in the PV path. (Now with Reply-all, sorry) At the skip1 label. The error is: [root@ovs105 libxl]# ./xl pci-detach pvlinux 0000:09:00.1 libxl: error: libxl_pci.c:1305:do_pci_remove: xc_domain_irq_permission irq=17: Invalid argument [root@ovs105 libxl]# Thanks. -boris