From: Dave Hansen <dave@sr71.net>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, hpa@zytor.com
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
qiaowei.ren@intel.com, dave.hansen@linux.intel.com
Subject: Re: [PATCH 05/11] x86, mpx: add MPX to disaabled features
Date: Fri, 14 Nov 2014 18:38:03 +0000 [thread overview]
Message-ID: <54664C0B.6070604@sr71.net> (raw)
In-Reply-To: <5466425D.1060100@cogentembedded.com>
On 11/14/2014 09:56 AM, Sergei Shtylyov wrote:
>> #define DISABLED_MASK6 0
>> #define DISABLED_MASK7 0
>> #define DISABLED_MASK8 0
>> -#define DISABLED_MASK9 0
>> +#define DISABLED_MASK9 (DISABLE_MPX)
>
> These parens are not really needed. Sorry to be a PITA and not saying
> this before.
One goal of the disabled features patch was to maintain parity with
required-features.h. It declares things this way:
> #define REQUIRED_MASK3 (NEED_NOPL)
> #define REQUIRED_MASK4 (NEED_MOVBE)
So, no, those aren't strictly needed, but there is precedent for them
and they do no harm. I think I'll leave them as-is.
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, hpa@zytor.com
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
qiaowei.ren@intel.com, dave.hansen@linux.intel.com
Subject: Re: [PATCH 05/11] x86, mpx: add MPX to disaabled features
Date: Fri, 14 Nov 2014 10:38:03 -0800 [thread overview]
Message-ID: <54664C0B.6070604@sr71.net> (raw)
In-Reply-To: <5466425D.1060100@cogentembedded.com>
On 11/14/2014 09:56 AM, Sergei Shtylyov wrote:
>> #define DISABLED_MASK6 0
>> #define DISABLED_MASK7 0
>> #define DISABLED_MASK8 0
>> -#define DISABLED_MASK9 0
>> +#define DISABLED_MASK9 (DISABLE_MPX)
>
> These parens are not really needed. Sorry to be a PITA and not saying
> this before.
One goal of the disabled features patch was to maintain parity with
required-features.h. It declares things this way:
> #define REQUIRED_MASK3 (NEED_NOPL)
> #define REQUIRED_MASK4 (NEED_MOVBE)
So, no, those aren't strictly needed, but there is precedent for them
and they do no harm. I think I'll leave them as-is.
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, hpa@zytor.com
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
qiaowei.ren@intel.com, dave.hansen@linux.intel.com
Subject: Re: [PATCH 05/11] x86, mpx: add MPX to disaabled features
Date: Fri, 14 Nov 2014 10:38:03 -0800 [thread overview]
Message-ID: <54664C0B.6070604@sr71.net> (raw)
In-Reply-To: <5466425D.1060100@cogentembedded.com>
On 11/14/2014 09:56 AM, Sergei Shtylyov wrote:
>> #define DISABLED_MASK6 0
>> #define DISABLED_MASK7 0
>> #define DISABLED_MASK8 0
>> -#define DISABLED_MASK9 0
>> +#define DISABLED_MASK9 (DISABLE_MPX)
>
> These parens are not really needed. Sorry to be a PITA and not saying
> this before.
One goal of the disabled features patch was to maintain parity with
required-features.h. It declares things this way:
> #define REQUIRED_MASK3 (NEED_NOPL)
> #define REQUIRED_MASK4 (NEED_MOVBE)
So, no, those aren't strictly needed, but there is precedent for them
and they do no harm. I think I'll leave them as-is.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-11-14 18:38 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 15:18 [PATCH 00/11] [v11] Intel MPX support Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` [PATCH 01/11] x86, mpx: rename cfg_reg_u and status_reg Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:05 ` [tip:x86/mpx] x86, mpx: Rename " tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 02/11] mpx: extend siginfo structure to include bound violation information Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:05 ` [tip:x86/mpx] mpx: Extend " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 03/11] mips: sync struct siginfo with general version Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:05 ` [tip:x86/mpx] mips: Sync " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 04/11] ia64: sync " Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:05 ` [tip:x86/mpx] ia64: Sync " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 05/11] x86, mpx: add MPX to disaabled features Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 17:56 ` Sergei Shtylyov
2014-11-14 17:56 ` Sergei Shtylyov
2014-11-14 17:56 ` Sergei Shtylyov
2014-11-14 18:38 ` Dave Hansen [this message]
2014-11-14 18:38 ` Dave Hansen
2014-11-14 18:38 ` Dave Hansen
2014-11-18 0:06 ` [tip:x86/mpx] x86, mpx: Add MPX to disabled features tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 06/11] x86, mpx: introduce VM_MPX to indicate that a VMA is MPX specific Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:06 ` [tip:x86/mpx] x86, mpx: Introduce " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 07/11] x86, mpx: add MPX-specific mmap interface Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:06 ` [tip:x86/mpx] x86, mpx: Add " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 08/11] x86, mpx: [new code] decode MPX instruction to get bound violation information Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:07 ` [tip:x86/mpx] x86, mpx: Decode " tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 09/11] x86, mpx: on-demand kernel allocation of bounds tables Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 16:47 ` Thomas Gleixner
2014-11-14 16:47 ` Thomas Gleixner
2014-11-14 16:47 ` Thomas Gleixner
2014-11-14 17:10 ` Dave Hansen
2014-11-14 17:10 ` Dave Hansen
2014-11-18 0:07 ` [tip:x86/mpx] x86, mpx: On-demand " tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 10/11] x86, mpx: cleanup unused bound tables Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:07 ` [tip:x86/mpx] x86, mpx: Cleanup " tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 11/11] x86, mpx: add documentation on Intel MPX Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:08 ` [tip:x86/mpx] x86, mpx: Add " tip-bot for Qiaowei Ren
-- strict thread matches above, loose matches on Subject: below --
2014-11-12 17:04 [PATCH 00/11] [v10] Intel MPX support Dave Hansen
2014-11-12 17:04 ` [PATCH 05/11] x86, mpx: add MPX to disaabled features Dave Hansen
2014-11-12 17:04 ` Dave Hansen
2014-11-12 17:04 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54664C0B.6070604@sr71.net \
--to=dave@sr71.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=qiaowei.ren@intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.